GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Modules, introduction by EzequielCaste · Pull Request #198 · javascript-tutorial/es.javascript.info

Conversation

@EzequielCaste

@EzequielCaste EzequielCaste commented May 19, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EzequielCaste
modules_intro_trad
26b8c4b
@javascript-translate-bot javascript-translate-bot added the review needed label May 19, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team May 19, 2020 22:52
@javascript-translate-bot

javascript-translate-bot commented May 19, 2020

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 197 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iliakan iliakan mentioned this pull request May 19, 2020
Spanish Translation Progress #17
Open
joaquinelio
joaquinelio approved these changes May 25, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gusta.
Me gustarían algunos cambios pero es gusto personal o cosas que no hacen al JS...

y tenemos 70 y pico de PR por meter, el doble de review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EzequielCaste reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/13-modules/01-modules-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/13-modules/01-modules-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/13-modules/01-modules-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels May 25, 2020
@EzequielCaste
correcciones
f4af020
joaquinelio
joaquinelio approved these changes May 27, 2020
View reviewed changes
@EzequielCaste
EzequielCaste merged commit 4ad4b7f into javascript-tutorial:master May 27, 2020
@javascript-translate-bot

javascript-translate-bot commented May 27, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaquinelio

joaquinelio commented May 27, 2020

Copy link
Copy Markdown
Member

@ezzep66 ¡Qué emoción!
log

Una cosita... El bot sugiere 2 reviewers (quedó colgado el status needs+1) , cmo maintainer es tu prerrogativa no hacerle caso ¿vamos a trabajar así?
Por mí BIEN, prefiero que se filtre algún errorcito a ver que diluye por falta de interés como el año pasado. Además cuando se termine el resto se pueden revisar los PR cerrados ver cuál necesita rechequeo, no me preocupa.

Era deprimente el mensaje "last commit" parado un año. Podemos decir que avanza,
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EzequielCaste EzequielCaste removed the needs +1 label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EzequielCaste @javascript-translate-bot @joaquinelio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.