GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Numbers by joaquinelio · Pull Request #200 · javascript-tutorial/es.javascript.info

Conversation

@joaquinelio

@joaquinelio joaquinelio commented May 22, 2020

Copy link
Copy Markdown
Member

1.5.2 number completito y probado con server local

NOTAS

diff - Me basé en EN.javascript.info
que es más nuevo, tiene algunas correcciones,
e incluye breve descripción de bigInt (hay un link al capítulo bigInt que no existe -easy fix, boss-)

Volé (parte de) un párrafo que tiene sentido en inglés pero no en castellano,
referida a cómo abrevian en palabras los números "somos perezosos", en español no usamos esas abreviaturas y en ESTE particular caso no tiene sentido explicarlas y aclarar que nosotros no lo hacemos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joaquinelio
number 1.5.2 completito
f9eb4e2
@javascript-translate-bot javascript-translate-bot added the review needed label May 22, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team May 22, 2020 20:11
@joaquinelio
Merge branch 'master' into numbers
dd323bc
EzequielCaste
EzequielCaste requested changes Jun 1, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me pareció bien.
sugerí algunos cambios.
🚀 🍕

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/05-data-types/02-number/1-sum-interface/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/1-sum-interface/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/1-sum-interface/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/2-why-rounded-down/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/3-repeat-until-number/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Jun 1, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 1, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Jun 1, 2020
joaquinelio and others added 2 commits June 2, 2020 00:25
@joaquinelio @EzequielCaste
Apply suggestions from code review
c5435e4 
/done

Co-authored-by: Ezequiel Castellanos <[email protected]>
@joaquinelio @EzequielCaste
Apply suggestions from code review
71e68bc 
/done

Co-authored-by: Ezequiel Castellanos <[email protected]>
@joaquinelio joaquinelio changed the title numbers Numbers Jun 3, 2020
@iliakan iliakan mentioned this pull request Jun 3, 2020
Spanish Translation Progress #17
Open
@joaquinelio
joaquinelio requested a review from EzequielCaste June 4, 2020 06:36
EzequielCaste
EzequielCaste approved these changes Jun 4, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Jun 4, 2020
@vplentinax
vplentinax merged commit e94892d into javascript-tutorial:master Jun 6, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 6, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaquinelio
joaquinelio deleted the numbers branch July 15, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@joaquinelio @javascript-translate-bot @EzequielCaste @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.