GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Destructuring assignment by EzequielCaste · Pull Request #259 · javascript-tutorial/es.javascript.info

Conversation

EzequielCaste commented Jun 17, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          traducción destructuring assignment

d4ab65a

javascript-translate-bot added the review needed label

Jun 17, 2020

javascript-translate-bot requested a review from a team

June 17, 2020 00:10

javascript-translate-bot commented Jun 17, 2020

Copy link

Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 163 ⁉️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste requested a review from vplentinax

June 17, 2020 00:11

iliakan mentioned this pull request

Jun 17, 2020

Spanish Translation Progress #17

Open

joaquinelio requested changes

Jul 5, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falta traducir 1-5-10-1 task (movido hace poco)
faltan traducir líneas de article
Apareció key para mortificarme... pero acá zafa, asi que no comenté.
¿Te parece que corrija chiquiteces como signos asimétricos ¡!, espacios extras, inicios en mayúscula y cosas así? ¿O preferís una revisión más blanda y rápida? Me adapto a ambas, lo único prioritario es la precisión en JS.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/10-destructuring-assignment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 5, 2020

javascript-translate-bot commented Jul 5, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste commented Jul 6, 2020

Copy link

Copy Markdown

Contributor Author

falta traducir 1-5-10-1 task (movido hace poco)
faltan traducir líneas de article
Apareció key para mortificarme... pero acá zafa, asi que no comenté.
¿Te parece que corrija chiquiteces como signos asimétricos ¡!, espacios extras, inicios en mayúscula y cosas así? ¿O preferís una revisión más blanda y rápida? Me adapto a ambas, lo único prioritario es la precisión en JS.

y quíen estableció esa prioridad? hubo votación y no me notificaron... que fea actitud.

@joaquinelio repasemos cómo hacer un Review tu trabajo es revisar y corregir errores. Espacios, mayúsculas, números de líneas, gramática, ortografía, etc.
Por suerte tenemos la herramienta de sugerir cambios:

Recomiendo usar esa herramienta siempre.
Lo ideal sería que el autor de la traducción corrija sus errores así puede ver en qué se equivoco y tratar de mejorar sus próximas traducciones.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste and others added 3 commits

July 6, 2020 09:15


          add 1 5 10 1

7c134ff

traducción de task


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

f6f92be

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

98969fb

Co-authored-by: joaquinelio <[email protected]>

javascript-tutorial deleted a comment from joaquinelio

Jul 6, 2020

EzequielCaste and others added 9 commits

July 6, 2020 09:24


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

2b3aebe

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

166c158

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

fca6843

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

2ce0af2

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

9b09899

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

e145df9

Co-authored-by: joaquinelio <[email protected]>


          corrección línea 142 143 article

a0865f9


          Merge branch 'destructuring-assig' of https://github.com/ezzep66/es.j…

a1a5339

…avascript.info into destructuring-assig


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

765ff70

Co-authored-by: joaquinelio <[email protected]>

EzequielCaste removed the request for review from vplentinax

July 6, 2020 12:41

EzequielCaste and others added 5 commits

July 6, 2020 09:42


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

a04ca4f

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

9e7ba34

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

c2464ea

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

a9f09d2

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

6172fb3

Co-authored-by: joaquinelio <[email protected]>

EzequielCaste and others added 2 commits

July 6, 2020 09:47


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

9764be7

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/10-destructuring-assignment/article.md

757ac91

Co-authored-by: joaquinelio <[email protected]>

EzequielCaste commented

Jul 6, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cambios

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

EzequielCaste commented

Jul 6, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio commented Jul 7, 2020

Copy link

Copy Markdown

Member

Estamos chocando más seguido eso es bueno. Es porque ya limpiamos todo ¡este es el más viejo PR, de 20 días!
Solo salto a uno más nuevo cuando veo uno que no es del trio fantásico, lo que desanimó el año pasado a tantos altruistas es la falta de realimentación. Recomiendo prestar especial atención a los pr de los nuevos.

Prioridad precisión JS. Me expresé mal, es la mia. La votación la resigné en uds.
1 precision JS
2 claridad. Aunque se aparte de EN pero con cuidado, no corresponde reinterpretar.
3 glosario, buen sistema de nombres... bue, no pudo ser
4 literariamente correcto. Prefiero el "good enough" a que se abandone por revisiones exigentes.
Bien puedo saltear un // Bravo!
o una coma entre sujeto y verbo.

REVIEW es un EMBOLE pero hay escasez, asi que me resigno aunque no me queda gana para además hacer nuevas. Lo peor en tiempo y frustración, tildes. Suerte que uds son buenos en eso y también en lo conceptual de JS, pocos arreglos ahí.

La suggest la uso siempre que puedo: cuando sé. Si no, solo pongo la queja 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio approved these changes

Jul 7, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, creo. O estoy dormido.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed changes requested labels

Jul 7, 2020

vplentinax self-requested a review

July 7, 2020 20:42

vplentinax approved these changes

Jul 7, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

EzequielCaste merged commit b02ef3a into javascript-tutorial:master

Jul 8, 2020

javascript-translate-bot commented Jul 8, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.