GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Map and Set by vplentinax · Pull Request #263 · javascript-tutorial/es.javascript.info

Conversation

vplentinax commented Jun 18, 2020

Copy link

Copy Markdown

Contributor

Arreglado los errores de formato.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          mapset

cd5ac90

javascript-translate-bot added the review needed label

Jun 18, 2020

javascript-translate-bot requested a review from a team

June 18, 2020 21:41

iliakan mentioned this pull request

Jun 18, 2020

Spanish Translation Progress #17

Open

javascript-tutorial deleted a comment from javascript-translate-bot

Jun 18, 2020

EzequielCaste self-requested a review

July 4, 2020 14:03

EzequielCaste requested changes

Jul 4, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay error al comienzo de 1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md
No se ha respetado los números de las líneas. Debe comenzar en línea N° 1 y no en la N°2.

Por favor corregir así puedo seguir con la revisión.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 4, 2020

javascript-translate-bot commented Jul 4, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste added 6 commits

July 4, 2020 11:38


          update solution

981da7f

arreglé el problema de los espacios.
Por favor tienen que coincidir los números de las líneas con el documento Original.


          update task

e4ceae7

problemas con la numeración de líneas


          update solution

78e1bfa

número de líneas


          corrección de líneas

e61c2a6

respetar el número de línea


          corrección número líneas

1c79cbe


          fixed line numbers

883cd95

EzequielCaste requested changes

Jul 4, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchos problemas con espacios donde no deberían estar.
Se debe respetar el número de línea del documento original.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/07-map-set/03-iterable-keys/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/07-map-set/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jul 4, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 12 commits

July 4, 2020 19:15


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

e6f57ea

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

af49a81

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

459c874

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

f6f6016

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

438b4d7

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

e101acc

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md

f754d71

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/03-iterable-keys/task.md

740687f

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

444e0a5

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

669b0ff

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

c3f6fc4

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

b2df4f7

Co-authored-by: Ezequiel Castellanos <[email protected]>

vplentinax and others added 5 commits

July 4, 2020 19:18


          Update 1-js/05-data-types/07-map-set/article.md

2c56508

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

74fee8b

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/05-data-types/07-map-set/article.md

3b5c116

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update task.md

7dcaca0

vplentinax commented Jul 4, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 4, 2020

javascript-translate-bot requested a review from a team

July 4, 2020 23:23

EzequielCaste approved these changes

Jul 5, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Jul 5, 2020

vplentinax merged commit 6249f2a into javascript-tutorial:master

Jul 5, 2020

javascript-translate-bot commented Jul 5, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 5, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

@vplentinax @ezzep66
¿Merged? Lo tenía recién en una pestaña para revisión...
Estoy de ACUERDO con los merge aprobados por la trusted people, (después de la carga, revisar el repo entero)
¿pero qué pasó con eso del doble review que pide don Bot?
No me quejo, es saber cuál es el criterio.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jul 5, 2020

Copy link

Copy Markdown

Contributor Author

En mis PR el segundo review lo doy yo jejeje.

joaquinelio reacted with thumbs up emoji

joaquinelio reacted with rocket emoji

All reactions

👍 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

EzequielCaste

EzequielCaste approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vplentinax commented Jun 18, 2020

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 4, 2020

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 4, 2020

Uh oh!

vplentinax commented Jul 4, 2020

Uh oh!

javascript-translate-bot commented Jul 5, 2020

Uh oh!

joaquinelio commented Jul 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vplentinax commented Jul 5, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joaquinelio commented Jul 5, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.