GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Function expressions by EzequielCaste · Pull Request #272 · javascript-tutorial/es.javascript.info

Conversation

@EzequielCaste

@EzequielCaste EzequielCaste commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EzequielCaste
traducción function expressions
75b2573
@javascript-translate-bot javascript-translate-bot added the review needed label Jun 22, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 22, 2020 19:30
@iliakan iliakan mentioned this pull request Jun 22, 2020
Spanish Translation Progress #17
Open
cortizg
cortizg suggested changes Jun 28, 2020
View reviewed changes

@cortizg cortizg left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy buena traducción, 1 typo: excelente, full review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/16-function-expressions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jun 28, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 28, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EzequielCaste @cortizg
Update 1-js/02-first-steps/16-function-expressions/article.md
ce72f3b 
Co-authored-by: Carlos Ortiz Gutiérrez <[email protected]>
@EzequielCaste

EzequielCaste commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jun 28, 2020
@EzequielCaste EzequielCaste added needs +1 review needed and removed review needed needs +1 labels Jun 28, 2020
@EzequielCaste

EzequielCaste commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

@cortizg lo tienes que aprobar después que hice los cambios.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cortizg

cortizg commented Jun 28, 2020

Copy link
Copy Markdown
Contributor

@cortizg lo tienes que aprobar después que hice los cambios.

copiado, jejeje estoy rucky aùn!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cortizg

cortizg commented Jun 28, 2020

Copy link
Copy Markdown
Contributor

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EzequielCaste

EzequielCaste commented Jul 4, 2020

Copy link
Copy Markdown
Contributor Author

@cortizg Falta la aprobación.
el "done" lo hace el autor del PR para decir que ya realizó los cambios que le fueron solicitados.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cortizg
cortizg approved these changes Jul 5, 2020
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jul 5, 2020
vplentinax
vplentinax approved these changes Jul 5, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EzequielCaste
EzequielCaste merged commit 407cffc into javascript-tutorial:master Jul 5, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 5, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax approved these changes
+1 more reviewer
@cortizg cortizg cortizg approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@EzequielCaste @javascript-translate-bot @cortizg @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.