GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Class inheritance by cortizg · Pull Request #274 · javascript-tutorial/es.javascript.info

Conversation

cortizg commented Jun 22, 2020

Copy link

Copy Markdown

Contributor

Replacing PR #177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the review needed label

Jun 22, 2020

javascript-translate-bot requested a review from a team

June 22, 2020 20:25

javascript-translate-bot commented Jun 22, 2020

Copy link

Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 171 ⁉️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          traducción 1-09-02-ci

d4daaa6

iliakan mentioned this pull request

Jul 5, 2020

Spanish Translation Progress #17

Open

joaquinelio requested changes

Jul 5, 2020

View reviewed changes

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override: "montarse encima", a veces decimos "pisar", no es "anular" en programación.
puse sobrescribir en los suggest, tampoco me convence BUSCAR MEJOR PALABRA

Sí podrías ANULAR un método, "sobrescribiendo" uno vacío, pero es más amplio que eso.
Podes reemplazarlo, para que haga algo distinto,
También podes extenderlo, eso es lo que haces con el contructor cuando llamás super(),
edit:
No quise usar "extender", que tiene su propia concepto "extend" para clases,
pero es eso. Podriamos usa expandir...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/09-classes/02-class-inheritance/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/09-classes/02-class-inheritance/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/09-classes/02-class-inheritance/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/09-classes/02-class-inheritance/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/09-classes/02-class-inheritance/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 5, 2020

javascript-translate-bot commented Jul 5, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cortizg and others added 5 commits

July 6, 2020 20:25


          Update 1-js/09-classes/02-class-inheritance/article.md

47f058a

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/09-classes/02-class-inheritance/article.md

67e3918

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/09-classes/02-class-inheritance/article.md

ec24429

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/09-classes/02-class-inheritance/article.md

f05f15c

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/09-classes/02-class-inheritance/article.md

caa08db

Co-authored-by: joaquinelio <[email protected]>

cortizg commented Jul 7, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 7, 2020

javascript-translate-bot requested a review from a team

July 7, 2020 02:28

joaquinelio approved these changes

Jul 7, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos resolviendo ya casi contemporáneo... ¡pr de hace dos semanas!
Mejor aun , ya superamos el tercio de repo...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Jul 7, 2020

vplentinax self-requested a review

July 7, 2020 15:41

vplentinax approved these changes

Jul 7, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax merged commit 358423e into javascript-tutorial:master

Jul 7, 2020

javascript-translate-bot commented Jul 7, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

cortizg commented Jun 22, 2020

Uh oh!

javascript-translate-bot commented Jun 22, 2020

Uh oh!

joaquinelio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 5, 2020

Uh oh!

cortizg commented Jul 7, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 7, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.