GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — JSON methods, toJSON by EzequielCaste · Pull Request #278 · javascript-tutorial/es.javascript.info

Conversation

@EzequielCaste

@EzequielCaste EzequielCaste commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

actualizados los nombres de archivos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@EzequielCaste
traducción json methods
08509de
@EzequielCaste
EzequielCaste requested a review from vplentinax June 22, 2020 23:19
@javascript-translate-bot javascript-translate-bot added the review needed label Jun 22, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 22, 2020 23:19
@iliakan iliakan mentioned this pull request Jun 22, 2020
Spanish Translation Progress #17
Open
joaquinelio
joaquinelio requested changes Jul 6, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://tools.ietf.org/html/rfc4627 no anda, pero el nombre está registrado quizas sea temporal

¿corrijo los signos de apertura? Español exige simetría ¿¿¡¡!!?? salvo ¡¡?? y (?)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/05-data-types/12-json/2-serialize-event-circular/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Jul 6, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 6, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Jul 6, 2020
EzequielCaste and others added 12 commits July 8, 2020 09:00
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/2-serialize-event-circular/task.md
67cf345
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
bef3826
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
77d8205
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
816e630
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
b7f2e14
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
222b916
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
c7e2b99
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
c523264
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
bff4acd
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
eb3c914
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
6c398c1
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
7e2be2b
Co-authored-by: joaquinelio <[email protected]>
EzequielCaste
EzequielCaste commented Jul 8, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correcciones

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@EzequielCaste
EzequielCaste removed the request for review from vplentinax July 8, 2020 12:16
@EzequielCaste

EzequielCaste commented Jul 11, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 11, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 11, 2020 15:04
joaquinelio
joaquinelio requested changes Jul 12, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"request" para label correcto,
cosass menores, desp de eso que el 2do reviewer considere que lo apprové

Si le interesa a alguien, "there is no..." a veces se traduce "no está permitido".
No sé si es inglés general o una particcularidad yanqui
"There is no walking in the red zone"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/05-data-types/12-json/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Jul 12, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Jul 12, 2020
EzequielCaste and others added 5 commits July 13, 2020 09:08
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
5f21aa8
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
28fb630
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
91ab19c
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
e63a07c
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 1-js/05-data-types/12-json/article.md
3084859
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste

EzequielCaste commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 13, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 13, 2020 12:15
EzequielCaste
EzequielCaste commented Jul 13, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@EzequielCaste

EzequielCaste commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EzequielCaste
EzequielCaste removed the request for review from a team July 13, 2020 12:20
@EzequielCaste

EzequielCaste commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Jul 13, 2020

Copy link
Copy Markdown
Member

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

@ezzep66
Pfff reglas, reglas, reglas,
o el dedo que apunta a la luna, ¿lo que importa es el dedo? 😄

seriamente,
veras que apruuebo todo lo que veo terminado,
pero dejo el mensaje para alentarlos a obviar el paso robótico nomás, no porque no haya cumplido mi parte de review.
Si fuera código sería mucho más estricto.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio
joaquinelio approved these changes Jul 13, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jul 13, 2020
@EzequielCaste
EzequielCaste merged commit 29b4499 into javascript-tutorial:master Jul 13, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EzequielCaste @javascript-translate-bot @joaquinelio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.