GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Sets and ranges [...] by cortizg · Pull Request #296 · javascript-tutorial/es.javascript.info

Conversation

cortizg commented Jul 11, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          traduccion 9-08-sr

9ef788e

typos

typo2

typo en código de ejemplo

typo3

javascript-translate-bot added the review needed label

Jul 11, 2020

javascript-translate-bot requested a review from a team

July 11, 2020 04:38

iliakan mentioned this pull request

Jul 11, 2020

Spanish Translation Progress #17

Open


          Traducción pendiente, revisado en repo RU

c37f3f5

cortizg commented

Jul 11, 2020

View reviewed changes

cortizg left a comment

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/1-find-range-1/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md


		```js run
		for(let i=0; i<'𝒳𝒴'.length; i++) {
		for(let i = 0; i < '𝒳𝒴'.length; i++) {

cortizg Jul 11, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en las buenas prácticas los operadores deben de estar separados por un espacio, y linter tambièn lo recuerda.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax Jul 13, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y aquí?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cortizg Jul 13, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya está listo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio requested changes

Jul 11, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 pequeños...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Jul 11, 2020

javascript-translate-bot commented Jul 11, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jul 11, 2020

cortizg and others added 4 commits

July 11, 2020 08:27


          Update 9-regular-expressions/08-regexp-character-sets-and-ranges/1-fi…

00478bf

…nd-range-1/solution.md


          Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…

a82a73a

…cle.md


          Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…

9eacf64

…cle.md

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…

8201cbb

…cle.md

Co-authored-by: joaquinelio <[email protected]>

cortizg commented Jul 11, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 11, 2020

javascript-translate-bot requested a review from a team

July 11, 2020 14:28

joaquinelio reviewed

Jul 12, 2020

View reviewed changes

Comment thread

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…

1f62050

…cle.md


esquiusmi...
aceptaste una bandera, pongo la otra
a desgano, pero para concordar.

joaquinelio approved these changes

Jul 12, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Jul 12, 2020


          Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…

930a0df

…cle.md

cortizg commented Jul 13, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the review needed label

Jul 13, 2020

javascript-translate-bot requested a review from a team

July 13, 2020 00:43

cortizg requested review from vplentinax and removed request for a team

July 13, 2020 00:43

vplentinax approved these changes

Jul 13, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok..!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 review needed labels

Jul 13, 2020

joaquinelio merged commit e192dda into javascript-tutorial:master

Jul 13, 2020

javascript-translate-bot commented Jul 13, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

cortizg commented Jul 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortizg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cortizg Jul 11, 2020

Choose a reason for hiding this comment

Uh oh!

vplentinax Jul 13, 2020

Choose a reason for hiding this comment

Uh oh!

cortizg Jul 13, 2020

Choose a reason for hiding this comment

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 11, 2020

Uh oh!

cortizg commented Jul 11, 2020

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

cortizg commented Jul 13, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 13, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cortizg commented Jul 11, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.