GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — BigInt by joaquinelio · Pull Request #305 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Jul 15, 2020

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          1-99-5 bigint 1ra version

560d2c7

javascript-translate-bot added the review needed label

Jul 15, 2020

javascript-translate-bot requested a review from a team

July 15, 2020 22:27

iliakan mentioned this pull request

Jul 15, 2020

Spanish Translation Progress #17

Open

maksumi approved these changes

Jul 16, 2020

View reviewed changes

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		El operador unario más `+value` es una manera bien conocida de convertir `value` a number.

		On bigints it's not supported, to avoid confusion:
		Con bigints eso no es soportado para evitar confusión:

maksumi Jul 16, 2020

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	Con bigints eso no es soportado para evitar confusión:
	Con bigints eso no es soportado. Para evitar confusión:

De acuerdo a mi lectura, y lo que voy entendiendo, ahí ocupaba el punto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio Jul 16, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope
CREO (nunca estoy seguro) que tiene sentido. Cierto que suele poner "como aqui:" y eso faltaria. pero
respondeme:
hubiera sido muy facil soportarlo,
¿Por qué no es soportado?

al poner +variable, se tranforma a number
pero si variable es bigint... +variable, ¿debería dejarla bigint? ¿deberia truncarlo?
ssi la deja bigint, seria ambiguo,
porque +variable resulta en bigint en ocasiones y en numbree n otras
es decir confusiones

Pero ALGO voy a cambiar

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio Jul 16, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JA!
that was fast
Ilya respondio... con

What you think, paroche ? =)

con @ que saqué para avoid la confusion de don paroche

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

maksumi Jul 16, 2020

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jajajaja... Ayer andaba desvelado, debió ser eso que no leí bien el artículo. Tenés razón, ese punto no va.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added needs +1 and removed review needed labels

Jul 16, 2020

joaquinelio and others added 10 commits

July 16, 2020 08:48


          Update 1-js/99-js-misc/05-bigint/article.md

Pffff 
Mandale un PR al repo inglés entonces, acá qué tengo que ver.
ja!
me pareció... y despues no lo crei muy importante, pereza.  Sigue siendo incómodo, con la correcta aclaración arbitraria está mas ociosa todavia...
Ahora commit porque aclara, pero despues busco algo mejor, y si encontramos algo perfecto: PR a Ilya.  
"arbitrario" porque los otro sson algo "limitados", pero no esta bien expresado.

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

0ead300

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

723e619

¿no escribi esto ya?
Peleo con el exceso de comas pero aca está bien la correccion.
Ahora veo mal el exceso de "por favor" que en ingles no distrae tanto.
"por favor nota" es horrible
"ten en cuenta" Por qué "por favor" too needy
despues lo saco, opina please.

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

c2907cc

...
no...
...no del todo.  Buena defectuosa correccion  (difierentes)
y sí falta una buena conexion
pero cambiare "aunque".
...
y cada vez más me molesta el "por favor" ¿que opinas?
Lo hace para que prestess más atencion, pero en español creo que distrae

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

30d4ad3

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

93c9914

¡PERFECTO! no me gustaba. 
Demasiados entonces.  "so" es tan práctico...

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

708ffc9

mm...
quizás facilite la lectura, pero:
Peleo contra el exceso de comas,
pero estas sesparan elementos
si forzas una, hay que agregar otra, el test es quitar el complemento entre comas y ver que la frase tenga sentido:
Los op bool, tales como balabalabla, también trabajan.
Los op bool también trabajan.
Aplico porque mejora pero despues edito   , ,

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

2380c91

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/99-js-misc/05-bigint/article.md

0516d8c

ah...
en hacerla, porque quizás deberiamos evitarla.
o
al hacerla, porque la hacemos igual pero debemos ser cuidadosos
Ok.

Co-authored-by: Maksumi Murakami <[email protected]>


          Update article.md

45e7b19

@ 
eh!
@ 
¿como loss menciono=? 
no anda

article 5 27 53 72 92

joaquinelio commented Jul 16, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

@maksumi
ah, acá sí anda @

p.f. lee los coment en los ssuggest

article 5 27 53 72 92

*5 iba a poner arbitrariamenta grandes. Mentira, tiene límite.
En realidad ES tamaño arbitrario,
porque puede ser "1" o "12345567789353452345235235"
number tiene tamaño fijo
aunque veamos 1.01 tiene ssiempre el mismo tamaño en bytes

*53) Lo puse al principio para desanimarte la correccion jaja explico duda en tu suggest
voy a comentar el repo ingles por la duda

*72) ok. faltaba conector
pero no es "aunque", es "como"
tentado a mover la coma "p f nota que," pero queda feo

*92) ok... mejorado. entre comas.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi commented Jul 16, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

A mí no me agrada pedir que "por favor" lo noten o tomen en cuenta si es algo que es importante saber. ¿Me explico? En inglés suena bien pero en español no creo que necesitemos esos "Please". No recuerdo bien pero creo que yo lo la he estado eliminando.
@joaquinelio con un "Nota" o "Toma en cuenta" es más que suficiente.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 16, 2020

Copy link

Copy Markdown

Member Author

A mí no me agrada pedir que "por favor" lo noten o tomen en cuenta si es algo que es importante saber. ¿Me explico? En inglés suena bien pero en español no creo que necesitemos esos "Please". No recuerdo bien pero creo que yo lo la he estado eliminando.
@joaquinelio con un "Nota" o "Toma en cuenta" es más que suficiente.

¡De acuerdo!
Pero una cosa.
ACÁ estoy DE ACUERDO porque SUENA distinto en ingles, "plis" es apenas muletilla, corto y no distrae
"plisnout" vs "por favor, ten en cuenta"
terrible

El traductor no debe reinterpretar el estilo. Hay cosas que pueden sonar infantiles, otras que falta más,
pero ESO es tarea del escritor, no del traductor. Es él quien balancea y sabe a quién dirige su texto.
Si algo parece arreglable, lo que hago es poner un PR en el repo inglés para que lo valore ahí.
Ilya es muy abierto (más que nos, maintainers ajajaa) y lo cambia o explica.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi approved these changes

Jul 16, 2020

View reviewed changes

maksumi commented Jul 16, 2020

Copy link

Copy Markdown

Collaborator

Ya quedó, ya no le muevas más...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 16, 2020

Copy link

Copy Markdown

Member Author

Ya quedó, ya no le muevas más...
¡ajajaj !!
no pensaba tocarlo, habiendo tant o por hacer...
pero entre´a juguetear con la idea de cambiarlos

listo me convenciste /done !!
@maksumi
y ¿ @vplentinax ? porque esta un poco lonely esto...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the review needed label

Jul 16, 2020

joaquinelio commented Jul 16, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jul 16, 2020

Copy link

Copy Markdown

Contributor

Tranquila ando, traduciendo...
Aprovechando que la cosa esta relax...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax self-assigned this

Jul 16, 2020

vplentinax approved these changes

Jul 16, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax removed review needed needs +1 labels

Jul 16, 2020

vplentinax added the ready to merge label

Jul 16, 2020

joaquinelio merged commit 0f2536d into javascript-tutorial:master

Jul 17, 2020

javascript-translate-bot commented Jul 17, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio deleted the bigint branch

August 1, 2020 00:07

Reviewers

maksumi

maksumi approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

vplentinax

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joaquinelio commented Jul 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maksumi Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

joaquinelio Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

joaquinelio Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

maksumi Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaquinelio commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maksumi commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Jul 16, 2020

Uh oh!

maksumi commented Jul 16, 2020

Uh oh!

joaquinelio commented Jul 16, 2020

Uh oh!

joaquinelio commented Jul 16, 2020

Uh oh!

vplentinax commented Jul 16, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 17, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joaquinelio commented Jul 16, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

maksumi commented Jul 16, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.