GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Arrays by joaquinelio · Pull Request #309 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Jul 19, 2020

Copy link

Copy Markdown

Member

Usé "corchetes" para "square brackets", como aprendí en el colegio ¿es lo usual?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Arrays

042d43f

javascript-translate-bot added the review needed label

Jul 19, 2020

javascript-translate-bot requested a review from a team

July 19, 2020 22:55

iliakan mentioned this pull request

Jul 19, 2020

Spanish Translation Progress #17

Open

vplentinax commented Jul 20, 2020

Copy link

Copy Markdown

Contributor

Si, corchetes!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi approved these changes

Jul 21, 2020

View reviewed changes

maksumi left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunos typos y algunas sugerencias conceptuales. Na'más...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/04-array/10-maximal-subarray/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/10-maximal-subarray/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/10-maximal-subarray/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/10-maximal-subarray/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/10-maximal-subarray/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added needs +1 and removed review needed labels

Jul 21, 2020

vplentinax commented Jul 21, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Algunos typos y algunas sugerencias conceptuales. Na'más...

@maksumi todo lo que puedas corregir o sugerir, incluido typos, añadelos o comenta la línea para comparar.

Edición:

Lo vi desde el cell y no me di cuenta que habías hecho las sugerencias! Sorry!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio and others added 21 commits

July 21, 2020 06:09


          Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md

5314f8f

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md

b3a0cc0

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md

af2e2a0

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/5-array-input-sum/task.md

a373976

Maldito teclado.  La s me está fallando.

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

baa16d7

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

71793c9

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

1a517fd

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

a73a204

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

e88e22a

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/5-array-input-sum/task.md

fef7302

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/2-create-array/task.md

93aedf5

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/3-call-array-this/solution.md

cc3750c

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/3-call-array-this/task.md

c2f4f67

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

05a0618

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/5-array-input-sum/solution.md

383249d

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

f122d1e

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

8fdb93a

ocioso...
pero me da igual

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

726df56

AAAAHHHHHHH!!!!

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

b3e4585

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

2f951b1

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

785ff52

Co-authored-by: Maksumi Murakami <[email protected]>

joaquinelio and others added 4 commits

July 21, 2020 08:59


          Update 1-js/05-data-types/04-array/article.md

fe7c1bf

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

214685f

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/05-data-types/04-array/article.md

db4e7fb

Co-authored-by: Maksumi Murakami <[email protected]>


          Update article.md

778666a

joaquinelio commented Jul 21, 2020

Copy link

Copy Markdown

Member Author

/done
pero no del todo, un par de suggest aun por resolver @maksumi @vplentinax

De acuerdo, longitud y largo es lo mismo pero longitud se lee más claro y cómodo.
si hubiera sabido que eran tantos habria editado con /reemplazar.
LISTO lo hice, encontre 2 más. irrelevantess, pero para concordar.

ingreasar por entrar, ok, se me escapo

¿Te molesta la voz pasiva?
La evito si está de más pero a veces ayuda en la secuencia de lo que se expresa.
Aca me daba igual.

Te desprecié dos o tres, alguno para debate.
habrás de leer...
1 5 4 10 solution 40, 66

1 5 4 article 124 136 190 editadas sin el suggest,
lo que muestra la conversación no es lo que quedó.

¿Deberia poner mayusc y punto final en los // ? nah. Pero me da nosequé.

monton de commits, debi usar modo batch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the review needed label

Jul 21, 2020

maksumi reviewed

Jul 21, 2020

View reviewed changes

Comment thread

1-js/05-data-types/04-array/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update 1-js/05-data-types/04-array/article.md

bcb2dc4

Co-authored-by: Maksumi Murakami <[email protected]>

joaquinelio commented Jul 22, 2020

Copy link

Copy Markdown

Member Author

@vplentinax ,pido tu opinión españolísima (aunque seas implantada)
1 5 4 10 solution, 2 ssuggest que desprecié.
Uno es la coma, no me importa quitarla pero creo que va.
Segundo, el uso de "actual" para ssignificar lo que esttá en curso en lugar del que creí más ajustado "corriente", ( y ya está explicando código, por eso me detengo a pensarlo)
pero noté que en otro lado también usaron "actual"... Casi preferiría "elemento presente".
¿te parece que lo cambie a "actual"?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jul 22, 2020

Copy link

Copy Markdown

Contributor

@vplentinax ,pido tu opinión españolísima (aunque seas implantada)
1 5 4 10 solution, 2 ssuggest que desprecié.
Uno es la coma, no me importa quitarla pero creo que va.
Segundo, el uso de "actual" para ssignificar lo que esttá en curso en lugar del que creí más ajustado "corriente", ( y ya está explicando código, por eso me detengo a pensarlo)
pero noté que en otro lado también usaron "actual"... Casi preferiría "elemento presente".
¿te parece que lo cambie a "actual"?

Hecho!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi approved these changes

Jul 22, 2020

View reviewed changes

maksumi left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya aprové... Lo dejo a tu criterio porque la traducción está muy bien y solo son sugerencias alternativas que a mi criterio creo que funcionarían también

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update 1-js/05-data-types/04-array/10-maximal-subarray/solution.md

6a6b3f8

NO creo que sea mejor "actual".  Pero busqué en el repo, y fue lo usado.  Sea por correcto o por convención, pensando en quien aprende, prefiero la homogeneidad.  Va ACTUAL.

Co-authored-by: Maksumi Murakami <[email protected]>

joaquinelio commented Jul 22, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi reviewed

Jul 22, 2020

View reviewed changes

maksumi left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, creo que solo nos falta la aprobación de @vplentinax y merge!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax approved these changes

Jul 22, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 review needed labels

Jul 22, 2020

joaquinelio merged commit ef97645 into javascript-tutorial:master

Jul 22, 2020

javascript-translate-bot commented Jul 22, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio deleted the arr branch

July 22, 2020 21:37

Reviewers

maksumi

maksumi approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joaquinelio commented Jul 19, 2020

Uh oh!

vplentinax commented Jul 20, 2020

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vplentinax commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Jul 21, 2020

Uh oh!

Uh oh!

joaquinelio commented Jul 22, 2020

Uh oh!

vplentinax commented Jul 22, 2020

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

joaquinelio commented Jul 22, 2020

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 22, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vplentinax commented Jul 21, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.