GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Searching: getElement*, querySelector* by elemarmar · Pull Request #311 · javascript-tutorial/es.javascript.info

Conversation

@elemarmar

@elemarmar elemarmar commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

¡Hola! Es mi primera contribución así que quizá haya "patinado un poco". Cualquier feedback es bien recibido y ¡espero aprender mucho para poder seguir contribuyendo!
Un saludo desde España 🦊

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi reacted with heart emoji
All reactions
  • ❤️ 1 reaction
elemarmar added 12 commits July 18, 2020 13:39
@elemarmar
Update article.md
ce7cadc
@elemarmar
Update article.md
62f1599
@elemarmar
Update article.md
ddc5556
@elemarmar
Update solution.md
0781af4
@elemarmar
Update task.md
81db12d
@elemarmar
Update solution.md
ba2e0a6
@elemarmar
Update table.html
2a86f2f
@elemarmar
Update article.md
c236fc5
@elemarmar
Update article.md
29d49ac
@elemarmar
Update solution.md
8aeac8a
@elemarmar
Update table.html
c549aae
@elemarmar
Update article.md
c61abd1
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 20, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 20, 2020 06:00
@CLAassistant

CLAassistant commented Jul 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan iliakan mentioned this pull request Jul 20, 2020
Spanish Translation Progress #17
Open
joaquinelio
joaquinelio requested changes Jul 20, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buena adición.
Todos patinamos, y mucho. Por eso la doble revisión. Que también pueden equivocarse.

Al segundo reviewer, el título es ok pero el bot no lo reconoció, (se habrá confundido con los *)
el merge habrá que agregarlo al issue a mano.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

elemarmar reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread 2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/04-searching-elements-dom/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/04-searching-elements-dom/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/04-searching-elements-dom/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/04-searching-elements-dom/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/04-searching-elements-dom/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Jul 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Jul 20, 2020
elemarmar and others added 4 commits July 20, 2020 14:30
@elemarmar @joaquinelio
Update 2-ui/1-document/04-searching-elements-dom/1-find-elements/solu…
f22b840
…tion.md

Co-authored-by: joaquinelio <[email protected]>
@elemarmar @joaquinelio
Update 2-ui/1-document/04-searching-elements-dom/article.md
1f3fb3a
Co-authored-by: joaquinelio <[email protected]>
@elemarmar @joaquinelio
Update 2-ui/1-document/04-searching-elements-dom/article.md
e9b1d5e
Co-authored-by: joaquinelio <[email protected]>
@elemarmar @joaquinelio
Update 2-ui/1-document/04-searching-elements-dom/article.md
8c570c5
Co-authored-by: joaquinelio <[email protected]>
@elemarmar

elemarmar commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

¡Muchas gracias por la revisión! He visto que algunos errores eran muy tontos de no haber yo revisado bien. Lo haré mejor la próxima vez para ahorraros el trabajo. ¡Trabajazo el vuestro! 👏🏻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@elemarmar @joaquinelio
Update 2-ui/1-document/04-searching-elements-dom/article.md
5edbfd0
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio

joaquinelio commented Jul 20, 2020

Copy link
Copy Markdown
Member

¡Muchas gracias por la revisión! He visto que algunos errores eran muy tontos de no haber yo revisado bien. Lo haré mejor la próxima vez para ahorraros el trabajo. ¡Trabajazo el vuestro! 👏🏻

Por eso el mensaje primero. Siempre se escapa algo, el cerebro nos trampea y lee lo que cree que dice.

"Lo haré mejor la próxima" a mí no me sirvió, nuestro tramposo cerebro es más inteligente y perezoso que nosotros.
Mi consejo es dejarlo reposar y releerlo al otro día, consejo que tampoco sigo.

elemarmar reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vplentinax

vplentinax commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

@joaquinelio Aprobamos? A mi me gusta!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax reviewed Jul 21, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquinelio, @elemarmar, como opinión personal, no veo la necesidad de aclarar el término "hover". Dentro del mundo del desarrollo creo que ya muchos lo tenemos asumido como el evento del mouse sobre un elemento. Pero, como ustedes crean, me parecerá bien, quizás sea neceario para los que desconocen HTML o CSS.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@joaquinelio

joaquinelio commented Jul 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vplentinax @elemarmar,

"Dentro del mundo del desarrollo creo que ya muchos lo tenemos asumido"
"quizás sea neceario para los que desconocen HTML o CSS."

Apunto a ese que desconoce HTM, CSS... y JS. ¡Es justamente la puerta de entrada!
Es una discusión que debimos tener supongo, a quién le hablamos cuando hablamos JS español.

I have a dream.

Apunto a ese pibe curioso, inquieto, que le gusta el desafío y que todo lo nuevo lo aprenda en este sitio, que sea capaz de entenderlo y aprenderlo aunque le sea arduo o porque es un desafío.

Me gusta poner el ejemplo del monje medieval que aprende a leer de adulto, y en voz alta para entender lo que sale de sus labios. De cómo se reiría ante la idea de un niño de 4 años leyendo mejor que él.
No apunto al de 4 pero sí al joven mucho antes de que pueda pensar en una carrera universitaria.

Y sin infantilizar, claro. Mantener el esstilo Ilya. Un traductor no debe reinterpretar estilo.

Jaja qué volado. No va a cambiar porque aclaren o no hover, como quieran. Me gustó escribirlo anque.

elemarmar reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Jul 21, 2020

Copy link
Copy Markdown
Member

@joaquinelio Aprobamos? A mi me gusta!

Sí, anda bien, es fuido. Solo no me gusta ese "flota o sobrevuela" jajajaja quien lo habrá sugerido...
Peleénme, a veces divago pero al rato los coágulos decantan y respondo.

Pero ALGO pondría en la primera referencia de Hover = ...

Pero sí, pa'l merge.
incluso si no cambia esas cositas que no hacen al JS.

¿asi que viviste en Epaña? Entonces no te parecio raro el "por diferencia".
"por varios cuerpos" diria mi tio apostador.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vplentinax

vplentinax commented Jul 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@joaquinelio

¿asi que viviste en Epaña? Entonces no te parecio raro el "por diferencia".
"por varios cuerpos" diria mi tio apostador.

Ajam, no me pareció raro, rara me pareció tu sugerencia "y mucho" jajajjaja...

Por cierto, @joaquinelio aprueba para que aparezca tu check!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax approved these changes Jul 21, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arreglamos esto, y listo!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 2-ui/1-document/04-searching-elements-dom/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Jul 21, 2020
joaquinelio
joaquinelio approved these changes Jul 21, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pero qué :jovér.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
elemarmar and others added 2 commits July 21, 2020 07:51
@elemarmar @joaquinelio
Update 2-ui/1-document/04-searching-elements-dom/article.md
269b5fa
Co-authored-by: joaquinelio <[email protected]>
@elemarmar @vplentinax
Update 2-ui/1-document/04-searching-elements-dom/article.md
ee7670b
Co-authored-by: Valentina VP <[email protected]>
@elemarmar

elemarmar commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

Me lo pasé genial leyendo su conversación, haha. Creo que ahora es cuando le pongo lo del done. A ver qué taal....

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@elemarmar

elemarmar commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

/done

vplentinax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the review needed label Jul 21, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 21, 2020 06:15
@vplentinax vplentinax added ready to merge and removed needs +1 review needed labels Jul 21, 2020
@joaquinelio
joaquinelio merged commit 35d7d53 into javascript-tutorial:master Jul 21, 2020
@elemarmar
elemarmar deleted the search-elements-dom-emm branch July 21, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maksumi maksumi maksumi left review comments
@vplentinax vplentinax vplentinax approved these changes
@joaquinelio joaquinelio joaquinelio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@elemarmar @CLAassistant @javascript-translate-bot @joaquinelio @vplentinax @maksumi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.