GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — The old "var" by joaquinelio · Pull Request #312 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Jul 22, 2020

Copy link

Copy Markdown

Member

Basado en el repo EN,
varios cambios respecto al nuestro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          The old "var"

0e5b7e4

javascript-translate-bot added the review needed label

Jul 22, 2020

javascript-translate-bot requested a review from a team

July 22, 2020 04:58

iliakan mentioned this pull request

Jul 22, 2020

Spanish Translation Progress #17

Open

joaquinelio added 4 commits

July 22, 2020 02:14


          esencia ortograf

c5533f6


          sep palabras

c346db9


          ortogr 3

5419f98


          ortogr 4

91a7304

vplentinax requested changes

Jul 25, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo encontre algo confuso. También hay líneas que no coinciden. Me gustaria que arreglaras eso y así volver a revisarlo. También agregué algunas sugerencias de cambios que ví por encima.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 25, 2020

javascript-translate-bot commented Jul 25, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Basado en el repo EN,
varios cambios respecto al nuestro.

No había visto los cambios, tenía previsto hacer la revisión de sincronización el domingo, pero ya añadí lo nuevo ahora confiando que se arreglarían los problemas de las líneas que no coincidían, pero veo que no sucedió, se creó un pequeño conflicto.

Editado:
veo mejor que cierres y vuelvas a abrir el PR a ver si coincide con los nuevos cambios y se hace más fácil la revisión.
¿Tú que dices?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio and others added 13 commits

July 24, 2020 23:31


          Update 1-js/06-advanced-functions/04-var/article.md

b7ad468

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

d87f753

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

ef691eb

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

924e9cb

Tuve que penarlo un poco...
No está nada mal "alcance"

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

dee39a7

De acuerdo, no me gusto cdo lo escribi.  No es lo que dice el original sino mejor.
Tamb voy a cambiar "mayoria" suena ffeo

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

d758e11

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

3a9f23b

mas animal que bestia, "soy animal de ciudad"..
me da igual, hecho.

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

e02c4f6

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

46bd6d0

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

a29e338

Co-authored-by: Valentina VP <[email protected]>


          article mejorado

84cbbe2


          Merge branch 'master' into oldvar

b0fa6c0


          Update 1-js/06-advanced-functions/04-var/article.md

f1ec4e8

Co-authored-by: Valentina VP <[email protected]>

joaquinelio commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

@vplentinax
ah, primero hice loas sug
desp resolve
desp resolvi confl y quedo... no se, una vez q se mete el P..O >>>===<<< es imposible confiar en las lineas
desp vi tu ssug de cerrarlo.. no need, conflicto siimple
EDIT:
Al resolver conflicto, el diff se actualizó solo, asi que la revision sera la correcta.
Algunos sug aplicados, otros loss reescribí
*me suena comodo viejo nuevo
apliqué sug porque supongo que muchos le da igual
y algunos como vos les choque, so, mejor.
*Otros hacen a la fluidez de lectura, muy buenas sugerencias ok
*reformulé lin 31, me aparté del literal espero sea más claro...
*ah, acá usamos saltear (8)... JA JA!! RAE saltear (me gusta 2)
1.Sofreír
2.Salir a los caminos y robar a los pasajeros.
...
8 .Omitir ¿8? ¡BBBUUUUU! (¿puedo mandar pr a la rae? Ilya rechazo dos mios asi q baja autoestima)
Pero tambien entendemos saltar, asi que ok.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 2 commits

July 25, 2020 01:34


          update line108- better I hope

051f388


          108 v3

a87a5dd

joaquinelio commented Jul 25, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 25, 2020

maksumi commented Jul 25, 2020

Copy link

Copy Markdown

Collaborator

Aguanten, ya va mi review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax approved these changes

Jul 25, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, se solucionó el problema de líneas. Se lee más fluido. Correcto!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Jul 25, 2020

maksumi approved these changes

Jul 25, 2020

View reviewed changes

maksumi left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy buena traducción, algunos typos aún y esos mosquitos "el" en la línea 4 y 5 donde viviriamos más tranquilos si no estuvieran sin importar si fuera "código viejo" ó "'' antiguo"...
Arregla eso y te doy 5 estrellas....
Perdón, perdón. Solo esos detalles y... ¡Ya todo chido pa'l merge!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/04-var/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio and others added 9 commits

July 25, 2020 03:20


          Update 1-js/06-advanced-functions/04-var/article.md

169cc2b

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

a32ebdd

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

aa2bd34

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

ce56e75

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

4afadec

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

a55388e

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

b4d86cc

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/06-advanced-functions/04-var/article.md

Co-authored-by: Maksumi Murakami <[email protected]>

joaquinelio commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

@maksumi
FAAAA.., que buena vista, acepte todas lass ssugg

pero
"mosquitos" creo que es mejor "el codigo", pero las acepte porque queria las 5 estrellas
jejej

enteder el codigo
entender codigo
entiendo que te parecio incomodo, depende de cuan especifico sea

"entender sánscrito"
"entender el código que hice ayer"
nuestro caso es bien ambiguo asi que creo qye van las dos formas ok

ah, preaceptado? merde!!! digo MERGE!!!!!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio merged commit d7bc432 into javascript-tutorial:master

Jul 25, 2020

javascript-translate-bot commented Jul 25, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio deleted the oldvar branch

July 25, 2020 06:33

Reviewers

maksumi

maksumi approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joaquinelio commented Jul 22, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 25, 2020

Uh oh!

vplentinax commented Jul 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Jul 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Jul 25, 2020

Uh oh!

maksumi commented Jul 25, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

maksumi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaquinelio commented Jul 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 25, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vplentinax commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

maksumi left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.