GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Promise API by joaquinelio · Pull Request #313 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Jul 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

branch "papi"

edito:
@vplentinax , gracias por el buen humor
parece que tengo que borrar el coment porque incomoda a potenciales revisores...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and maksumi reacted with laugh emoji

All reactions

😄 2 reactions


          Promise API

2527cc9

javascript-translate-bot added the review needed label

Jul 22, 2020

javascript-translate-bot requested a review from a team

July 22, 2020 15:14

iliakan mentioned this pull request

Jul 22, 2020

Spanish Translation Progress #17

Open

joaquinelio added 2 commits

July 22, 2020 12:27


          fix .race

e998eda

primera que responda ok/err, no necesita que resuelva ok


          Update article.md

e223eaf

vplentinax self-requested a review

August 3, 2020 02:30

vplentinax requested changes

Aug 5, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas. Se cambian y nos fuimos!.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/11-async/05-promise-api/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/05-promise-api/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/05-promise-api/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Aug 5, 2020

javascript-translate-bot commented Aug 5, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio and others added 3 commits

August 4, 2020 22:55


          Update 1-js/11-async/05-promise-api/article.md

6c720ef

Confundí resolve con fulfilled (solo successful) crei que puso "settled" para indicar ambos.  My bad.

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

d0e5b3b

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

cb8b653

Co-authored-by: Valentina VP <[email protected]>

joaquinelio commented Aug 5, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 5, 2020

vplentinax approved these changes

Aug 5, 2020

View reviewed changes

vplentinax left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo apruebo esta traducción!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Aug 5, 2020

vplentinax requested a review from EzequielCaste

August 5, 2020 19:29

maksumi approved these changes

Aug 6, 2020

View reviewed changes

maksumi left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay como dos o tres typos. Excelente traducción, solo unas pequeñas sugerencias nada serias y una pequeña llamada de atención al "exceso de comas". Merge it!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

joaquinelio and others added 8 commits

August 6, 2020 08:13


          Update 1-js/11-async/05-promise-api/article.md

dcdbb9a

De acuerdo, se lee mucho mejor "Veremos"

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

36ef3db

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

99d842e

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

5974d39

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

ace75fe

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

8e7e076

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

40ea7fd

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

b1f5696

Co-authored-by: Maksumi Murakami <[email protected]>

joaquinelio and others added 3 commits

August 6, 2020 08:24


          Update 1-js/11-async/05-promise-api/article.md

c899ba3

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/11-async/05-promise-api/article.md

5956b2c

Co-authored-by: Maksumi Murakami <[email protected]>

joaquinelio merged commit 74278ee into javascript-tutorial:master

Aug 6, 2020

javascript-translate-bot commented Aug 6, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio deleted the papi branch

August 21, 2020 18:52

Reviewers

maksumi

maksumi approved these changes

vplentinax

vplentinax approved these changes

EzequielCaste

Awaiting requested review from EzequielCaste

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joaquinelio commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 5, 2020

Uh oh!

joaquinelio commented Aug 5, 2020

Uh oh!

vplentinax left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 6, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joaquinelio commented Jul 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

vplentinax left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.