GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Array methods by nahuelcoder · Pull Request #316 · javascript-tutorial/es.javascript.info

Conversation

nahuelcoder commented Jul 22, 2020

Copy link

Copy Markdown

Contributor

Traducción a español

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nahuelcoder added 12 commits

July 15, 2020 18:43


          Update article.md

ea23430

Inicio de la traducción


          Update article.md

1a5fbd5


          Updated article.md

77e3e5b


          Updated article


          Updated article

71a37c7


          Updated article

1c33c51


          Updated traslation

1836c4a


          Updated traslation

f49120e


          Updated traslation

11e85cf


          Updated article

e983eb0


          Updated traslation

6154afd


          Merge pull request #2 from nahuelcoder/nahuelcoder-patch-1-Array-methods

a866495

Nahuelcoder patch 1 array methods

javascript-translate-bot added the review needed label

Jul 22, 2020

javascript-translate-bot requested a review from a team

July 22, 2020 22:55

iliakan mentioned this pull request

Jul 22, 2020

Spanish Translation Progress #17

Open

CLAassistant commented Jul 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio self-requested a review

July 23, 2020 00:46

joaquinelio commented Jul 23, 2020

Copy link

Copy Markdown

Member

BIENVENIDO @nahuelcoder

disculpa, me anoté pero se me están cruzando los ojos, lo veo mañana...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Jul 23, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uf, no terminaba nunca, muchos archivos

Si es tu primera review quizas te sientas tocado por la cantidad de typos
es que uno tiene que aprender que el cerebro nos trampea
y lee lo que quiere leer o lo que cree que dice o lo que produzca menos trabajo.

Sí, nuestro cerebro es más inteligente y perezoso que nosotros.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 23, 2020

javascript-translate-bot commented Jul 23, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nahuelcoder and others added 8 commits

July 23, 2020 16:15


          Update task.md

4610c80


          Update solution.js

415c6d3


          Update task.md

d4f3cf3


          Update 1-js/05-data-types/05-array-methods/11-array-unique/solution.md

9d676cd

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/12-reduce-object/task.md

42a081e

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/12-reduce-object/task.md

aeca5bf

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/3-filter-range-in-place/ta…

2c7509d

…sk.md

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/6-calculator-extendable/so…

6534a30

…lution.md

Co-authored-by: joaquinelio <[email protected]>

nahuelcoder and others added 15 commits

July 23, 2020 16:26


          Update 1-js/05-data-types/05-array-methods/9-shuffle/solution.md

bd70974

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

ea5b99c

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

a294675

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

28b7b22

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

d047c86

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

0667f15

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

3efcd54

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

5b9c37c

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

bfa2c55

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

e62eee8

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

458f3f6

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

5f8f106

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

beba4b1

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/05-array-methods/article.md

b8e291c

Co-authored-by: joaquinelio <[email protected]>

nahuelcoder commented Jul 23, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 23, 2020

joaquinelio approved these changes

Jul 24, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES una traducción hermosa, y una de las arduas. 25 archivos.

Puse un suggest a un typo que ses me pasó en la 1ra, quien ms siga que haga clic, no voy a reiniciar ciclo por eso.
Tamb hice trampa, encontré un par ("dos") de tildes y sasbiendo q eran 25 archivos y art de 600 lineas segui de largo, sorry. APROBADO.

Bueno y claro. Buena adición. Come on, reviewers...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/05-array-methods/11-array-unique/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added needs +1 and removed review needed labels

Jul 24, 2020


          Update 1-js/05-data-types/05-array-methods/11-array-unique/solution.md

b070c86

Co-authored-by: joaquinelio <[email protected]>

vplentinax approved these changes

Jul 24, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Jul 24, 2020

nahuelcoder commented Jul 24, 2020

Copy link

Copy Markdown

Contributor Author

Muchas gracias por los comentarios y la ayuda con todo lo relacionado a Github, estoy aprendiendo muchísimo!

joaquinelio reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 25, 2020

Copy link

Copy Markdown

Member

Muchas gracias por los comentarios y la ayuda con todo lo relacionado a Github, estoy aprendiendo muchísimo!

Gracias!
La traducción es buena para llevar JS a quienes no saben AÚN (pero deberían) inglés,
pero muchos, como yo, aprendimos GIT aquí...
Acá vi que es importante saberlo
y supongo buen item para el curriculum entender git, estoy tentado a ampliar la explicación al caso de trabajo local.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Yes @vplentinax

uh, que rápido
no estaras confiando demasiado en mis revisiones, ¿no?
no, no creo. Sabés que a veces patino,

"y mucho".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio merged commit 830ce77 into javascript-tutorial:master

Jul 25, 2020

javascript-translate-bot commented Jul 25, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

nahuelcoder commented Jul 22, 2020

Uh oh!

CLAassistant commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Jul 23, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 23, 2020

Uh oh!

nahuelcoder commented Jul 23, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

nahuelcoder commented Jul 24, 2020

Uh oh!

joaquinelio commented Jul 25, 2020

Uh oh!

joaquinelio commented Jul 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 25, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Jul 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Jul 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.