GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Async/await by joaquinelio · Pull Request #317 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Jul 23, 2020

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Async/await

2204f5e

javascript-translate-bot added the review needed label

Jul 23, 2020

javascript-translate-bot requested a review from a team

July 23, 2020 02:06

iliakan mentioned this pull request

Jul 23, 2020

Spanish Translation Progress #17

Open

dbritto-dev suggested changes

Jul 30, 2020

View reviewed changes

Comment thread

1-js/11-async/08-async-await/01-rewrite-async/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/08-async-await/01-rewrite-async/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/08-async-await/01-rewrite-async/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/08-async-await/03-async-from-regular/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/08-async-await/03-async-from-regular/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/08-async-await/02-rewrite-async-2/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 30, 2020

javascript-translate-bot commented Jul 30, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio and others added 6 commits

July 30, 2020 09:39


          Update 1-js/11-async/08-async-await/01-rewrite-async/solution.md

f0e33f3

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/11-async/08-async-await/01-rewrite-async/task.md

36ade9e

me da igual...

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/11-async/08-async-await/01-rewrite-async/task.md

0d4ae3d

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/11-async/08-async-await/03-async-from-regular/task.md

2d7709d

ok, latin suena mejor que mal español

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/11-async/08-async-await/03-async-from-regular/task.md

e8f5a9e

¿por? se entiende, pero...

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md

8d85031

Co-authored-by: Danilo Britto <[email protected]>

joaquinelio commented Jul 30, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 30, 2020


          Update task.md

46acfaa

s de mas linea 4
maldito teclado

javascript-translate-bot removed the review needed label

Jul 30, 2020

maksumi approved these changes

Jul 30, 2020

View reviewed changes

javascript-translate-bot added the needs +1 label

Jul 30, 2020

maksumi approved these changes

Jul 30, 2020

View reviewed changes

maksumi left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Vientos!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax previously approved these changes

Jul 30, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuímonos! (pronombre enclítico)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Jul 30, 2020

vplentinax commented Jul 30, 2020

Copy link

Copy Markdown

Contributor

Bueno, realmente debí esperar que @danilobrinu aprobara los cambios. Retiro mi "fuímonos"!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax dismissed their stale review

July 30, 2020 22:42

Other reviewer is here!

vplentinax added needs +1 and removed ready to merge labels

Jul 30, 2020

dbritto-dev commented Jul 30, 2020

Copy link

Copy Markdown

Contributor

@vplentinax jajaja aca estoy :p

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jul 31, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev commented Jul 31, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jul 31, 2020

Copy link

Copy Markdown

Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

Ve a "Files Changed"
Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev approved these changes

Jul 31, 2020

View reviewed changes

dbritto-dev commented Jul 31, 2020

Copy link

Copy Markdown

Contributor

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

Ve a "Files Changed"

Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino

Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

@vplentinax listo 👍

vplentinax and maksumi reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax added ready to merge and removed needs +1 labels

Jul 31, 2020

vplentinax merged commit c4cce12 into javascript-tutorial:master

Jul 31, 2020

javascript-translate-bot commented Jul 31, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio deleted the asyawa branch

August 1, 2020 00:09

Reviewers

maksumi

maksumi approved these changes

vplentinax

vplentinax left review comments

+1 more reviewer

dbritto-dev

dbritto-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joaquinelio commented Jul 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 30, 2020

Uh oh!

joaquinelio commented Jul 30, 2020

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax commented Jul 30, 2020

Uh oh!

dbritto-dev commented Jul 30, 2020

Uh oh!

vplentinax commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbritto-dev commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vplentinax commented Jul 31, 2020

Uh oh!

dbritto-dev commented Jul 31, 2020

Uh oh!

javascript-translate-bot commented Jul 31, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vplentinax commented Jul 31, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev commented Jul 31, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.