GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Objects by maksumi · Pull Request #321 · javascript-tutorial/es.javascript.info

Conversation

@maksumi

@maksumi maksumi commented Jul 25, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Maksumi Murakami added 10 commits July 17, 2020 02:11
Maksumi Murakami
Merge pull request #1 from javascript-tutorial/master
0189e27 
Actualizado
Maksumi Murakami
Merge pull request #2 from javascript-tutorial/master
e96e72c 
Update
Maksumi Murakami
Update
96d99aa
Maksumi Murakami
Update
f152057
Maksumi Murakami
Update
42f7cc6
Maksumi Murakami
Update
a17a435
Maksumi Murakami
Update
f17b890
Maksumi Murakami
Update
0db6fe7
Maksumi Murakami
Update
c3aee22
Maksumi Murakami
Update
22a88dc
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 25, 2020
@maksumi maksumi changed the title Objects Object Jul 25, 2020
@maksumi maksumi changed the title Object Objects Jul 25, 2020
danielgrj
danielgrj suggested changes Jul 25, 2020
View reviewed changes
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/3-is-empty/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/5-sum-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
¿Los objetos son ordenados? Es decir, si creamos un bucle sobre un objeto, ¿obtenemos todas las propiedades en el mismo orden en el que se agregaron? ¿Podemos confiar en ello?

The short answer is: "ordered in a special fashion": integer properties are sorted, others appear in creation order. The details follow.
La respuesta corta es: "ordenados de una forma especial": las propiedades de enteros se ordenan, los demás aparecen en el orden de la creación. Entremos en detalle.

@danielgrj danielgrj Jul 25, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece que enteros necesita números para ser más claro. O conservar integer

Suggested change
La respuesta corta es: "ordenados de una forma especial": las propiedades de enteros se ordenan, los demás aparecen en el orden de la creación. Entremos en detalle.
La respuesta corta es: "ordenados de una forma especial": las propiedades de números enteros se ordenan, los demás aparecen en el orden de la creación. Entremos en detalle.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
Comment on lines +448 to +449
````smart header="¿Propiedades de enteros? ¿Qué es eso?"
El término "propiedad de enteros" aquí significa que una cadena se puede convertir a y desde desde un entero sin nigún cambio.

@danielgrj danielgrj Jul 25, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
````smart header="¿Propiedades de enteros? ¿Qué es eso?"
El término "propiedad de enteros" aquí significa que una cadena se puede convertir a y desde desde un entero sin nigún cambio.
````smart header="¿Propiedades de números enteros? ¿Qué es eso?"
El término "propiedad de enteros" aquí significa que una cadena se puede convertir a y desde desde un número entero sin nigún cambio.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
alert( String(Math.trunc(Number("49"))) ); // "49", same, integer property
alert( String(Math.trunc(Number("+49"))) ); // "49", not same "+49" ⇒ not integer property
alert( String(Math.trunc(Number("1.2"))) ); // "1", not same "1.2" ⇒ not integer property
// Math.trunc es una función incorporada que elimina la parte decimal

@danielgrj danielgrj Jul 25, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built-in se refiere a las funciones que vienen por defecto dentro de JavaScript

Suggested change
// Math.trunc es una función incorporada que elimina la parte decimal
// Math.trunc es una función nativa que elimina la parte decimal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
- To iterate over an object: `for (let key in obj)` loop.
Operadores adicionales:
- Para eliminar una propiedad: `delete obj.prop`.
-Para comprobar si existe una propiedad con la clave proporcionada: `"key" in obj`.

@danielgrj danielgrj Jul 25, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-Para comprobar si existe una propiedad con la clave proporcionada: `"key" in obj`.
- Para comprobar si existe una propiedad con la clave proporcionada: `"key" in obj`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 25, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 25, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joaquinelio
joaquinelio requested changes Jul 25, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hola, coso!
jjjajajaj

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/3-is-empty/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Outdated

let key = "age";
alert( *!*key*/!* in user ); // true, property "age" exists
alert( *!*key*/!* in user ); // true, porque su propiedad "age" si existe dentro del objeto

@joaquinelio joaquinelio Jul 25, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( *!*key*/!* in user ); // true, porque su propiedad "age" si existe dentro del objeto
alert( *!*key*/!* in user ); // true, porque su propiedad "age" sí existe dentro del objeto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
En el código anterior, la propiedad `obj.test` técnicamente existe. Entonces el operador `in` funciona correctamente.

Situations like this happen very rarely, because `undefined` should not be explicitly assigned. We mostly use `null` for "unknown" or "empty" values. So the `in` operator is an exotic guest in the code.
Situaciones como esta suceden raramente ya que `undefined` no debe ser explícitamente asignado. Comunmente usamos `null` para valores "desconocidos" o "vacios". Por lo que el operdaor `in` es un invitado exótico en nuestro código.

@joaquinelio joaquinelio Jul 25, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Situaciones como esta suceden raramente ya que `undefined` no debe ser explícitamente asignado. Comunmente usamos `null` para valores "desconocidos" o "vacios". Por lo que el operdaor `in` es un invitado exótico en nuestro código.
Situaciones como esta suceden raramente ya que `undefined` no debe ser explícitamente asignado. Comúnmente usamos `null` para valores "desconocidos" o "vacíos". Por lo que el operador `in` es un invitado exótico en nuestro código.

Me suena horrible, pero la norma dice que el acento se arrastra y se transforma en esdrújula
me preguntaste por fundeu...
www.fundeu.es/consulta/comun-comunmente-2784/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
```js
for (key in object) {
// executes the body for each key among object properties
// se ejecuta e cuerpo para cada clave entre las propiedades del objeto

@joaquinelio joaquinelio Jul 25, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// se ejecuta e cuerpo para cada clave entre las propiedades del objeto
// se ejecuta el cuerpo para cada clave entre las propiedades del objeto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
Nota que todas las construcciones "for" nos permiten declarar variables para bucle dentro del bucle, como `let key` aquí.

Also, we could use another variable name here instead of `key`. For instance, `"for (let prop in obj)"` is also widely used.
Además podriamos usar otros nombres de variables en lugar de `key`. Por ejemplo, `"for (let prop in obj)"` también se usa bastante.

@joaquinelio joaquinelio Jul 25, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Además podriamos usar otros nombres de variables en lugar de `key`. Por ejemplo, `"for (let prop in obj)"` también se usa bastante.
Además podríamos usar otros nombres de variables en lugar de `key`. Por ejemplo, `"for (let prop in obj)"` también se usa bastante.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot

javascript-translate-bot commented Jul 25, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Maksumi Murakami and others added 11 commits July 25, 2020 01:15
Maksumi Murakami @danielgrj
Update 1-js/04-object-basics/01-object/2-hello-object/task.md
5228b7e 
Co-authored-by: Daniel Garcia <[email protected]>
Maksumi Murakami
Update task.md
41da662
Maksumi Murakami
Update task.md
84181ea
Maksumi Murakami
Update solution.md
6fa85e8
Maksumi Murakami @danielgrj
Update 1-js/04-object-basics/01-object/8-multiply-numeric/_js.view/so…
d5be7a6 
…urce.js

Co-authored-by: Daniel Garcia <[email protected]>
Maksumi Murakami
Update article.md
a896cac
Maksumi Murakami
Update article.md
c69573f
Maksumi Murakami
Update article.md
2337f50
Maksumi Murakami @danielgrj
Update 1-js/04-object-basics/01-object/article.md
98ed40e 
Co-authored-by: Daniel Garcia <[email protected]>
Maksumi Murakami @danielgrj
Update 1-js/04-object-basics/01-object/article.md
127a18f 
Co-authored-by: Daniel Garcia <[email protected]>
Maksumi Murakami @danielgrj
Update 1-js/04-object-basics/01-object/article.md
216253d 
Co-authored-by: Daniel Garcia <[email protected]>
maksumi
maksumi commented Jul 26, 2020
View reviewed changes
Comment thread 1-js/04-object-basics/01-object/3-is-empty/solution.md Outdated
@@ -1 +1 @@
Just loop over the object and `return false` immediately if there's at least one property.
Solo cre un bucle sobre el objeto y un `return false` inmediatamente si hay al menos una propiedad.

@maksumi maksumi Jul 25, 2020

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Solo cre un bucle sobre el objeto y un `return false` inmediatamente si hay al menos una propiedad.
Solo crea un bucle sobre el objeto y, si hay al menos una propiedad, devuelve `false` inmediatamente.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/5-sum-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md
Podemos agregar, eliminar y leer archivos de ahí en cualquier momento.

Property values are accessible using the dot notation:
Se puede acceder a los valores de las propiedades utilizando la notación de punto:

@maksumi maksumi Jul 25, 2020

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aquí no lo tomo como absoluto amigo. "Por" y "de" no hacen diferencia conceptual. Al traductor del artículo en MDN le pareció bien usar "por" y solo eso, vaya, en ambos casos se entiende claro

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
![user object 3](object-user-delete.svg)

We can also use multiword property names, but then they must be quoted:
También podemos nombrar propiedades con más de una plabra (*multiword*). Pero, de ser así, debemos citarlos `"..."`:

@maksumi maksumi Jul 25, 2020

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Sí! Pensé lo mismo peero mientras hago labor de traducción a veces se me funde el cerebro y se me acaban las ideas. @danielgrj

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Outdated
El `const` podría dar error solo si intentamos configurar `user=...` en lo absoluto.

There's another way to make constant object properties, we'll cover it later in the chapter <info:property-descriptors>.
Hay otra manera de crear propiedades de objeto constantes, las cubriremos después en el capítulo <info:property-descriptors>.

@maksumi maksumi Jul 26, 2020

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tampoco quise dar a entender "objetos constantes" Es clara la confusión gramatical. Gracias por la correción

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maksumi

maksumi commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 26, 2020
@maksumi

maksumi commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator Author

Aló... @joaquinelio @danielgrj
Mil gracias por las sugerencias, sin duda quedó mucho mejor. Tome algunas de forma directa y me di la libertad de modificar algunas otras para una compresión todavía más clara al usuario. Sin duda este ha sido uno de los artículos más arduos que he tomado y con una dificultad un poco más elevada en cuanto a traducción pero me alegra el resultado y haber contado con su ayuda. Otras pequeñas sugerencias la verdad ni les hice caso. En cuanto a las traducciones de MDN, no son la mejor referencia para mí @danielgrj ya que hasta los traductores de MDN a veces no son tan claros. En fin. Excelente fin de semana.
Espero su aprobación...
danielgrj reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joaquinelio
joaquinelio requested changes Jul 27, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobar? ni loco,
Pffff una porquería.

apocope "primera", algun tilde que se me habia escapado, etcetcetcetctcetcetc

mmm debería borrar el comentario para no espantar a tu compatriota, ja ja
que hizo buena revisión
explicale que no hay maldad, solo es que soy algo transtornado.

cambios importantes:
varios "llaves" que eran "corchetes"
por las dudas verifiqué el drae
y llaves no es generico como brackets, es especificamente " { } " (cuando crea obj)
y corchetes " [ ] " (cuando accessdes props.)
entonces donde ilya dice "brackets" hay que fijarse cuales

es confuso hacer review.
creo que deberiamos explicar el uso de los label y el /done nunca les hice caso
pero ahora con el repo por fin prolijo, evitaría ssuperposiciones, es decir dessperdicio de trabajo.
Don bot rules!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/01-object/5-sum-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 27, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 27, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Maksumi Murakami and others added 7 commits July 26, 2020 22:43
Maksumi Murakami @joaquinelio
Update 1-js/04-object-basics/01-object/article.md
59c64ae 
Co-authored-by: joaquinelio <[email protected]>
Maksumi Murakami @joaquinelio
Update 1-js/04-object-basics/01-object/article.md
5ab2bda 
Co-authored-by: joaquinelio <[email protected]>
Maksumi Murakami @joaquinelio
Update 1-js/04-object-basics/01-object/article.md
6ee7129 
Co-authored-by: joaquinelio <[email protected]>
Maksumi Murakami @joaquinelio
Update 1-js/04-object-basics/01-object/article.md
07f7321 
Co-authored-by: joaquinelio <[email protected]>
Maksumi Murakami @joaquinelio
Update 1-js/04-object-basics/01-object/article.md
2609768 
Co-authored-by: joaquinelio <[email protected]>
Maksumi Murakami @joaquinelio
Update 1-js/04-object-basics/01-object/article.md
31ea37c 
Co-authored-by: joaquinelio <[email protected]>
Maksumi Murakami @joaquinelio
Apply suggestions from code review
0bbfc4a 
Co-authored-by: joaquinelio <[email protected]>
@maksumi

maksumi commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 27, 2020
@maksumi
maksumi requested a review from joaquinelio July 27, 2020 03:56
@maksumi

maksumi commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator Author

Jajajaja, sale, @joaquinelio en la desesperación de verle merge lo más pronto a este artículo decidí reemplazar todos los "brackets" olvidándome de los "square brackets".
Por favor, no olvides marcar la casillita de Approve and punch the Submmit Review button, @danielgrj, si estás de acuerdo con el commit final o en su defecto manda otra suggest
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaquinelio

joaquinelio commented Jul 27, 2020

Copy link
Copy Markdown
Member

Estoy dormido, así que supongo revisaste y cambiaste asi qe esta vez apruebo sin una mirada
lo unico importante era lo del os brackets, esos cosos que se ponen en los dientes

asusta un poco la velocidad en que aparecen pr,
anduve poco pero quiero darles priorridad para que no se desanimen nadie
el año pasado, con los 80 pr de meses muchos habran abandonado por eso...
tenerlo así prolijito es un orgullo...
mientra vpl hace las sync, si no no sé como aguantaríamos el ritmo

saludos y buenas noches
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joaquinelio
joaquinelio approved these changes Jul 27, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, no, era acá
aprob

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jul 27, 2020
danielgrj
danielgrj approved these changes Jul 27, 2020
View reviewed changes
@vplentinax vplentinax added ready to merge and removed needs +1 labels Jul 27, 2020
@joaquinelio
joaquinelio merged commit 94c1c13 into javascript-tutorial:master Jul 27, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 27, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
+1 more reviewer
@danielgrj danielgrj danielgrj approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@maksumi @javascript-translate-bot @joaquinelio @danielgrj @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.