GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Scripts: async, defer by dbritto-dev · Pull Request #324 · javascript-tutorial/es.javascript.info

Conversation

dbritto-dev commented Jul 26, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

dbritto-dev added 3 commits

July 25, 2020 22:55


          Translate - Scripts: async, defer

110c128


          Update article.md

387d40f


          Update article.md

javascript-translate-bot added the review needed label

Jul 26, 2020

CLAassistant commented Jul 26, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iliakan mentioned this pull request

Jul 26, 2020

Spanish Translation Progress #17

Open

joaquinelio self-requested a review

July 27, 2020 03:47

joaquinelio requested changes

Jul 27, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está bien, typos y tildes

podes aceptar, pelearme o ignorarme...
pero...
Creo que te ofreciste para review?
de los PR, con etiquetas "review needed", son los que no tuvieron revisión
o la tuvieron y el autor hizo/rechazó los cambios
Si está esperando "change req" no creo que valga la pena revisar, que el autor revise primero

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Jul 27, 2020

javascript-translate-bot commented Jul 27, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jul 27, 2020

dbritto-dev and others added 19 commits

July 27, 2020 00:02


          Update 2-ui/5-loading/02-script-async-defer/article.md

04fe54f

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

f13cceb

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

344e441

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

bb5d273

Co-authored-by: joaquinelio <[email protected]>


          Update article.md

5c441b2


          Update 2-ui/5-loading/02-script-async-defer/article.md

ad6a1fd

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

89185ba

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

6475b1c

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

f576eb0

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

656d411

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

91d7706

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

83e8176

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

844042d

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

e4aecf7

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

91b3af0

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

fe973fc

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

e925239

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

a0b8670

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

a2449ac

Co-authored-by: joaquinelio <[email protected]>

dbritto-dev and others added 3 commits

July 27, 2020 00:48


          Update 2-ui/5-loading/02-script-async-defer/article.md

212eb55

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/5-loading/02-script-async-defer/article.md

60d5e05

Co-authored-by: joaquinelio <[email protected]>


          Update article.md

dea6a11

dbritto-dev commented Jul 27, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 27, 2020

dbritto-dev requested a review from joaquinelio

July 27, 2020 18:34

joaquinelio approved these changes

Jul 27, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
autor y/o 2do reviewer,
*clic para arreglar nro linea, algo menor
*No estoy convencido de la tabla en 185 (de origen), pero el evento y la relacion con los scripts se explican bien en el art.
Más que ok.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/5-loading/02-script-async-defer/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added needs +1 and removed review needed labels

Jul 27, 2020


          Update 2-ui/5-loading/02-script-async-defer/article.md

b326102

Co-authored-by: joaquinelio <[email protected]>

dbritto-dev commented Jul 27, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the review needed label

Jul 27, 2020

dbritto-dev requested a review from joaquinelio

July 27, 2020 23:35

vplentinax approved these changes

Jul 29, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge needs +1 and removed needs +1 review needed ready to merge labels

Jul 29, 2020

joaquinelio merged commit b565bbb into javascript-tutorial:master

Jul 29, 2020

javascript-translate-bot commented Jul 29, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

vplentinax

vplentinax approved these changes

joaquinelio

Awaiting requested review from joaquinelio

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

dbritto-dev commented Jul 26, 2020

Uh oh!

CLAassistant commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 27, 2020

Uh oh!

dbritto-dev commented Jul 27, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbritto-dev commented Jul 27, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 29, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Jul 26, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.