GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — File and FileReader by daguitosama · Pull Request #325 · javascript-tutorial/es.javascript.info

Conversation

@daguitosama

@daguitosama daguitosama commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Spanish translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daguitosama
Update article.md
6d26688
Spanish translation
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 26, 2020
@CLAassistant

CLAassistant commented Jul 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daguitosama
Update article.md
e740ed2
correcciones
@vplentinax vplentinax changed the title Update article.md Fime and FileReader Jul 26, 2020
@vplentinax vplentinax changed the title Fime and FileReader File and FileReader Jul 26, 2020
@vplentinax

vplentinax commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Hola! Siempre recuerda que el PR lleva el nombre del artículo traducido. Así el bot te lo asigna en el Issue 17.

Un saludo

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan iliakan mentioned this pull request Jul 26, 2020
Spanish Translation Progress #17
Open
dbritto-dev
dbritto-dev suggested changes Jul 26, 2020
View reviewed changes
Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 26, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 26, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Jul 28, 2020

Copy link
Copy Markdown
Member

No lo revisé,
pero cuidemos que coincidadn los numeros de linea porq facilitan: revision y mantenim cdo cambia el ingles.

solo lei los suggest de @danilobrinu y por lo pronto estoy de acuerdo
*salvo 137 que dice URI o URl (jeje) en lugar de url ¿algun motivo para mayusscula?
y quizass traduccion de parametros dentro de codigo js, eso lo dejamos a eleccion hay q ser muy cuidadoso
*tambien sugiero poner explicacione a las sugerencias que no sesan obvias como los tildes,
ej "File aca no se traduce porq se refiere al nombre de la clase". La explicacion fuera de los marcadores
" ` " no se entrometen en el cambio sugerido.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dbritto-dev

dbritto-dev commented Jul 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

No lo revisé,
pero cuidemos que coincidadn los numeros de linea porq facilitan: revision y mantenim cdo cambia el ingles.

solo lei los suggest de @danilobrinu y por lo pronto estoy de acuerdo
*salvo 137 que dice URI o URl (jeje) en lugar de url ¿algun motivo para mayusscula?
y quizass traduccion de parametros dentro de codigo js, eso lo dejamos a eleccion hay q ser muy cuidadoso
*tambien sugiero poner explicacione a las sugerencias que no sesan obvias como los tildes,
ej "File aca no se traduce porq se refiere al nombre de la clase". La explicacion fuera de los marcadores
" ` " no se entrometen en el cambio sugerido.

@joaquinelio La traducción de DATA URL es Datos URI, algunos pensarán que es enlace de datos o algo por el estilo pero lo que se implementa detrás hace que tenga sentido Datos URI debido a que dicha URI contiene el URI Schema.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Jul 28, 2020

Copy link
Copy Markdown
Member

@danilobrinu
Debo confesar que el tema ME SUPERA, ¡contento de tener un corrector qu refuerce la parte conceptual!
Pero en inglés también existe URI, (y URN que tampoico entendí)
¿debería cambiarse ahí también?
¿es importante, o un error? Si es asi podemos poner un PR al repo inglés... no mi prioridad claro.

@joaquinelio La traducción de DATA URL es Datos URI, algunos pensarán que es enlace de datos o algo por el estilo pero lo que se implementa detrás hace que tenga sentido Datos URI debido a que dicha URI contiene el URI Schema.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dbritto-dev

dbritto-dev commented Jul 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@danilobrinu
Debo confesar que el tema ME SUPERA, ¡contento de tener un corrector qu refuerce la parte conceptual!
Pero en inglés también existe URI, (y URN que tampoico entendí)
¿debería cambiarse ahí también?
¿es importante, o un error? Si es asi podemos poner un PR al repo inglés... no mi prioridad claro.

@joaquinelio La traducción de DATA URL es Datos URI, algunos pensarán que es enlace de datos o algo por el estilo pero lo que se implementa detrás hace que tenga sentido Datos URI debido a que dicha URI contiene el URI Schema.

Si justamente es por que cuando se habla de URI es debido a que dicha URL contiene un URI schema. En pocas palabras una URL con URI Schema es un URI.

joaquinelio reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daguitosama
File and FileReader
77db0a0
sugested changes applied
@vplentinax

vplentinax commented Jul 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@d4g0 , siempre que aceptes una sugerencia de los revisores y hagas nuevo commit, escribe un comentario que sólo diga: /done .
Así se detectan los nuevos cambios.

Un saludo!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vplentinax @dbritto-dev
Update 4-binary/04-file/article.md
e5dc34e
Co-authored-by: Danilo Britto <[email protected]>
vplentinax
vplentinax requested changes Jul 31, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunos pequeños cambios. También sugerí sobre dos sugerencias hechas previamente por @danilobrinu .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot

javascript-translate-bot commented Jul 31, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-tutorial javascript-tutorial deleted a comment from dbritto-dev Jul 31, 2020
@javascript-tutorial javascript-tutorial deleted a comment from dbritto-dev Jul 31, 2020
@javascript-tutorial javascript-tutorial deleted a comment from dbritto-dev Jul 31, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 31, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-tutorial javascript-tutorial deleted a comment from dbritto-dev Jul 31, 2020
@javascript-tutorial javascript-tutorial deleted a comment from dbritto-dev Jul 31, 2020
@vplentinax

vplentinax commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

@danilobrinu Disculpa, quería eliminar algunas revisiones que se superpusieron, y terminé por quitar algunas tuyas. Si no te es molestia, ¿puedes volver a hacer la revisión? Gracias y disculpa nuevamente.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vplentinax @dbritto-dev
Update 4-binary/04-file/article.md
143cfe3
Co-authored-by: Danilo Britto <[email protected]>
@dbritto-dev

dbritto-dev commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

@vplentinax creo que en este punto lo mejor seria que termines la revisión. Sino me equivoco ya están la mayoría de ellos.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daguitosama and others added 2 commits July 31, 2020 22:54
@daguitosama @vplentinax
Update 4-binary/04-file/article.md
ad5ba12
/done

Co-authored-by: Valentina VP <[email protected]>
@daguitosama @vplentinax
Update 4-binary/04-file/article.md
7c96381
/done

Co-authored-by: Valentina VP <[email protected]>
@vplentinax

vplentinax commented Aug 1, 2020

Copy link
Copy Markdown
Contributor

@d4g0 Cuando termines de revisar y aceptar todos los cambios, escribe un comentario que solo diga: /done. Es necesario para que el bot nos avise para una nueva revisión o para aceptar la traducción. 😁

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daguitosama @vplentinax
Update 4-binary/04-file/article.md
8a71557
Co-authored-by: Valentina VP <[email protected]>
@daguitosama

daguitosama commented Aug 2, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 2, 2020
dbritto-dev
dbritto-dev suggested changes Aug 3, 2020
View reviewed changes
Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 4-binary/04-file/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Aug 3, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 3, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Aug 3, 2020
vplentinax
vplentinax approved these changes Aug 3, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobado, añadiendo los nuevos cambios sugeridos por @danilobrinu

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Aug 3, 2020
@vplentinax vplentinax added the changes requested label Aug 3, 2020
dbritto-dev
dbritto-dev approved these changes Aug 3, 2020
View reviewed changes
@javascript-translate-bot javascript-translate-bot removed the changes requested label Aug 3, 2020
@vplentinax vplentinax added the changes requested label Aug 3, 2020
joaquinelio
joaquinelio approved these changes Aug 3, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No lo revisé ni lo lei ni se de qe se trata,
pero Bot me pide que apruebe y apruebo.
y confio en la revision que bot ignora, suerte tenemos un par de relevos
que el ruso puede considerar si caemos en la lucha...
EDIT:
Y metí el rabo donde no debía, ¿cómo es esto de 2 aprobaciones y "requiere cambios"?
Ah, yo también lo hacía, si los cambios que sugería no eran vitales pero ahora veo que es confuso...
Me atreví a dar a aceptar y corregir para terminar de una buena vez, las correcctiones eran espacios, algun gramatical y numeros de linea, @d4g0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot removed the changes requested label Aug 3, 2020
joaquinelio and others added 8 commits August 3, 2020 13:24
@joaquinelio @dbritto-dev
Update 4-binary/04-file/article.md
8d3ba57
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 4-binary/04-file/article.md
739302d
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 4-binary/04-file/article.md
fad4a14
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 4-binary/04-file/article.md
f6842f3
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 4-binary/04-file/article.md
1734b55
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio @dbritto-dev
Update 4-binary/04-file/article.md
4d0a83a
Co-authored-by: Danilo Britto <[email protected]>
@joaquinelio
Sincronizados los nros de linea
4c8eb82
@joaquinelio
sincronizado nros linea 2da parte
73d6236
@joaquinelio
joaquinelio merged commit 287a5dc into javascript-tutorial:master Aug 3, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 3, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes
+1 more reviewer
@dbritto-dev dbritto-dev dbritto-dev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@daguitosama @CLAassistant @vplentinax @javascript-translate-bot @joaquinelio @dbritto-dev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.