GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Error handling with promises by george28cs · Pull Request #329 · javascript-tutorial/es.javascript.info

Conversation

george28cs commented Jul 29, 2020

Copy link

Copy Markdown

Contributor

Hola, envío el PR correspondiente a la traducción de "Manejo de errores con promesas".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          promises error handling v0

javascript-translate-bot added the review needed label

Jul 29, 2020

CLAassistant commented Jul 29, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

george28cs changed the title ~~promises error handling v0~~ promises error handling

Jul 29, 2020

joaquinelio changed the title ~~promises error handling~~ Error handling with promises

Jul 29, 2020

iliakan mentioned this pull request

Jul 29, 2020

Spanish Translation Progress #17

Open


          Merge branch 'master' into promises-error-handling

b0237b9

joaquinelio self-requested a review

July 29, 2020 15:50

joaquinelio requested changes

Jul 29, 2020

View reviewed changes

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@george28cs y reviewers
*Poco para corregir, no vi err de concepto,
ojalá un reviewer con más espalda JS que la mia lo mire...

*Tu PR está OK, Los archivos son los correctos y se ve muy bien.
*El nombre del PR debe ser exactamente (mayusc incluida) para que bot lo registre, nada grave, casi siempre lo modificamos a mano (cambié el nombre y actualicé el issue17).

NOTA: *Los arch originales inglés fueron modificados ayer y se generaron 2 conflictos:
Uno lo arreglé directamente en el traducido (el otro era gramatica inglés, no nos afecta)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Jul 29, 2020

javascript-translate-bot commented Jul 29, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jul 29, 2020

george28cs and others added 5 commits

July 29, 2020 18:07


          Update 1-js/11-async/04-promise-error-handling/article.md

016922b

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/11-async/04-promise-error-handling/article.md

2119ff6

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/11-async/04-promise-error-handling/article.md

26000d8

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/11-async/04-promise-error-handling/article.md

bd63d4d

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/11-async/04-promise-error-handling/article.md

e51ca46

Co-authored-by: joaquinelio <[email protected]>

george28cs commented Jul 29, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 29, 2020

joaquinelio approved these changes

Jul 30, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien...
a 2do reviewer, ¿es suficientemente clara la explicacion? promise, then, try, catch, y anidados...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Jul 30, 2020

vplentinax approved these changes

Jul 31, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcto, fluido. @joaquinelio , todos los conceptos se entienden bien.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Jul 31, 2020

vplentinax merged commit 2dfdbb3 into javascript-tutorial:master

Jul 31, 2020

javascript-translate-bot commented Jul 31, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

george28cs commented Jul 29, 2020

Uh oh!

CLAassistant commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 29, 2020

Uh oh!

george28cs commented Jul 29, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jul 31, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Jul 29, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.