GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — From the orbital height by Leired7 · Pull Request #331 · javascript-tutorial/es.javascript.info

Conversation

Leired7 commented Aug 2, 2020

Copy link

Copy Markdown

Contributor

Hay unos cuantos términos que no he traducido: Custom elements, Shadow DOM, CSS Scoping , Event retargeting .... espero al consenso : D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Leired7 added 2 commits

August 2, 2020 18:18


          Traducido

bc4b79f


          Correciones

27d0f45

javascript-translate-bot added the review needed label

Aug 2, 2020

joaquinelio self-requested a review

August 3, 2020 16:48

joaquinelio requested changes

Aug 3, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Consenso? ¡JA! Motivo de pelea.
Pero sí, algunas cosas nos fuimos amoldando...
Tiendo a dejar en inglés más que otros, especialmente en nombres muy específicos.
¿Alguien tradujo "pen-drive" alguna vez?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

8-web-components/1-webcomponents-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/1-webcomponents-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/1-webcomponents-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/1-webcomponents-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/1-webcomponents-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 3, 2020

javascript-translate-bot commented Aug 3, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 3, 2020

Leired7 and others added 5 commits

August 4, 2020 08:17


          Update 8-web-components/1-webcomponents-intro/article.md

88a6bc4

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/1-webcomponents-intro/article.md

df30b4e

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/1-webcomponents-intro/article.md

3b42b4f

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/1-webcomponents-intro/article.md

0cf4c60

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/1-webcomponents-intro/article.md

911604f

Co-authored-by: joaquinelio <[email protected]>

Leired7 commented Aug 4, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 4, 2020

joaquinelio approved these changes

Aug 4, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Aunque un segundo revisor probablemente pida más español.
O más aclaraciones. Supongo que ya debe saberse lo que es DOM porque no lo explica acá,
tampoco se si "shadow DOM". Si fuera la primera referencia, decir por qé "shadow".
"DOM interno"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Leired7 reacted with thumbs up emoji

All reactions

👍 1 reaction

javascript-translate-bot added needs +1 and removed review needed labels

Aug 4, 2020

Leired7 commented Aug 4, 2020

Copy link

Copy Markdown

Contributor Author

Supongo que "shadow DOM" será porque lo explicara más adelante... ya veremos si pasa el segundo review. Gracias :D

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax approved these changes

Aug 5, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gusta la traducción. Fluida y clara. Apruebo con o sin aprobar mi sugerencia en el tema del shadow DOM. Pero esperamos a que el autor nos indique que prefiere antes del merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

8-web-components/1-webcomponents-intro/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio merged commit 15e3723 into javascript-tutorial:master

Aug 5, 2020

iliakan mentioned this pull request

Aug 5, 2020

Spanish Translation Progress #17

Open

javascript-translate-bot commented Aug 5, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Aug 5, 2020

Copy link

Copy Markdown

Member

@Leired7
disculpame hice merge sin esperar tu feedback, asumi que estarias de acuerdo
Pero siempre es bienvenido un nuevo PR para proponer cambios

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Leired7 commented Aug 5, 2020 via email

Copy link

Copy Markdown

Contributor Author

Has hecho bien! ☺️

☺️

☺️ Me gusta mucho que enriquezcais mis traducciones 👍🏼🎉 El mié., 5 ago. 2020 15:00, joaquinelio <[email protected]> escribió:

…

@Leired7 <https://github.com/Leired7> disculpame hice merge sin esperar tu feedback, asumi que estarias de acuerdo Pero siempre es bienvenido un nuevo PR para proponer cambios — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#331 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKNHIL4K3722EN4UQDC5LLR7FJW7ANCNFSM4PST4QLQ> .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.