GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — TextDecoder and TextEncoder by homero304 · Pull Request #338 · javascript-tutorial/es.javascript.info

Conversation

homero304 commented Aug 9, 2020

Copy link

Copy Markdown

Contributor

Buenas tardes, podrian revisar mi pull request de favor?
gracias

saludos,
Homero Enrique Marin Galindo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          traduccion al espaniol

d00da17

javascript-translate-bot added the review needed label

Aug 9, 2020

CLAassistant commented Aug 9, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          cambiar la primera pregunta con signo de interrogacion

b3ca138

homero304 changed the title ~~traduccion al espaniol~~ TextDecoder and TextEncoder

Aug 9, 2020

iliakan mentioned this pull request

Aug 9, 2020

Spanish Translation Progress #17

Open

joaquinelio self-requested a review

August 9, 2020 18:27

joaquinelio requested changes

Aug 9, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bueno.
Las unicas objeciones son de estilo.

NOTA: código.
Parece bien hecho, acá es fácil de seguir,
pero usualmente no nos arriesgamos a modificar más que los // comentarios
porque, programadores, nos gusta adornarlos con bugs.
Si loss modificas, sería bueno que tengas el server local instalado para probarlos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

4-binary/02-text-decoder/article.md Outdated

		## TextEncoder

		[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) does the reverse thing -- converts a string into bytes.
		[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) hace lo contrario -- convierte un string en bytes.

joaquinelio Aug 9, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El doble guion -- es convertido por el server en guion largo — (no se ve asi en el git) .
En español el uso es — algo — distinto.

A veces lo dejo cuando es una lissta porque se ve maás claro,
opcion — hace tal cosa
opcion — hace tal cosa

pero como lo usa acá se ve mejor cambiarlo por ":"

Suggested change

	[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) hace lo contrario -- convierte un string en bytes.
	[TextEncoder](https://encoding.spec.whatwg.org/#interface-textencoder) hace lo contrario: convierte un string en bytes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

homero304 Aug 9, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

4-binary/02-text-decoder/article.md Outdated

		¿Qué pasa si los datos binarios son en realidad un string? Por ejemplo, recibimos un archivo con datos textuales.

		The build-in [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) object allows to read the value into an actual JavaScript string, given the buffer and the encoding.
		Al proporcionar el búfer y la codificación, el objeto [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) nos permite leer el texto de un conjunto de datos binarios y convertirlo en un dato de tipo string de JavaScript.

joaquinelio Aug 9, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No está NADA mal,
pero que el objeto importante esté al principio, (a veces combinado con la voz pasiva) tiene un propósito didáctico.
bufer y codificacion, secundarioss, quedan relegados al final de la oración

Suggested change

	Al proporcionar el búfer y la codificación, el objeto [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) nos permite leer el texto de un conjunto de datos binarios y convertirlo en un dato de tipo string de JavaScript.
	El objeto [TextDecoder](https://encoding.spec.whatwg.org/#interface-textdecoder) nos permite leer el texto de un conjunto de datos binarios y convertirlo en un dato de tipo string de JavaScript, dados el búfer y la codificación.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

homero304 Aug 9, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Aug 9, 2020

javascript-translate-bot commented Aug 9, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          applied suggested changes from review#1

53a2f13

homero304 commented Aug 9, 2020

Copy link

Copy Markdown

Contributor Author

Si, para ver los cambios, tengo el server corriendo local en la computadora

joaquinelio reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

homero304 commented Aug 9, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 9, 2020

joaquinelio approved these changes

Aug 10, 2020

View reviewed changes

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
bytheway,
podes discutirme las sugerencias, o rescribirlas, nadie es perfecto.
Edit:
Noto que me siguen figurando las recomendaciones,
supongo que las hiciste localmente y las subiste, lo que me da igual,
Pero si aceptaste las modificaciones "tal cual" las puse, es mucho más rápido usar el botón
"commit suggestion"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Aug 10, 2020

vplentinax approved these changes

Aug 11, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Ok!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Aug 11, 2020

joaquinelio merged commit b3ff949 into javascript-tutorial:master

Aug 11, 2020

javascript-translate-bot commented Aug 11, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

homero304 deleted the TextDecoder-and-TextEncoder branch

August 19, 2020 09:50

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

homero304 commented Aug 9, 2020

Uh oh!

CLAassistant commented Aug 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

joaquinelio Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

homero304 Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

joaquinelio Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

homero304 Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Aug 9, 2020

Uh oh!

homero304 commented Aug 9, 2020

Uh oh!

homero304 commented Aug 9, 2020

Uh oh!

joaquinelio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Aug 11, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Aug 9, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.