GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Object methods, "this" by joaquinelio · Pull Request #343 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Aug 11, 2020

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Object methods, "this"

937e47f

javascript-translate-bot added the review needed label

Aug 11, 2020

iliakan mentioned this pull request

Aug 11, 2020

Spanish Translation Progress #17

Open

dbritto-dev suggested changes

Aug 13, 2020

View reviewed changes

Comment thread

1-js/04-object-basics/04-object-methods/4-object-property-this/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/8-chain-calls/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 13, 2020

javascript-translate-bot commented Aug 13, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 13, 2020

joaquinelio and others added 9 commits

August 14, 2020 07:13


          Update 1-js/04-object-basics/04-object-methods/article.md

6ea2d55

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/article.md

6f38e54

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/article.md

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/article.md

cec58a6

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/4-object-property-this…

12bef1e

…/task.md

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/8-chain-calls/task.md

39d13f7

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/article.md

fc63d96

Co-authored-by: Danilo Britto <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/article.md

f0bfccc

Co-authored-by: Danilo Britto <[email protected]>


          Update article.md

a0a4875

joaquinelio commented Aug 14, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 14, 2020

maksumi reviewed

Aug 15, 2020

View reviewed changes

maksumi left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay algo que me causa confusión y creo que es bueno que nos lo verifiquemos. Leí un diccionario y creo que tienes razón en el "before" pero no estoy seguro ya que hay código de ejemplo que no puedo observar en modo review, así que revisaré el artículo con formato. Por otro lado a veces es difícil concentrarse en todo el contexto del artículo mientras haces review, entonces creo que eso me está pasando. Lo leeré y comprenderé antes de regresar a aprobar en caso de que tengas razón

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Outdated

		Aquí el valor de `this` dentro de `makeUser()` es `undefined`, porque es llamado como una función, no como un método con sintaxis de punto.

		The value of `this` is one for the whole function, code blocks and object literals do not affect it.
		El valor de `this` es uno para la función entera, bloques de código y objetos literales no lo afectan.

maksumi Aug 15, 2020

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	El valor de `this` es uno para la función entera, bloques de código y objetos literales no lo afectan.
	El valor de `this` es uno para la función entera. Bloques de código y objetos literales no lo afectan.

Funciona bien así como dos oraciones independientes en el mismo párrafo y pienso que se entiende mejor. Si lo leo con la coma me voy de corrido y pienso que es "función entera, bloques de código y objetos literales" hasta que mi cerebro hace corto circuito al encontrarse con "no lo afectan".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

dbritto-dev Aug 16, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maksumi la coma es justamente de pausa en este caso. No se recomiendo usa punto para dar pausa o separar oraciones pequeñas.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio Aug 16, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo qu amerita un " ; " !!!
si está mal no me importa.

Creo que se lee bien en una oracion si lee con el ritmo adecuado,
tambien reo que se puede poner en dos oraciones aunque se corte un poquito

pero asi no hay duda:
El valor de this es uno para la función entera; bloques de código y objetos literales no lo afectan.

podria haber puesto
fun entera, ni bloquess ni lieterales...
fun entera (biques y leterales....)
muy feo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/8-chain-calls/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio and others added 4 commits

August 15, 2020 19:53


          Update 1-js/04-object-basics/04-object-methods/4-object-property-this…

41c48b0

…/solution.md

Co-authored-by: Maksumi Murakami <[email protected]>


          Apply suggestions from code review

3803ad0

Co-authored-by: Maksumi Murakami <[email protected]>


          Update 1-js/04-object-basics/04-object-methods/article.md

1b97e0f

Co-authored-by: Maksumi Murakami <[email protected]>


          Update article.md

5b91491

joaquinelio commented Aug 15, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

el nombre viejo es usado!
no me parece "esta en uso", porque no lo está, trata de usarlo.
igual lo cambie a
¡usa el nombre viejo!
asi que al pobre lo siguen usando

a.X.b
cuál está delante de la X ?
y cual detras ?
uno escribe una palabra detras de otra...
si, es medio tramposo. Asi qe te hice caso y puse "antes" que no deja lugar a dudas.

No deja uar batch aca "onversation" , hice todo en "files changed" y otrass resolvi
vuelvo aca y aparecen alg sin resolver
igual edite y estan los cambios hechos y loss que no, resuesltos.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Aug 15, 2020

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update article.md

c60d007

dbritto-dev approved these changes

Aug 16, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Aug 16, 2020


          Update solution.md

066f260

maksumi approved these changes

Aug 16, 2020

View reviewed changes

Comment thread

1-js/04-object-basics/04-object-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

maksumi merged commit 56ea948 into javascript-tutorial:master

Aug 16, 2020

javascript-translate-bot commented Aug 16, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio deleted the obmeto branch

August 21, 2020 18:50

Reviewers

maksumi

maksumi approved these changes

+1 more reviewer

dbritto-dev

dbritto-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

joaquinelio commented Aug 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 13, 2020

Uh oh!

joaquinelio commented Aug 14, 2020

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maksumi Aug 15, 2020

Choose a reason for hiding this comment

Uh oh!

dbritto-dev Aug 16, 2020

Choose a reason for hiding this comment

Uh oh!

joaquinelio Aug 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaquinelio commented Aug 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Aug 15, 2020

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 16, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joaquinelio commented Aug 15, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.