GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Capturing groups by EzequielCaste · Pull Request #345 · javascript-tutorial/es.javascript.info

Conversation

@EzequielCaste

@EzequielCaste EzequielCaste commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EzequielCaste
translate 11-regexp-groups
511ffa0
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 11, 2020
@iliakan iliakan mentioned this pull request Aug 11, 2020
Spanish Translation Progress #17
Open
joaquinelio
joaquinelio requested changes Aug 12, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por perezoso no verifiqué si hay version mas nueva con ingles
ni si hay más archivos por traducir que estos,
usualmente lo hago como parte del review

Que aburrido que es este tema.
Extraño a @cortizg...

No lo habia leido, me hubiera venido bien lo de matchall y lo de grupo con nombre
este es mi regexp para el api issue17:

/([[\sX]])\s([.+])\s?((http[.\S]+))\s?((@\w+))?\s?(#\d+)?/

bytheway,
en este proyecto no importa para los marcados [X],
pero por esto del formato del match deberias respetar los campos,
al poner 2 autores 2 pr, o cosas ssin los identif que separan los campos, el bot se confundiría.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Aug 12, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Aug 12, 2020
EzequielCaste and others added 4 commits August 12, 2020 10:51
@EzequielCaste @joaquinelio
Update 9-regular-expressions/11-regexp-groups/article.md
8fa499e 
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 9-regular-expressions/11-regexp-groups/article.md
46f5f90 
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Update 9-regular-expressions/11-regexp-groups/article.md
a5e74b8 
Co-authored-by: joaquinelio <[email protected]>
@EzequielCaste @joaquinelio
Apply suggestions from code review
73300d6 
Co-authored-by: joaquinelio <[email protected]>
EzequielCaste
EzequielCaste commented Aug 12, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otro cambio

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joaquinelio

joaquinelio commented Aug 12, 2020

Copy link
Copy Markdown
Member

@EzequielCaste
"named xxxxxxx"
aparece en arts de
objetos (usaron como vos, "con nombre")
clases
regex

"xxxobjetos/clases/regxx con nombre"
me parece feo, pero por consistencia, te parece, lo dejamos asi ?
decime como lo pones y lo dejo igual en classes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EzequielCaste

EzequielCaste commented Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

@EzequielCaste
"named xxxxxxx"
aparece en arts de
objetos (usaron como vos, "con nombre")
clases
regex

"xxxobjetos/clases/regxx con nombre"
me parece feo, pero por consistencia, te parece, lo dejamos asi ?
decime como lo pones y lo dejo igual en classes

ok lo dejamos como Grupo con nombre

aunque me gusta más la otra forma...queda más profesional
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EzequielCaste
EzequielCaste commented Aug 13, 2020
View reviewed changes

@EzequielCaste EzequielCaste left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EzequielCaste
EzequielCaste merged commit 8082e03 into javascript-tutorial:master Aug 13, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 13, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@EzequielCaste @javascript-translate-bot @joaquinelio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.