GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Object to primitive conversion by homero304 · Pull Request #350 · javascript-tutorial/es.javascript.info

Conversation

@homero304

@homero304 homero304 commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

Hi, Could you review this PR?
Thanks
Regards,
Homero Marin

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@omero329
Object to primitive conversion
b3442df
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 17, 2020
joaquinelio
joaquinelio requested changes Aug 17, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ademas de sugerencias normales,

"hint" no es js, no es programacion, deberiamos traducirlo
No lo hice porque NO entendía qué corno era. (para mi era "pista" que lleva a deduccion, o "inferencia")
cuando convierte, trata de seguir la sugerencia si puede, o si no sabe que otraa cosa hacer,
aunque no me quedo claro de donde viene, parece preprogramadas, no tengo ganas de estudiar

podrias cambiar "hint" o esperar sugerencia de otro reviewer como @maksumi ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Aug 17, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 17, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

omero329 and others added 9 commits August 17, 2020 07:29
@omero329 @joaquinelio
Update 1-js/04-object-basics/09-object-toprimitive/article.md
11c646b
numérico->número

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 1-js/04-object-basics/09-object-toprimitive/article.md
7e9f02b
unitario->unario

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 1-js/04-object-basics/09-object-toprimitive/article.md
82b1f22
el key simbólico-> la clave simbólica

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 1-js/04-object-basics/09-object-toprimitive/article.md
781a82e
El->Un

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 1-js/04-object-basics/09-object-toprimitive/article.md
f444ef0
insinuada->sugerida

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 1-js/04-object-basics/09-object-toprimitive/article.md
1e0be0a
de lo contrario->en caso contrario

Co-authored-by: joaquinelio <[email protected]>
@omero329
hint->sugerencia
fa8d531
@omero329
de lo contrario -> en caso contrario
a438bb6
@omero329
key->clave
7123e3e
@homero304

homero304 commented Aug 17, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 17, 2020
@iliakan iliakan mentioned this pull request Aug 17, 2020
Spanish Translation Progress #17
Open
@maksumi

maksumi commented Aug 17, 2020

Copy link
Copy Markdown
Collaborator

Revisando...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi
maksumi approved these changes Aug 19, 2020
View reviewed changes

@maksumi maksumi left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Excelente traducción! Salvo algunos detalles desde mi perspectiva, siéntete libre de implementarlos o no.

P.D. Muchos traductores nos dirigimos al lector de manera informal, "tú" y no "usted". Es bajo criterio de cada quién, no estoy seguro si ya se estableció algo al respecto pero creo que mantiene al tutorial amigable con el lector y también sería bueno que fuera uniforme en todos los capítulos para que el lector no se sienta viejo. Mi opinión

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Aug 19, 2020
omero329 and others added 3 commits August 18, 2020 19:31
@omero329 Maksumi Murakami
Update 1-js/04-object-basics/09-object-toprimitive/article.md
6910632
string->strings

Co-authored-by: Maksumi Murakami <[email protected]>
@omero329 Maksumi Murakami
Update 1-js/04-object-basics/09-object-toprimitive/article.md
ad3442e
Entonces->Por lo tanto

Co-authored-by: Maksumi Murakami <[email protected]>
@omero329 Maksumi Murakami
Update 1-js/04-object-basics/09-object-toprimitive/article.md
b3a3567
"`+`"->"El `+`"

Co-authored-by: Maksumi Murakami <[email protected]>
@maksumi

maksumi commented Aug 19, 2020

Copy link
Copy Markdown
Collaborator

Yo ya aprové... Espereamos el veredicto final de @joaquinelio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio
joaquinelio approved these changes Aug 19, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está bien.
@maksumi @homero304

No me gusta el enfoque inglés, prefiero el de MDN, pero no voy a cambiarlo claro.

hint es solo un argumento interno.
No hay 3 tipos de conversion,
hay 3 tipos de "sugerencias" que la conversion puede usar o no,
hint es solo el "tipo preferido",
default no creo que pueda llamarse un "tipo de conversion".

Bien se podia explicar todo desde el tipo preferido y de alli los casos y apenas mencionar hint.

No pude poner todo eso en una sola frase y que no sea rebuscada.

18 "The conversion is guided by a "preferred type" parameter or "hint" (spec link)...
algo asi

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@joaquinelio
joaquinelio merged commit 8d28618 into javascript-tutorial:master Aug 19, 2020
@javascript-translate-bot

javascript-translate-bot commented Aug 19, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@homero304
homero304 deleted the Object-to-primitive-conversion branch August 19, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@maksumi maksumi maksumi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@homero304 @javascript-translate-bot @maksumi @joaquinelio @omero329
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.