GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Date and Time by Fedebornaz · Pull Request #352 · javascript-tutorial/es.javascript.info

Conversation

Fedebornaz commented Aug 18, 2020

Copy link

Copy Markdown

Contributor

Traducción del artículo Date and Time con sus respectivos ejercicios.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Traducción del artículo Date and Time

81b3a90

javascript-translate-bot added the review needed label

Aug 18, 2020

CLAassistant commented Aug 18, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maksumi commented Aug 19, 2020

Copy link

Copy Markdown

Collaborator

Revisando

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Aug 19, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lindo trabajo

Linea 97
agregaie ``` que falta (marca el final de un box), que no puedo agregar como suggest
ademass con eso los nros de linea van a coincidir

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/11-date/1-new-date/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/3-weekday/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/4-get-date-ago/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/4-get-date-ago/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/4-get-date-ago/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Aug 19, 2020

javascript-translate-bot commented Aug 19, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iliakan mentioned this pull request

Aug 19, 2020

Spanish Translation Progress #17

Open

Fedebornaz and others added 19 commits

August 19, 2020 11:31


          Update 1-js/05-data-types/11-date/1-new-date/solution.md

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/3-weekday/task.md

5ed3cfa

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/4-get-date-ago/solution.md

c815759

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/4-get-date-ago/task.md

3d69f63

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/4-get-date-ago/task.md

8ed2752

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md

b5bf760

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md

d60abda

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

79c88fb

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

415e063

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

4f5de13

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/8-format-date-relative/task.md

f619ed7

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

602a2d1

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

4fce385

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

6c114e2

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

401c423

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

80b74c7

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

6b4af91

Co-authored-by: joaquinelio <[email protected]>


          agregados caracteres de cierre de box en línea 97

d53946c


          Merge branch 'date-and-time' of https://github.com/Fedebornaz/es.java…

ee2b149

…script.info into date-and-time

Fedebornaz commented Aug 19, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the changes requested label

Aug 19, 2020

javascript-translate-bot added the review needed label

Aug 19, 2020

joaquinelio added 4 commits

August 19, 2020 17:14


          Update article.md

48e5264


          Update task.md

b59c98c


          Update solution.md

191567f


          Update article.md

1f4722f

joaquinelio approved these changes

Aug 19, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me atreví a hacer unos commits así pasamos directamente a 2da revisión,
typos, "función", "desde" en una suggest mia, la s me falla (también sos revisor de mis revisiones, podes leerlas, cambiarlas, discutirlas) y

y , pido disculpas, volví atrás la sugerencia timestamp. Habia buscado mal la primera referencia, está perfectamente definida al principio. Así que saqué la re-definicipon desprolija que hice más adelante.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Aug 19, 2020

maksumi commented Aug 19, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Estaba revisando este artículo pero no podré cumplir con él a buena hora. Par no detenerlo más, pido la ayuda de @vplentinax, @EzequielCaste o algún otro reviewer que se tome la molestia de venir por aquí, leer el comentario y quiera echar una manita de gato con esto. Mil gracias de antemano

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax requested changes

Aug 27, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas, el resto correcto. Corregido esto, aprobamos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/11-date/2-get-week-day/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Aug 27, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 27, 2020

Fedebornaz and others added 4 commits

August 27, 2020 22:26


          Update 1-js/05-data-types/11-date/article.md

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

f3bdfca

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/05-data-types/11-date/article.md

63681a2

Co-authored-by: Valentina VP <[email protected]>


          Update 1-js/05-data-types/11-date/2-get-week-day/solution.md

450593e

Co-authored-by: Valentina VP <[email protected]>

Fedebornaz commented Aug 28, 2020

Copy link

Copy Markdown

Contributor Author

Muchas gracias @vplentinax y @joaquinelio por tomarse el tiempo para hacer las reviews! Veo que la mayoría de las correcciones que me hicieron fueron typos, voy a investigar si hay alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

vplentinax reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fedebornaz commented Aug 28, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 28, 2020

vplentinax approved these changes

Aug 28, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 review needed labels

Aug 28, 2020

vplentinax added 2 commits

August 27, 2020 22:56


          Update solution.md

046c2fc

Según repo EN.


          Update solution.md

e343aa2

Según repo EN

joaquinelio commented Aug 28, 2020

Copy link

Copy Markdown

Member

alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

@Fedebornaz don maksumi recomendó
Spanish code spell checker
pero no lo probé... y sigo con los typos...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio merged commit c944cdf into javascript-tutorial:master

Aug 28, 2020

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Fedebornaz commented Aug 18, 2020

Uh oh!

CLAassistant commented Aug 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maksumi commented Aug 19, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 19, 2020

Uh oh!

Fedebornaz commented Aug 19, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

maksumi commented Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 27, 2020

Uh oh!

Fedebornaz commented Aug 28, 2020

Uh oh!

Fedebornaz commented Aug 28, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

joaquinelio commented Aug 28, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Aug 18, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

maksumi commented Aug 19, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.