GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Popups and window methods by Derlys · Pull Request #359 · javascript-tutorial/es.javascript.info

Conversation

Derlys commented Aug 25, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the review needed label

Aug 25, 2020

CLAassistant commented Aug 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update 3-frames-and-windows/01-popup-windows/article.md

50534a2

Derlys force-pushed the derlys/popups-windows branch from ed73617 to 50534a2 Compare

August 25, 2020 22:10

joaquinelio changed the title ~~Update 3-frames-and-windows/01-popup-windows/article.md~~ Popups and window methods

Aug 25, 2020

joaquinelio self-requested a review

August 25, 2020 22:24

joaquinelio added 7 commits

August 25, 2020 19:32


          numeración

a3af98b


          numeracion

4d63ccd


          numeracion

ccf21bd


          restablece codigo original lin 141

f8737a1


          numeracion

9de22f2


          linea de más, numeracion

be5c599


          numeracion

337d553

joaquinelio requested changes

Aug 26, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uf que arduo fue esto
espero qie no te desanime =)

Conviene que el nombre del PR sea el del articulo, asi Don Bot lo registra. Igual anda perezoso y lo terminamos agregando a mano asi que no big deal.

Cuida los numeros de linea, facilita la review y ESPECIALMENTE los merge de actualizaciones del inglés.
Me atreví a corregirlos para esta review.
No agregues/quites lineas.

Tampoco deberias cambiar el estilo, veo que esspecialmente cambiaste comillas y pusiste esspacios, (y en ningun proyecto ajeno) aunque te parezca horrible ( salvo si es bug, que mandamos pr al inglés)
Por ej nunca uso ";" en mi codigo pero si es compartido me adapto a poner esa porquería inutil.

No modifiques codigo si no podes probarlo plis
Si te interesa podes instalar el server local para probar,
ademas asi se entiende como funcionan los markups

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 26, 2020

javascript-translate-bot commented Aug 26, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 26, 2020

iliakan mentioned this pull request

Aug 26, 2020

Spanish Translation Progress #17

Open

EzequielCaste and others added 12 commits

August 28, 2020 12:50


          Update 3-frames-and-windows/01-popup-windows/article.md

338de5a

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

5fa8006

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

0c9c5b3

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

c91d027

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

2f885e5

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

c56b3de

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

897ed64

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

469f90d

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

d60fe91

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

107fc6f

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

1bbb05c

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

5b2693f

Co-authored-by: joaquinelio <[email protected]>

joaquinelio added 2 commits

September 2, 2020 03:30


          numeracion 219

17680d8


          numeracion 244

a54f479

joaquinelio requested changes

Sep 2, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAAHHHH!!!
Perdonperdonperdon ¡Me pasé por alto unos cambios importantes!
Muchos atributos que son parametros, no se traducen `width:200,height=100
Va de nuevo...

No corrijo formatos porque el original tampoco es homogeneo
además veo que el también empezó a agregar los ";"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

3-frames-and-windows/01-popup-windows/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Sep 2, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Sep 2, 2020

Copy link

Copy Markdown

Member

Reto:
Lo es. Fue tambien mi primera vez. y aprendi un monton de git y js en pocos meses así que te entiendo.

PR:
Nada importante.
Se debería poner el nombre exacto del articulo como nombre de PR, pero igual el bot a veces lo ignora y lo terminamos agregando a mano.

Comillas:
SEGURAMENTE a tu editor se le puede configurar el corrector de estilo o deshabilitarlo.
Es importante porque podriass trabajar en diferentes equipos con diferentes estilos y deberias respetarlos aunque sean una porquería.
Y acá especificamente porque mucho del codigo puede tener markup, parece que tu editor lo borró.

De nuevo al ruedo... 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Derlys and others added 10 commits

September 2, 2020 13:16


          Update 3-frames-and-windows/01-popup-windows/article.md

1e3f2ca

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

2b786f0

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

46f65c7

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

d915a5c

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

6d3080c

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

60b8418

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

91874b4

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

47dca55

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

be7c8f3

Co-authored-by: joaquinelio <[email protected]>


          Update 3-frames-and-windows/01-popup-windows/article.md

cabcd42

Co-authored-by: joaquinelio <[email protected]>

joaquinelio approved these changes

Sep 4, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

Sep 4, 2020

Derlys closed this

Sep 4, 2020

joaquinelio commented Sep 4, 2020

Copy link

Copy Markdown

Member

@Derlys
Me llegó el mensaje "closed"... je quiero creer que fue un dedo mal puesto, ¿no?
o será que te arrepentiste...
falta un reviewer y va para el sitio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Derlys commented Sep 4, 2020 via email

Copy link

Copy Markdown

Contributor Author

Hola, es que lo hice mal, cual es el paso a seguir? El vie., 4 sept. 2020 a las 15:18, joaquinelio (<[email protected]>) escribió:

…

@Derlys <https://github.com/Derlys> Me llegó el mensaje "closed"... je quiero creer que fue un dedo mal puesto, ¿no? o será que te arrepentiste... falta un reviewer y va para el sitio — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#359 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN6GO75KB6II5EXBWEYANELSEFDQFANCNFSM4QLD7G4A> .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Sep 4, 2020

Copy link

Copy Markdown

Member

Si está mal, se puede cerrar y hacer uno nuevo
o mejor corregirlo...

¿qué es lo que está mal?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Derlys reopened this

Sep 5, 2020

Derlys commented Sep 5, 2020

Copy link

Copy Markdown

Contributor Author

Lo que te quiero decir es que no se que se debe hacer ahora con esto, dice changes aprobado ahora que sigue?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Sep 5, 2020

Copy link

Copy Markdown

Member

Ah, nada de tu lado hasta que alguien más lo vea.

el +1 significa otro reviewer, una segunda revisión...
andamos escasos de reviewers asi que solo hay que esperar.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax approved these changes

Sep 8, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay algunas palabras que pueden cambiarse para no romper el flujo de lectura pero se puede arreglar en alguna revisión posterior de archivos traducidos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Sep 8, 2020

joaquinelio merged commit fda8501 into javascript-tutorial:master

Sep 8, 2020

javascript-translate-bot commented Sep 8, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

EzequielCaste

EzequielCaste left review comments

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Derlys commented Aug 25, 2020

Uh oh!

CLAassistant commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 26, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 2, 2020

Uh oh!

joaquinelio commented Sep 2, 2020

Uh oh!

joaquinelio commented Sep 4, 2020

Uh oh!

Derlys commented Sep 4, 2020 via email

Uh oh!

joaquinelio commented Sep 4, 2020

Uh oh!

Derlys commented Sep 5, 2020

Uh oh!

joaquinelio commented Sep 5, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Sep 8, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Aug 25, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.