GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Dispatching custom events by homero304 · Pull Request #363 · javascript-tutorial/es.javascript.info

Conversation

homero304 commented Aug 30, 2020

Copy link

Copy Markdown

Contributor

Hi
Could you review my PR?
Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Dispatching custom events

e742eff

javascript-translate-bot added the review needed label

Aug 30, 2020

joaquinelio self-requested a review

August 30, 2020 07:47

joaquinelio requested changes

Aug 30, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta'güeno.
Un paso más a la meta.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 30, 2020

javascript-translate-bot commented Aug 30, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 30, 2020

omero329 and others added 8 commits

August 30, 2020 13:54


          Update 2-ui/2-events/05-dispatch-events/article.md

4ecec80

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

d84feae

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

fa758b0

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

bd99887

Co-authored-by: joaquinelio <[email protected]>


          changed to "event.isTrusted es true" instead

ab5ed13


          Update 2-ui/2-events/05-dispatch-events/article.md

e116d39

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

b80822d

Co-authored-by: joaquinelio <[email protected]>


          Merge branch 'Dispatching-custom-events' of https://github.com/homero…

929bbe6

…304/es.javascript.info into Dispatching-custom-events

homero304 commented Aug 30, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 30, 2020

homero304 commented

Aug 30, 2020

View reviewed changes

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

omero329 added 2 commits

August 30, 2020 14:25


          removed extra space between dispatchEvent and (event)

56902ed


          changed "click" to click

8cff381

joaquinelio approved these changes

Aug 30, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nota:
No presto atención a "click" porque ya está extendido,
pero así como no escribiimos "WOF!" cuando ladra un perro, "CLIC" es la onomatopeya correcta en español, no hacia falta que los volvieras al inglés.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Aug 30, 2020

EzequielCaste requested changes

Aug 31, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bastante bien 👍 💯

Hice algunas sugerencias, nada grave. Se lee bien y fluido.

Gracias!!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 31, 2020

javascript-translate-bot commented Aug 31, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

omero329 and others added 3 commits

August 31, 2020 13:42


          Update 2-ui/2-events/05-dispatch-events/article.md

e35e2d8

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

2116faf

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

7057a5a

Co-authored-by: Ezequiel Castellanos <[email protected]>

omero329 and others added 2 commits

August 31, 2020 13:43


          Update 2-ui/2-events/05-dispatch-events/article.md

5399dde

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 2-ui/2-events/05-dispatch-events/article.md

b9dfd9d

Co-authored-by: Ezequiel Castellanos <[email protected]>

homero304 commented Aug 31, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 31, 2020


          Merge branch 'master' of https://github.com/javascript-tutorial/es.ja…

a882538

…vascript.info into Dispatching-custom-events

EzequielCaste approved these changes

Aug 31, 2020

View reviewed changes

EzequielCaste merged commit f15313a into javascript-tutorial:master

Aug 31, 2020

iliakan mentioned this pull request

Aug 31, 2020

Spanish Translation Progress #17

Open

javascript-translate-bot commented Aug 31, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

EzequielCaste

EzequielCaste approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.