GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — URL objects by Agus-c · Pull Request #376 · javascript-tutorial/es.javascript.info

Conversation

Agus-c commented Sep 7, 2020

Copy link

Copy Markdown

Contributor

hola! tuve algunas dudas con respecto a la traducción de algunas lineas (16, 17 por ej.), aunque intenté hacerlo de todas formas. lo siento, espero que no sea mucha molestia.
Ademas, vi algunas cosas raras en el original, como en la linea 65. Pero no estoy seguro de que sean errores o no (tampoco sabría como solucionarlo), así que decidí dejarlo como estaba.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Agus-c added 3 commits

August 25, 2020 19:16


          Update article.md

898fe57

ey


          Update article.md

eb15c07


          Update article.md

73fb0b3

Primer dia de trabajo. Completo, aunque necesita revision, hay cosas con las que no estoy seguro

javascript-translate-bot added the review needed label

Sep 7, 2020

CLAassistant commented Sep 7, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iliakan mentioned this pull request

Sep 8, 2020

Spanish Translation Progress #17

Open

vplentinax requested changes

Sep 8, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @Agus-c , entiendo tus dudas con las líneas 16 y 17, son bastante confusas, pero en la línea 17 el "set" se refería al mismo "base" al que se estaba describiendo. Es decir, si se establece (base) y aparte de eso la "url" es una ruta única, entonces sucede lo que dice el resto de la línea. Realmente resultaba confuso, tardé un ratito en tomarle el sentido.

Por todo lo demás, sólo unas correcciones ortográficas para que pueda aprobarlo. ¡Un saludo!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Sep 8, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax requested a review from joaquinelio

September 8, 2020 02:43

vplentinax requested changes

Sep 8, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disculpa, olvidé estas correcciones...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

5-network/07-url/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

5-network/07-url/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Sep 8, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Sep 8, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bienvenido.

Algun cambio.

SSolemos traducir linkss, pero con MDN :
Tiene traducciones incompletas,
Es muy visible el combo de cambiar idioma
El ruso lo está cambiando por un sistema de path relativo, no me voy a poner a cambiarlo

@vplentinax
No sé si traducir path, quizas deberia etar entre la opcionales

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

5-network/07-url/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

5-network/07-url/article.md Outdated


		- `url` -- the full URL or only path (if base is set, see below),
		- `base` -- an optional base URL: if set and `url` argument has only path, then the URL is generated relative to `base`.
		- `url` -- La URL completa o único path (si base está establecido, mira debajo),

joaquinelio Sep 8, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, otro caso de "a quien queres mas"... jajaj

Está confuso el inglés así que no lo respeto.
¡Es mas facil! Los hubiera separado y no explicar tanto.
pones (url) o (path, urlbase)
Pero es más rebuscado que una concatenacion

edit: sí los separó despues, no dije nada.
pero la linea ess confusa, y con la coma agregada se entiende enseguida.

Además "unico" añade confusion, prefiero "unicamente"

Suggested change

	- `url` -- La URL completa o único path (si base está establecido, mira debajo),
	- `url` -- La URL completa, o solamente la ruta si se establece base (mira debajo),

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

5-network/07-url/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

5-network/07-url/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

5-network/07-url/article.md Outdated

		## Codificación

		There's a standard [RFC3986](https://tools.ietf.org/html/rfc3986) that defines which characters are allowed in URLs and which are not.
		Existe un estándar [RFC3986](https://tools.ietf.org/html/rfc3986) que define cuales caracteres son permitidos en URLs y cuáles no.

joaquinelio Sep 8, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pron. indef. m. y f. En la construcción cuál(es)… cuál(es)…, equivale a uno(s)… otro(s)… A cuál cubre, a cuál ciega, a cuál embiste.

como pronombre no lleva acento solo si es relativo "los cuales"

Suggested change

	Existe un estándar [RFC3986](https://tools.ietf.org/html/rfc3986) que define cuales caracteres son permitidos en URLs y cuáles no.
	Existe un estándar [RFC3986](https://tools.ietf.org/html/rfc3986) que define cuáles caracteres son permitidos en URLs y cuáles no.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

5-network/07-url/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Sep 8, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Sep 8, 2020

Copy link

Copy Markdown

Member

Una review sin esperar la anterior se ve confuso, sorry no lo vuelvo a hacer.

Sobre las cosas raras, es el markdown, .md es la extensión de markdown, como los tags htm para titulos.
El git tiene uno, pero el server del repo tiene otro más evolucionado asi que el preview aca se ve distinto al online.
Podess instalar sserver local para probar formato, links , y ejercicios

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Agus-c and others added 14 commits

September 17, 2020 17:20


          Update 5-network/07-url/article.md

f4a447d

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

745b03c

Co-authored-by: joaquinelio <[email protected]>


          Update 5-network/07-url/article.md

646464f

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

b84cccc

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

45fbab4

Co-authored-by: joaquinelio <[email protected]>


          Update 5-network/07-url/article.md

d6c7495

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

78088ea

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

3814ba8

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

f615d7b

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

aa98c6d

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

a760ce6

Co-authored-by: joaquinelio <[email protected]>


          Update 5-network/07-url/article.md

0b59416

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

78f9b37

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

643ecd4

Co-authored-by: Valentina VP <[email protected]>


          Update 5-network/07-url/article.md

c467e08

Co-authored-by: joaquinelio <[email protected]>

Agus-c commented Sep 17, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 17, 2020

javascript-translate-bot requested a review from a team

September 17, 2020 20:29

joaquinelio approved these changes

Sep 20, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.
pero...

alguna duda con el acento a cuales ? por ahi lo explique mal...
ejemplo de la real academia:
"Le explicó cuáles eran sus razones." linea 119 va acentuada
(como pron relativo sin acento es "le explicó sus razones, las cuales...")
aprobado y que no se pierda mas tiempo, pero la suggest stands.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Sep 20, 2020

vplentinax approved these changes

Sep 20, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Sep 20, 2020

joaquinelio merged commit 304689c into javascript-tutorial:master

Sep 20, 2020

javascript-translate-bot commented Sep 20, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Agus-c commented Sep 7, 2020

Uh oh!

CLAassistant commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 8, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 8, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joaquinelio Sep 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joaquinelio Sep 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 8, 2020

Uh oh!

joaquinelio commented Sep 8, 2020

Uh oh!

Agus-c commented Sep 17, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Sep 20, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 7, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.