GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Browser default actions by homero304 · Pull Request #378 · javascript-tutorial/es.javascript.info

Conversation

homero304 commented Sep 11, 2020

Copy link

Copy Markdown

Contributor

please review my PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the review needed label

Sep 11, 2020


          Browser default actions

243a87c

homero304 force-pushed the Browser-default-actions branch from a5d87fc to 243a87c Compare

September 11, 2020 03:20

joaquinelio requested changes

Sep 11, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que no hay errores y todas son sugerencias de estilo, aplicala s o cambialas si queres

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/1-why-return-false-fails/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/3-image-gallery/source.view/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Sep 11, 2020

javascript-translate-bot commented Sep 11, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Sep 11, 2020

joaquinelio mentioned this pull request

Sep 11, 2020

Spanish Translation Progress #17

Open

omero329 and others added 7 commits

September 11, 2020 08:25


          Update 2-ui/2-events/04-default-browser-action/article.md

c17b5f6

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/article.md

91cf14a

Co-authored-by: joaquinelio <[email protected]>


          'Entonces','de inmediato'

41f89c1


          Update 2-ui/2-events/04-default-browser-action/1-why-return-false-fai…

9389b69

…ls/solution.md

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…

52bdeda

…n/solution.md

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/3-image-gallery/source…

febee0a

….view/index.html

Co-authored-by: joaquinelio <[email protected]>


          Merge branch 'Browser-default-actions' of https://github.com/homero30…

9bd14bd

…4/es.javascript.info into Browser-default-actions

homero304 commented Sep 11, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 11, 2020

joaquinelio requested changes

Sep 12, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿me disculpas que haya agregado mas cosas? de estilo tambien

salvo un acento faltante que note haciendo zoom

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/2-events/04-default-browser-action/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Sep 12, 2020

javascript-translate-bot commented Sep 12, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

omero329 and others added 5 commits

September 12, 2020 10:45


          Update 2-ui/2-events/04-default-browser-action/article.md

b79e278

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/2-catch-link-navigatio…

f074459

…n/task.md

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/article.md

b18160b

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/article.md

95bda95

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/2-events/04-default-browser-action/article.md

ae338c5

Co-authored-by: joaquinelio <[email protected]>

homero304 commented Sep 12, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 12, 2020

javascript-translate-bot requested a review from a team

September 12, 2020 15:46

joaquinelio approved these changes

Sep 12, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Sep 12, 2020

vplentinax approved these changes

Sep 14, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Sep 14, 2020

joaquinelio merged commit 5d87fd8 into javascript-tutorial:master

Sep 15, 2020

javascript-translate-bot commented Sep 15, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.