GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Server Sent Events by homero304 · Pull Request #381 · javascript-tutorial/es.javascript.info

Conversation

@homero304

@homero304 homero304 commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

please review my PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@omero329
Server Sent Events
110a9c4
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 17, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 17, 2020 21:12
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 17, 2020
Spanish Translation Progress #17
Open
omero329 added 2 commits September 17, 2020 16:13
@omero329
Merge branch 'master' into Server-Sent-Events
7dbf41d
@omero329
Segunda línea - 49:
4d8b170
@vplentinax
vplentinax requested review from joaquinelio and vplentinax September 20, 2020 05:08
joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy claro, tá bueno
un par de cositas nomás

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 5-network/12-server-sent-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 5-network/12-server-sent-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Sep 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Sep 20, 2020
omero329 and others added 2 commits September 20, 2020 07:20
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
82d2366 
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
72f9898 
Co-authored-by: joaquinelio <[email protected]>
@homero304

homero304 commented Sep 20, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Sep 20, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 20, 2020 12:22
joaquinelio
joaquinelio requested changes Sep 20, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry por la vuelta
una que sugerí me molesta,

y otra que molestaba no supe sugerir antes.

Molesta tambien lo de "cross origin", no traducirlo ni explicarlo,
pero linkea a FETCH en este mismo capitulo y es donde lo explica asi que es correcto que quede así.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 5-network/12-server-sent-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 5-network/12-server-sent-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Sep 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vplentinax
vplentinax approved these changes Sep 20, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Sep 20, 2020
omero329 and others added 2 commits September 20, 2020 15:26
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
cd290ad 
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 5-network/12-server-sent-events/article.md
aff46c4 
Co-authored-by: joaquinelio <[email protected]>
@homero304

homero304 commented Sep 20, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 20, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 20, 2020 20:27
joaquinelio
joaquinelio approved these changes Sep 21, 2020
View reviewed changes
@joaquinelio
joaquinelio merged commit 7de52cc into javascript-tutorial:master Sep 21, 2020
@javascript-translate-bot

javascript-translate-bot commented Sep 21, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@homero304 @javascript-translate-bot @joaquinelio @vplentinax @omero329
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.