GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Styles and classes by dbritto-dev · Pull Request #413 · javascript-tutorial/es.javascript.info

Conversation

@dbritto-dev

@dbritto-dev dbritto-dev commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 8, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 8, 2020 17:47
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 8, 2020
Spanish Translation Progress #17
Open
@dbritto-dev

dbritto-dev commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

@vplentinax el archivo de 2-ui/1-document/08-styles-and-classes/solution.md esta vacío

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vplentinax

vplentinax commented Oct 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@danilobrinu Comprueba si en la repo de inglés está vacío también. Si tiene contenido, tradúcelo tomando el contenido de allí.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dbritto-dev

dbritto-dev commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

@vplentinax en el repo original también lo está.

repo original: https://github.com/javascript-tutorial/en.javascript.info/blob/master/2-ui/1-document/08-styles-and-classes/2-create-notification/solution.md

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vplentinax

vplentinax commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Pues entonces no hay problema. No hay contenido. No se traduce nada.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 9, 2020

Copy link
Copy Markdown
Member

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dbritto-dev

dbritto-dev commented Oct 9, 2020

Copy link
Copy Markdown
Contributor Author

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

La verdad no te entendi nada jaja y no creo que tenga que ver con pensar como programador o no.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 9, 2020

Copy link
Copy Markdown
Member

era solo una curiosidad, de por qué agregar solution vacio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax reviewed Oct 9, 2020
View reviewed changes
Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@dbritto-dev
WIP
5505fec
@dbritto-dev
dbritto-dev force-pushed the styles-classes branch from 66f9495 to 5505fec Compare October 12, 2020 17:16
dbritto-dev added 7 commits October 12, 2020 13:14
@dbritto-dev
WIP
bd4b67a
@dbritto-dev
WIP
557466d
@dbritto-dev
WIP
dbb4233
@dbritto-dev
WIP
cd18376
@dbritto-dev
WIP
07af51a
@dbritto-dev
WIP
833c318
@dbritto-dev
Minor changes
4aaafbf
@dbritto-dev
dbritto-dev marked this pull request as ready for review October 17, 2020 18:34
joaquinelio
joaquinelio requested changes Oct 17, 2020
View reviewed changes
Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Oct 17, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 17, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Oct 17, 2020
dbritto-dev and others added 5 commits October 17, 2020 17:18
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
1910164
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
a6bce5b
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
5bae251
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
68bfee0
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
5516205
Co-authored-by: joaquinelio <[email protected]>
dbritto-dev and others added 5 commits October 17, 2020 17:19
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
da858fa
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
d3f7554
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
4394f5b
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
1409fae
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
b335cf5
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev

dbritto-dev commented Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Oct 17, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 17, 2020 22:20
joaquinelio
joaquinelio requested changes Oct 18, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se me escapó una.
Dos.
Creo que es todo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Oct 18, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 18, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Oct 18, 2020
dbritto-dev and others added 2 commits October 18, 2020 08:31
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
0022411
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev @joaquinelio
Update 2-ui/1-document/08-styles-and-classes/article.md
e2cc988
Co-authored-by: joaquinelio <[email protected]>
@dbritto-dev

dbritto-dev commented Oct 18, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Oct 18, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 18, 2020 13:31
joaquinelio
joaquinelio approved these changes Oct 19, 2020
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Oct 19, 2020
vplentinax
vplentinax approved these changes Oct 19, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vplentinax vplentinax added ready to merge and removed needs +1 labels Oct 19, 2020
@joaquinelio
joaquinelio merged commit 9eb6aa8 into javascript-tutorial:master Oct 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 20, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 20, 2020

Copy link
Copy Markdown
Member

@vplentinax @danilobrinu

Me canse de hacer pr y me permiti hacer un commit directo, pero aviso.

task estaba traducida, faltaba una linea
"the options are" a "Las opciones son"
La solucion esta vacia porque solo funciona en nueva pagina o plnkr
y funciona nicely

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dbritto-dev @vplentinax @joaquinelio @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.