GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Node properties: type, tag and contents by homero304 · Pull Request #422 · javascript-tutorial/es.javascript.info

Conversation

@homero304

@homero304 homero304 commented Oct 12, 2020

Copy link
Copy Markdown
Contributor

please review my PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@omero329
Node properties: type, tag and contents
7c9c530
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 12, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 12, 2020 00:22
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 12, 2020
Spanish Translation Progress #17
Open
@omero329
Merge branch 'master' into Node-properties_type-tag-and-contents
07d71cc
joaquinelio
joaquinelio requested changes Oct 12, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correcciones y divagues...

y sorry si algun coment parece agresivo no lo es, solo estoy jugando.
es que nunca antes en mi vida usé bugs, era perfecto
y en las ultimas sync puse dos y todavia no me recupero del shock.

Ah, creo que hay correctores automaticos metiendo el rabo
bad Homer..!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 2-ui/1-document/05-basic-dom-node-properties/2-tree-info/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/3-tag-in-comment/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/4-where-document-in-hierarchy/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/4-where-document-in-hierarchy/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/4-where-document-in-hierarchy/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/05-basic-dom-node-properties/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Oct 12, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

omero329 and others added 11 commits October 12, 2020 06:31
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/2-tree-info/solut…
b7db859
…ion.md

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/3-tag-in-comment/…
ce97b25
…solution.md

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/4-where-document-…
79e0683
…in-hierarchy/solution.md

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/4-where-document-…
5077fca
…in-hierarchy/solution.md

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/4-where-document-…
10b54a5
…in-hierarchy/task.md

Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
872e7f4
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
8e92100
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
8c3fb5b
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
79a79be
Co-authored-by: joaquinelio <[email protected]>
@omero329
Winnie-pooh
b54440b
@omero329
Merge branch 'Node-properties_type-tag-and-contents' of https://githu…
c313b2c
…b.com/homero304/es.javascript.info into Node-properties_type-tag-and-contents
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Oct 12, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 12, 2020 11:42
omero329 and others added 7 commits October 12, 2020 06:42
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
dc34f25
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
b7fd044
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
ed04f67
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
3be53c7
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
c040d70
Co-authored-by: joaquinelio <[email protected]>
@omero329 @joaquinelio
Update 2-ui/1-document/05-basic-dom-node-properties/article.md
2a3803b
Co-authored-by: joaquinelio <[email protected]>
@omero329
integrada -> nativa
e79bc49
@omero329
Merge branch 'Node-properties_type-tag-and-contents' of https://githu…
0c5fede
…b.com/homero304/es.javascript.info into Node-properties_type-tag-and-contents
@homero304

homero304 commented Oct 12, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

ah,
lo de "built in" era solo un comentario

"incorporada" es lo que usamos hasta ahora, seria "correcto" aunque en mi opinion muy facil de malinterpretar, las bibliotecas de 3ros tambien "incorporan" funciones
"integrada" me gustaba un poco más, no se por qué, me da idea de que ya esta ahi, no incorporado posteriormente en una biblioteca extra... "built-in" ="integrada" me gusta. No recuerdo ssi ses uso asi en algun lado.
"nativa" me parecia perfecta pero no lo habiamos ussado antes, y no lo discutimos antes, para mi esta bien, no lo habia sugerido porque podria haber desacuerdos,
Acepto cualquier version, pero no se los demás.

winnie pooh
jaj el comment que hice era por la mayuscula, en realidad si el codigo es coherente no me importaba. Sigue ok.
no se por que me pongo a hacer esos comentarios...
sorry

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio
joaquinelio approved these changes Oct 12, 2020
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Oct 12, 2020
vplentinax
vplentinax approved these changes Oct 14, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vplentinax vplentinax added ready to merge and removed needs +1 labels Oct 14, 2020
@joaquinelio
joaquinelio merged commit ead3c54 into javascript-tutorial:master Oct 15, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 15, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vplentinax
🎉🎉🎉🎉🎉
Si sos el 2do ok, podes hacer merge sin esperarme,
salvo que no tengas tiempo de revisar online, ya cometi el error de no revisar bien, dejamelo es una satisfacción.
*El mensaje de idioma sigue saliendo, no problem, al tiempo deja de salir.
*Tambien tarda un poco más mostrar el índice español que la página. El índice ES el titulo de la pagina, asi que solo es esperar nosequé.
*Siempre revisar FORMATO no se ven los err de formato dentro de git
*Imagenes
*Las soluciones, que abran, ves enseguida si falta traduccion, y TAMBIEN he visto fallas de formato dentro
*Los links, suelo buscarlos y abrirloss con el boton del medio asi reviso todos juntos, internos y externos
-Los sandbox... culpable, demora mucho en abrir plunker y a veces son muchos...
*Que salga el msg del bot del issue17, para actualizar a mano si no lo ve por algo.

Y ESTE PR se vio perfecto
¡¡¡¡ Faltan 25 !!!!
🎉🎉🎉🎉🎉

vplentinax reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@homero304 @javascript-translate-bot @joaquinelio @vplentinax @omero329
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.