GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Sticky flag "y", searching at position by AbiF73 · Pull Request #424 · javascript-tutorial/es.javascript.info

Conversation

AbiF73 commented Oct 15, 2020

Copy link

Copy Markdown

Contributor

Hola! Tuve algunas dudas con algunas palabras, lo siento. Espero sus correcciones.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update article.md

fe37032

javascript-translate-bot added the review needed label

Oct 15, 2020

javascript-translate-bot requested a review from a team

October 15, 2020 20:43

CLAassistant commented Oct 15, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Oct 15, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bienvenido
y bienvenido si continuas

Sabes de git ? veo que modificaste tu master
No nos afecta en el pr, pero lo mejor para trabajar en tu fork es
dejar el master intocable (solo actualizar desde nuestro fork)
generar en un branch y modificar alli
una vez hecho el pr y añadido al nuestro repo, puedes borrar el branch
y actualizar tu master desde nuestro remoto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md

		We can get all matches in the loop:
		Podemos conseguir todas las coincidencias en el loop:

		```js run

joaquinelio Oct 15, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Podrias traducir comentarios lineas 63 64 ?
github no me deja sugerir ahi (dentro de un bloque sin traducir)

Quizas tambien la 62 pero con cuidado:

alert( Se encontró ${result[0]} en la posición ${result.index} );

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/16-regexp-sticky/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Oct 15, 2020

javascript-translate-bot commented Oct 15, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 15, 2020

joaquinelio changed the title ~~Update article.md~~ Sticky flag "y", searching at position

Oct 15, 2020

joaquinelio commented Oct 15, 2020

Copy link

Copy Markdown

Member

ah, para llevar el control (y Don Bot lo entienda)
cambié el nombre al PR

Sticky flag "y", searching at position

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Oct 15, 2020

Copy link

Copy Markdown

Member

AAAHHHHHHH!!!!

Ilya marcó la version en ingles como WIP
el crazy va a rescribirlo todo!!!!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio mentioned this pull request

Oct 15, 2020

Spanish Translation Progress #17

Open

vplentinax commented Oct 25, 2020

Copy link

Copy Markdown

Contributor

Después que se acepten las sugerencias de Joaquinelio, paso yo a revisar.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax self-requested a review

October 25, 2020 16:08

joaquinelio commented Oct 25, 2020

Copy link

Copy Markdown

Member

Después que se acepten las sugerencias de Joaquinelio, paso yo a revisar.

@vplentinax
El pr es de hace 10 dias, las suggest son de hace 10 dias...

Encima Ilya lo rescribió dos dias después.
Aun no se si hacer sync (ingles-ingles, seria directo) y que este quede con conflictos multiples
o esperar al merge de esto e descartar la nueva version para verla tranquilo

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Oct 26, 2020

Copy link

Copy Markdown

Contributor

@joaquinelio Hazlo como te parezca más cómodo a ti. No tengo inconveniente con ninguna de las dos formas.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'master' into master

9f85695

joaquinelio commented Nov 20, 2020

Copy link

Copy Markdown

Member

@vplentinax
Este es un art breve
El ingles fue reescrito o rescrito, (en repo esp deje version vieja para que esto no diera conflictos)
podriamos descartar esto y hacerlo de cero

por otro lado,
corrigiendo ortografia le daria MERGE,
es un art muy facil de entender
e Ilya hizo mucho cambio no dire superfluo pero...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio mentioned this pull request

Dec 4, 2020

Actualizar: 9-16 regexp-sticky article -- Revisar. Reescrito en inglés #440

Closed

vplentinax and others added 9 commits

December 17, 2020 13:14


          Update 9-regular-expressions/16-regexp-sticky/article.md

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

b576771

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

12bf852

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

75a942e

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

06bd468

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

8f9d5dd

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

38d3506

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

041b2e4

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/16-regexp-sticky/article.md

9e57705

Co-authored-by: joaquinelio <[email protected]>

vplentinax approved these changes

Dec 17, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the changes requested label

Dec 17, 2020

javascript-translate-bot added the needs +1 label

Dec 17, 2020

joaquinelio merged commit 5944323 into javascript-tutorial:master

Dec 17, 2020

javascript-translate-bot commented Dec 17, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio requested changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AbiF73 commented Oct 15, 2020

Uh oh!

CLAassistant commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaquinelio Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 15, 2020

Uh oh!

joaquinelio commented Oct 15, 2020

Uh oh!

joaquinelio commented Oct 15, 2020

Uh oh!

vplentinax commented Oct 25, 2020

Uh oh!

joaquinelio commented Oct 25, 2020

Uh oh!

vplentinax commented Oct 26, 2020

Uh oh!

joaquinelio commented Nov 20, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Dec 17, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Oct 15, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.