GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Shadow DOM styling by MoisesTR · Pull Request #426 · javascript-tutorial/es.javascript.info

Conversation

@MoisesTR

@MoisesTR MoisesTR commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Agregar documentación en español del articulo Shadow DOM styling

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MoisesTR
Shadow DOM styling
0936bd5
Agregar documentación en español del articulo Shadow DOM styling
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 19, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 19, 2020 00:50
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 19, 2020
Spanish Translation Progress #17
Open
joaquinelio
joaquinelio requested changes Oct 19, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambios menores y...
Tengo demasiadas dudas de concepto, si hay reviewers con mejor background plis...

Indecisiones que comparto:

to style --> diseñar

No hice suggest, es correcto pero quizas sea mejor ser mas explicito
"aplicar/dar estilo"

slot / slotted

slot/slotted es htm/css y no se traducen...
Pero no creo que debamos usar slotted como si fuera participio español

ideas, bienvenidas, estoy convencido de que conviene modificarlo,
pero entrecomillarlo cada vez parece demasiado.

ideas discutibles, ej:

  • Estilo de contenido "slotted"
    entre comillas para que se lea naturalmente como una etiqueta, no como si estuviera conjugando porque si no habría que traducirlo: "elementos sloteados/emplazados" que queda espantoso.

  • situación con los slots.
    como nombre singular/plural no veo problema

  • , slotted <span> está en bold,
    no esta usando atributo , está conjugando slots y sin traducir no se lee natural.
    Sugiero "el slot <span> esta en bold". Parece mas evidente el uso <slot>/"slot=" que slotted, slotted aca no lo usa como pseudoclase
    Es como si dijeramos "elementos italizados / en itálica"

igualmente en las suggest fui mas conservador.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Oct 19, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 19, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Oct 19, 2020
MoisesTR and others added 5 commits October 19, 2020 20:42
@MoisesTR @joaquinelio
Update 8-web-components/6-shadow-dom-style/article.md
a46c986
Co-authored-by: joaquinelio <[email protected]>
@MoisesTR @joaquinelio
Update 8-web-components/6-shadow-dom-style/article.md
82e9d90
Co-authored-by: joaquinelio <[email protected]>
@MoisesTR @joaquinelio
Update 8-web-components/6-shadow-dom-style/article.md
e376857
Co-authored-by: joaquinelio <[email protected]>
@MoisesTR @joaquinelio
Update 8-web-components/6-shadow-dom-style/article.md
b83a67a
Co-authored-by: joaquinelio <[email protected]>
@MoisesTR @joaquinelio
Update 8-web-components/6-shadow-dom-style/article.md
8e2c408
Co-authored-by: joaquinelio <[email protected]>
@joaquinelio

joaquinelio commented Oct 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Hay palabras que es mejor dejarlas en ingles, si la traducimos confundira mas a los lectores y no podran buscar el concepto especifico de slotted o slot.

Estamos de acuerdo pero no todos piensan asi,
quise aplicar eso con los wrappers y no tuve exito.

este caso es más claro que SLOT y SLOTTED no se traducen,
pero el objetivo es que el texto tenga sentido, es lo que me molesta acá

"Por ejemplo, slotted <span> está en bold" -es-sucio-gramatica- ,yo Tarzán, dificulta la lectura, no tiene sentio.

Lo que no tengo es alternativa, porque no tengo suficiente concepto para jugar al equilibrio.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoisesTR
Update article.md
39f0fbf
@MoisesTR

MoisesTR commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

Hay palabras que es mejor dejarlas en ingles, si la traducimos confundira mas a los lectores y no podran buscar el concepto especifico de slotted o slot.

Estamos de acuerdo pero no todos piensan asi,
quise aplicar eso con los wrappers y no tuve exito.

este caso es más claro que SLOT y SLOTTED no se traducen,
pero el objetivo es que el texto tenga sentido, es lo que me molesta acá

"Por ejemplo, slotted <span> está en bold" -es-sucio-gramatica- ,yo Tarzán, dificulta la lectura, no tiene sentio.

Lo que no tengo es alternativa, porque no tengo suficiente concepto para jugar al equilibrio.

Slot lo deje tal cual
Slotted utilice la palabra eslotado
Cuando un elemento ha sido insertado en un slot, se dice que fue eslotado https://developer.mozilla.org/es/docs/Web/Web_Components/Using_templates_and_slots

Y segun la documentación en ingles de MDN:
The ::slotted() CSS pseudo-element represents any element that has been placed into a slot inside an HTML template
https://developer.mozilla.org/en-US/docs/Web/CSS/::slotted

Respecto a outer document, outer tiene muchos significados en ingles, pero segun el contexto y en base al ejemplo que esta en el articulo en la parte de CSS hooks con propiedades personalizadas, refiere a al documento mas exterior o el que esta mas arriba en la jerarquia del DOM, fijate en el ejemplo completo y veras a que me refiero.

Al final outer document lo traduje como documento exterior, si tienes una mejor traducción es bienvenida!

Hice algunos cambios en la traducción, cuando puedas lo revisas.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No miré MDN porque muchas son inacabadas, para mi es una ayuda no referencia
eslotado...
se me ocurrió, pero es horrible
en MDN dice "eslotado por su term ing slotted"
y me gustaria ser asi de discreto

Disculpa no ayudé por falta de background acá,
la idea era usar las palabras en ingles pero envueltas en gramatica española, que el cerebro se acostumbre al termino y lo identifique como una etiqueta pero me quedó demasiado rebuscado.

La gramatica
"el slotted elemento" no es española
"el elemento slotted" se entiende mal
"el elemento establecido como slotted" o algo asi era mi idea pero es demaiado largo...
"el elemento eslotado" si... pero no me atrevia a españolizarlo asi. Aunque MDN nos indulta, jaja Pero DEBE estar definido slotted en su primera aparicion, como en MDN

Suelo pelear más cuando creo que hay un error de concepto,
en este tema el que tambalea soy yo, y si sigo tratando de ayudar es por la falta de reviewers...

veamos...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio
joaquinelio requested changes Oct 21, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Con la comas trato de seguir las normas
pero si no me sé explicar y no afectan el concepto no insisto

Creo que mejoró, entendí un poco más.
lo de exterior todavia me molesta

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot

javascript-translate-bot commented Oct 21, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 21, 2020

Copy link
Copy Markdown
Member

¡Estaba pensando en inglés!

Documento exterior es definitivamente un documento que está afuera,
Exterior del documento se malentenderia como afuera del documento en su primera acepcion
No es lo mismo que out-er que puede ser "de frontera"

El problema es que no encuentro una estructura SIMPLE válida "parte exterior del documento" (DEL doc, no fuera)
¿qué tan importante lo consideras para la comprension del articulo?
yo estoy viejo y perezoso, no segui los ejemplos bien asi que no cuento.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 21, 2020

Copy link
Copy Markdown
Member

bah,
arreglame los acentos y los signos de apertura y apruebo

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoisesTR
Update article.md
40597d2
@MoisesTR

MoisesTR commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Oct 22, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 22, 2020 05:08
@joaquinelio

joaquinelio commented Oct 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Me encanta el articulo

De acuerdo con la solucion "slotted", un buen compromiso

outer doc: las dudas que hubiere son resueltas en cuanto te metes en el codigo.

Tengo algunas objeciones gramaticales (que no son regionalismos) pero el concepto (que recien empece a arañar parece que está muy bien, prefiero este articulo online a no tenerlo
-y que se arregle el segundo reviewer- =)

Por lo menos solucioname la linea 245, los signos deben cerrar simetricamente
podes ponerlo donde lo sugeri,
podes ponerlo antes de "pero"
podes quitar el de cierre, (enunciado interrogativo) "Pero cómo hacer una buena tortilla".
plis

MoisesTR reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoisesTR
Update article.md
e86a421
@MoisesTR

MoisesTR commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

Me encanta el articulo

De acuerdo con la solucion "slotted", un buen compromiso

outer doc: las dudas que hubiere son resueltas en cuanto te metes en el codigo.

Tengo algunas objeciones gramaticales (que no son regionalismos) pero el concepto (que recien empece a arañar parece que está muy bien, prefiero este articulo online a no tenerlo
-y que se arregle el segundo reviewer- =)

Por lo menos solucioname la linea 245, los signos deben cerrar simetricamente
podes ponerlo donde lo sugeri,
podes ponerlo antes de "pero"
podes quitar el de cierre, (enunciado interrogativo) "Pero cómo hacer una buena tortilla".
plis

Listo, ya lo corregi, se me habia escapado eso tambien jaja

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoisesTR

MoisesTR commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoisesTR
Update article.md
7d4fb40
@MoisesTR

MoisesTR commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

Con la comas trato de seguir las normas
pero si no me sé explicar y no afectan el concepto no insisto

Creo que mejoró, entendí un poco más.
lo de exterior todavia me molesta

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoisesTR

MoisesTR commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

Por alguna razón me sigue diciendo que falta un cambio requerido, pero ya revise y ya aplique todo, me podrias ayudar en est aparte @joaquinelio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax approved these changes Oct 25, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un acento que no ví y me resultó raro de leer. Creo que "el" en este caso es más pronombre que artículo. De resto me gustó la traducción.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoisesTR reacted with hooray emoji
All reactions
  • 🎉 1 reaction
Comment thread 8-web-components/6-shadow-dom-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Oct 25, 2020
joaquinelio
joaquinelio approved these changes Oct 25, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@joaquinelio

joaquinelio commented Oct 25, 2020

Copy link
Copy Markdown
Member

https://youtu.be/bTRT_EZtj9w

jeje

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
joaquinelio merged commit b0a578c into javascript-tutorial:master Oct 25, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 25, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@MoisesTR @javascript-translate-bot @joaquinelio @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.