GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Element size and scrolling by lgabrielvleon · Pull Request #433 · javascript-tutorial/es.javascript.info

Conversation

lgabrielvleon commented Oct 22, 2020

Copy link

Copy Markdown

Contributor

Traducción del capítulo Element size and scrolling

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

lgabrielvleon added 14 commits

October 19, 2020 21:20


          Update solution.md

18a2e99


          Update task.md

ba5c94e


          Update solution.md

5226df4


          Update task.md

9c9b64f


          Update solution.md

ca42219


          Update task.md

466734d


          Update solution.md


          Update task.md

2e0bd7c


          Update index.html

086ae04


          Update article.md

db46b72


          Update article.md

6439b88


          Update article.md

2b32f2b


          Update article.md

cf550f5


          Update article.md

3763bb4

javascript-translate-bot added the review needed label

Oct 22, 2020

javascript-translate-bot requested a review from a team

October 22, 2020 02:26

CLAassistant commented Oct 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio mentioned this pull request

Oct 22, 2020

Spanish Translation Progress #17

Open

joaquinelio changed the title ~~Lgabrielvleon patch 1 - Element size and scrolling~~ Element size and scrolling

Oct 22, 2020

joaquinelio commented Oct 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Corregido nombre pr / issue17 pa'que Bot lo entienda

MERGE: !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Tiene 4 tasks y mucho formato anidado,
verificar online como quedan, imposible probarlo debtro del hub

Listo, cuando se me pase la pereza lo reviso.
Hasta mañana zzzz

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio self-requested a review

October 22, 2020 12:31

vplentinax requested review from vplentinax and removed request for a team

October 25, 2020 17:01


          alineando

b5522eb

joaquinelio requested changes

Oct 26, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varias cosas...
suelo re-revisar mi revision pero me estoy durmiendo

creo que edite el archivo para cambiar numeracion, si no fue en otro

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Oct 26, 2020

javascript-translate-bot commented Oct 26, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lgabrielvleon and others added 2 commits

October 25, 2020 19:13


          Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/task.md

3a695f6

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/1-get-scroll-height-bottom/…

ad78fbb

…task.md

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md

b63c3a4

Co-authored-by: joaquinelio <[email protected]>

lgabrielvleon commented

Oct 26, 2020

View reviewed changes

lgabrielvleon left a comment

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lgabrielvleon and others added 2 commits

October 25, 2020 19:24


          Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solu…

0f2480e

…tion.md

Co-authored-by: joaquinelio <[email protected]>


          Update solution.md

980057b

joaquinelio requested changes

Oct 26, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que hoy tengo los ojos más limpios, encontré varios acentos faltantes...

Y vi que hay correcciones de tilde no aplicadas. Puedo dejarme convencer en css, pero con los acentos estoy bastante convencido...

Lo importante es que el texto se lee bien, lo prefiero online-

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/1-document/09-size-and-scroll/2-scrollbar-width/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/1-document/09-size-and-scroll/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Oct 26, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Nov 20, 2020

Copy link

Copy Markdown

Member

@vplentinax
podes hacer lo mismo aqui?
este pr es completo, fue revisado, lo corrigio,
más revision y asi quedó

Tuvo ya mucho trabajo hecho, si te parece revisa y revisa mi revision,
es una buena adicion al repo

vplentinax reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 16 commits

December 17, 2020 12:56


          Update 2-ui/1-document/09-size-and-scroll/2-scrollbar-width/solution.md

f7ff985

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/2-scrollbar-width/task.md

ddb54ac

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md

00ed4fc

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/4-put-ball-in-center/task.md

9d315d0

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/solu…

8012f83

…tion.md

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/6-width-vs-clientwidth/task.md

62bca3f

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

cd7e165

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

9970a93

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

29120e2

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

25f7874

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

601704f

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

4e51234

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

41d06ed

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

d5be71f

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/1-document/09-size-and-scroll/article.md

08f1899

Co-authored-by: joaquinelio <[email protected]>

vplentinax approved these changes

Dec 17, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien. Avancemos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed changes requested labels

Dec 17, 2020

vplentinax added ready to merge and removed needs +1 labels

Dec 17, 2020

joaquinelio merged commit bf393d0 into javascript-tutorial:master

Dec 17, 2020

javascript-translate-bot commented Dec 17, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio requested changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

lgabrielvleon commented Oct 22, 2020

Uh oh!

CLAassistant commented Oct 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio commented Oct 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 26, 2020

Uh oh!

lgabrielvleon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 26, 2020

Uh oh!

joaquinelio commented Nov 20, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Dec 17, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Oct 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Oct 22, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.