GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fetch by carlosabud · Pull Request #435 · javascript-tutorial/es.javascript.info

Conversation

@carlosabud

@carlosabud carlosabud commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
carlosabud added 2 commits October 25, 2020 15:09
@carlosabud
Merge pull request #1 from javascript-tutorial/master
8a9179f
merge from repo
@carlosabud
Article translation
136de82
fetch article
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 25, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 25, 2020 19:05
@CLAassistant

CLAassistant commented Oct 25, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 25, 2020

Copy link
Copy Markdown
Member

Hola
Todavia no lo revise pero te aviso que tiene ejercicios

uno ejercicio solo. en tu branch
https://github.com/carlosabud/es.javascript.info/tree/master/5-network/01-fetch/01-fetch-users
task.md y solution.md

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 4 commits October 25, 2020 19:08
@joaquinelio
desalineado
67a3e6f
@joaquinelio
alinedo II
9f3605e
@joaquinelio
alineado III
8f9776b
@joaquinelio
alineado IV
72a0e11
joaquinelio
joaquinelio requested changes Oct 25, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Varios acentos, si no usas las suggest acordate de ponerlos
  • Recordar que faltan task y solution
  • Me permití corregir los nros de linea
    necesitamos que coincidan con el inglés para poder hacer bien los pull
  • Cambie nombre para que Don Bot lo reconozca, agregué el pr que Don Bot no reconoció al issue17

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Oct 25, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 25, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio joaquinelio mentioned this pull request Oct 25, 2020
Spanish Translation Progress #17
Open
@joaquinelio joaquinelio changed the title Traducción articulo Fetch Fetch Oct 25, 2020
carlosabud added 7 commits October 25, 2020 23:15
@carlosabud
code review + spellcheck
13e16fa
@carlosabud
Update task.md
0ac904a
@carlosabud
Update solution.md
e0e6e8d
@carlosabud
Update source.js
971a9c5
@carlosabud
Update source.js
a05a29e
@carlosabud
Update source.js
fa2e87a
@carlosabud
Update solution.js
5db5c01
@carlosabud

carlosabud commented Oct 26, 2020

Copy link
Copy Markdown
Contributor Author

Buenas Joaquin, ahí realicé un par de actualizaciones tomando tus sugerencias.

Cualquier cosa avisame

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 26, 2020

Copy link
Copy Markdown
Member

Uh
Debí advertirte, no traducimos código, puede salir mal.
Y no lo podemos probar acá.
(Pero los devs somos perfectos y no cometemos errores, para qué probar)

Se traducen solamente // comentarios /* */
y usualmente mensajes entrecomillados (con cuidado los backticks) pero no los string que participan de codigo

salvo eso, el article creo que ya está, task y solution estan bien...
¿podrias poner codigo sin traducir?

carlosabud reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carlosabud added 2 commits October 26, 2020 14:09
@carlosabud
Update task.md
0adbb54
@carlosabud
Update solution.md
f9a4eaa
@carlosabud

carlosabud commented Oct 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@joaquinelio Creo que ahí estamos. Avisame!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlosabud
carlosabud requested a review from joaquinelio October 26, 2020 20:09
joaquinelio
joaquinelio requested changes Oct 26, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qudó un js
5-network/01-fetch/01-fetch-users/_js.view/solution.js
lo más seguro es poner el original entero,

al otro js le copie la linea vieja,
5-network/01-fetch/01-fetch-users/_js.view/source.js
por lo menos el comentario quedo traducido... =)

Estaba tentado a dejarlo asi, probarlo localmente
el problema es que a veces hacen cambios de codigo y el pull es directo
es posible por ej que agreguen una linea usando la variable ingles y nadie se de cuenta de que el codigo se malogro

Mas par de cositas,

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carlosabud reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 5-network/01-fetch/01-fetch-users/_js.view/source.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/01-fetch-users/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 5-network/01-fetch/01-fetch-users/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot

javascript-translate-bot commented Oct 26, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carlosabud and others added 4 commits October 26, 2020 22:55
@carlosabud @joaquinelio
Update 5-network/01-fetch/01-fetch-users/solution.md
03baafa
Co-authored-by: joaquinelio <[email protected]>
@carlosabud @joaquinelio
Update 5-network/01-fetch/01-fetch-users/solution.md
7240e96
Co-authored-by: joaquinelio <[email protected]>
@carlosabud
Update solution.js
cb28605
@carlosabud
Update source.js
ca31ef1
@carlosabud

carlosabud commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

Listo. Perdón por las idas y vueltas.

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Oct 27, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 27, 2020 02:00
joaquinelio
joaquinelio approved these changes Oct 27, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Oct 27, 2020
@carlosabud

carlosabud commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

@joaquinelio por las dudas, no me deja completar el PR. Supongo que hará falta que otra persona con permisos revise el PR y lo complete. Saludos!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Oct 27, 2020

Copy link
Copy Markdown
Member

Sí, solo maintainers pueden continuarlo.

  • El branch y el PR son tuyos, podes hacer y deshacer.
  • merge dentro del repo solo la puede hacer alguien con permisos,
  • la aprobación es cuestion de procedimiento, lo esperable es que dos personas aprueben y el bot de Ilya responde cambiando los cartelitos.
  • Vos podrias hacer review y aprobar el PR de otra persona, y aunque el BOT te ignore, el maintainter no
    (especialmente por la escasez de reviewers)

Ja, deberia poner esto en el curso de git filosofico
para complementar cualquier curso de comandos git

carlosabud reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax approved these changes Oct 30, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vplentinax vplentinax added ready to merge and removed needs +1 labels Oct 30, 2020
@joaquinelio
joaquinelio merged commit a766c14 into javascript-tutorial:master Oct 30, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 30, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes
@vplentinax vplentinax vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@carlosabud @CLAassistant @joaquinelio @javascript-translate-bot @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.