GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Proxy and Reflect by joaquinelio · Pull Request #451 · javascript-tutorial/es.javascript.info

Conversation

@joaquinelio

@joaquinelio joaquinelio commented Nov 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Finally!
1033 lineas
ok, la mitad vacias, la mitad de mitad codigo
pero es el mas largo y complejo del repo

  1. use trampa para trap, algo incomodo, pero es la trampa de osos que atrapa operaciones, ¿que otra cosa podia poner?
    podia dejar TRAP, todo el mundo la entiende

  2. El articulo original es excelente, pero deberia mejorar la granatuca y hacerla mas suave
    Fui muy liberal en la traduccion no técnica
    tambien extendi algunas cosas

  3. Linea 966, le corte un pedazo porque estaba mal.
    se podia arreglar dejandola y agregando algo como "no en el caso de ejemplo porque...",
    o agragando una linea al codigo de ejemplo.
    cuando lo resuelva Ilya, lo arreglamos aca, sera un sync como tantos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@joaquinelio
Proxy and Reflect
addaf6c
@javascript-translate-bot javascript-translate-bot added the review needed label Nov 27, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team November 27, 2020 03:37
@javascript-translate-bot

javascript-translate-bot commented Nov 27, 2020

Copy link
Copy Markdown

Error: the article has another translator @maksumi in the Progress Issue #17.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Nov 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I know, Mr Bot.
But I dont care.
I stoled it.

wtf I've stolen it

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio joaquinelio mentioned this pull request Nov 29, 2020
Spanish Translation Progress #17
Open
@vplentinax

vplentinax commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Me lo pienso para comenzar esta revisión... Pronto lo haré

joaquinelio reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Dec 14, 2020

Copy link
Copy Markdown
Member Author

Me lo pienso para comenzar esta revisión... Pronto lo haré

podes hacerla en comodas cuotas...

pero si podes dar algo de tiempo, la sync es siempre prioridad
Y las mantengo pequeñas para minimizar conflicto, no deberia llevar mucho tiempo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax requested changes Dec 18, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revision de tareas y del articulo hasta la línea 200.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/99-js-misc/01-proxy/03-observable/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/03-observable/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Dec 18, 2020
@javascript-translate-bot

javascript-translate-bot commented Dec 18, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Dec 18, 2020
@joaquinelio @vplentinax
Apply suggestions from @vplentinax
ea422f6
Co-authored-by: ᐯᑭᒪEᑎTIᑎᗩ᙭ ᐯᑭ <[email protected]>
@joaquinelio

joaquinelio commented Dec 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@vplentinax

No comprendo muy bien la frase, ¿podría mejorarse?

` 181
// casi original
El proxy debe reemplazar totalmente el objeto target en todo lugar. Nadie debe jamás hacer referencia al objeto target después de haberlo hecho el proxy. De otro modo sería fácil manipularlo.

    //¿puedo apartarme del original y repasar lo que es la envoltura (wrapper) ? 

// 1ra verion sobreexplicada
El proxy debe reemplazar completamente al objeto "target" que envolvió . El proxy debe supervisar o reemplazar todas sus operaciones: nadie debe jamás hacer referencia al objeto target saltando tal envoltura. De otro modo sería fácil desbaratarlo.

// creo que quedo bien simplificado y contundente
El proxy debe reemplazar completamente al objeto "target" que envolvió: nadie debe jamás hacer referencia al objeto target saltando tal envoltura. De otro modo sería fácil desbaratarlo.

`
¿ s entiende ?
tu dirás...

TLDR
si otro programador usa "target" sin el proxy, el estado del proxy puede romperse, a eso se refiere con
klo que aca me comí " y en todo lugar", ligado a "nadie debe acceder", ¿puedo considerar que se sobrentiende?
me parecio mas claro sin aclarar...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
reformulacion 181 "proxy vs target"
67c1298
vplentinax
vplentinax requested changes Dec 23, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisón hasta la línea 592. Ya vamos por la mitad. Realmente está muy bien, pocas cosas que arreglar.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot

javascript-translate-bot commented Dec 23, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax reviewed Dec 23, 2020
View reviewed changes

@vplentinax vplentinax left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gustó, me parece más claro. Me refiero a lo que arreglaste en reformulacion 181 "proxy vs target" @joaquinelio

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
joaquinelio and others added 2 commits December 23, 2020 20:48
@joaquinelio @vplentinax
Apply suggestions II from @vplentinax
ad6aa67
Co-authored-by: ᐯᑭᒪEᑎTIᑎᗩ᙭ ᐯᑭ <[email protected]>
@joaquinelio
Legibilidad linea 328
b6f76cb
@joaquinelio

joaquinelio commented Dec 23, 2020

Copy link
Copy Markdown
Member Author

@vplentinax
Reescribí linea 328 que seguia confusa.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax
vplentinax approved these changes Jan 17, 2021
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas, una vez aceptadas puedes hacer merge!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/01-proxy/article.md Outdated
Algo similar ocurre con los "campos privados" usados en las clases.

For example, `getName()` method accesses the private `#name` property and breaks after proxying:
Por ejemplo, el método `getName()` accede a la propiedad privada `#name` y falla por hacerlo proxy:

@vplentinax vplentinax Jan 17, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Por ejemplo, el método `getName()` accede a la propiedad privada `#name` y falla por hacerlo proxy:
Por ejemplo, el método `getName()` accede a la propiedad privada `#name` y se interrumpe después del proxy:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@joaquinelio joaquinelio Jan 17, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, no se interrumpe, falla, porque no encuentra la variable.

Y no "después del proxy" en todo caso sería "después de convertirlo a proxy"
pero puse "POR" porque la falla es consecuencia de convertirlo.
Falla, por haberlo convertido en proxy.

No enconctré forma comoda de traducir el ubicuo "proxing" que traduje como "hacerlo proxy"
¡ proxificar ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@joaquinelio joaquinelio Jan 17, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un problema que no vi de poner "hacerlo proxy" es q parece que convirtiera al metodo,
deberia aclarar que convierto el objeto entero o escribirlo mas vagamente

"...falla despues de hacer el proxy"
"...falla despues de la conversión a proxy"
"...falla depués de la proxificación. "

no me parece nada mal la idea. Es muy comodo tener la palabra proxificar.

tamb puedo sobreaclarar
"...falla depués de la proxificación del objeto user. "

@vplentinax , pienso poner
"...falla depués de la proxificación. "
¿que tal?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/99-js-misc/01-proxy/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Jan 17, 2021
joaquinelio and others added 5 commits January 17, 2021 16:59
@joaquinelio @vplentinax
Update 1-js/99-js-misc/01-proxy/article.md
53c5dde
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio @vplentinax
Update 1-js/99-js-misc/01-proxy/article.md
d82a677
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio @vplentinax
Update 1-js/99-js-misc/01-proxy/article.md
06f2d20
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio
Merge branch 'master' into leproso
eec9603
@joaquinelio
Update article.md
20575b7
@joaquinelio

joaquinelio commented Jan 18, 2021

Copy link
Copy Markdown
Member Author

Novedades

-Acepté (alguno de mala gana :P ) tus cambios.
-Menos uno que rechazo porque le erra (o yerra) al concepto, pero deje comentada una versión alternativa que creo mejor.
-También hubo 3 conflictos que acabo de resolver y podrias revisar. La mejora de Ilya es buena, mejor la explicacion y alternativas de manejo del metodo "revoke". lineas 966-972 (o podes cliquear los commits para ver las idas y venidas...)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 2 commits January 24, 2021 23:24
@joaquinelio
Update article.md
fddf3b0
@joaquinelio
fix link a mdn proxy no func c/ [ ](mdn:)
5d16607
@joaquinelio

joaquinelio commented Jan 25, 2021

Copy link
Copy Markdown
Member Author

Acepte todas las sug excepto linea 845 porque era un error conceptual que no puedo aceptar.

Es el unico articulo que falta de la seccion Js,
es el más largo de todo el repo,
el PR ya cumplio dos meses,

y la demora genera conflictos que tengo que andar resolviendo

El art es bueno, vale la pena el merge

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
joaquinelio merged commit edf7335 into javascript-tutorial:master Jan 25, 2021
@javascript-translate-bot

javascript-translate-bot commented Jan 25, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
joaquinelio deleted the leproso branch January 25, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@joaquinelio @javascript-translate-bot @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.