GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||
GeezerVison is showing github.com — Proxy and Reflect by joaquinelio · Pull Request #451 · javascript-tutorial/es.javascript.info Conversation
|
|
I know, Mr Bot. wtf I've stolen it |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Me lo pienso para comenzar esta revisión... Pronto lo haré |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
podes hacerla en comodas cuotas... pero si podes dar algo de tiempo, la sync es siempre prioridad |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Revision de tareas y del articulo hasta la línea 200.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: ᐯᑭᒪEᑎTIᑎᗩ᙭ ᐯᑭ <[email protected]>
There was an error while loading. Please reload this page.
` 181 // 1ra verion sobreexplicada // creo que quedo bien simplificado y contundente ` TLDR |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Revisón hasta la línea 592. Ya vamos por la mitad. Realmente está muy bien, pocas cosas que arreglar.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Me gustó, me parece más claro. Me refiero a lo que arreglaste en reformulacion 181 "proxy vs target" @joaquinelio
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: ᐯᑭᒪEᑎTIᑎᗩ᙭ ᐯᑭ <[email protected]>
|
@vplentinax |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Pequeñas cositas, una vez aceptadas puedes hacer merge!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| Algo similar ocurre con los "campos privados" usados en las clases. | ||
|
|
||
| For example, `getName()` method accesses the private `#name` property and breaks after proxying: | ||
| Por ejemplo, el método `getName()` accede a la propiedad privada `#name` y falla por hacerlo proxy: |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| Por ejemplo, el método `getName()` accede a la propiedad privada `#name` y falla por hacerlo proxy: | |
| Por ejemplo, el método `getName()` accede a la propiedad privada `#name` y se interrumpe después del proxy: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
No, no se interrumpe, falla, porque no encuentra la variable.
Y no "después del proxy" en todo caso sería "después de convertirlo a proxy"
pero puse "POR" porque la falla es consecuencia de convertirlo.
Falla, por haberlo convertido en proxy.
No enconctré forma comoda de traducir el ubicuo "proxing" que traduje como "hacerlo proxy"
¡ proxificar ?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
un problema que no vi de poner "hacerlo proxy" es q parece que convirtiera al metodo,
deberia aclarar que convierto el objeto entero o escribirlo mas vagamente
"...falla despues de hacer el proxy"
"...falla despues de la conversión a proxy"
"...falla depués de la proxificación. "
no me parece nada mal la idea. Es muy comodo tener la palabra proxificar.
tamb puedo sobreaclarar
"...falla depués de la proxificación del objeto user. "
@vplentinax , pienso poner
"...falla depués de la proxificación. "
¿que tal?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Valentiina VP <[email protected]>
Co-authored-by: Valentiina VP <[email protected]>
Co-authored-by: Valentiina VP <[email protected]>
|
Novedades -Acepté (alguno de mala gana :P ) tus cambios. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Acepte todas las sug excepto linea 845 porque era un error conceptual que no puedo aceptar. Es el unico articulo que falta de la seccion Js, y la demora genera conflictos que tengo que andar resolviendo El art es bueno, vale la pena el merge |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.