GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Forms: event and method submit by puntope · Pull Request #454 · javascript-tutorial/es.javascript.info

Conversation

puntope commented Dec 9, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

puntope added 5 commits

December 9, 2020 22:13


          Forms: event and method submit

21fb24e


          Update task.md

af25299


          Update solution.md

62f6bc5


          Update index.html

7a8321a


          Update index.html

a1bf500

javascript-translate-bot added the review needed label

Dec 9, 2020

javascript-translate-bot requested a review from a team

December 9, 2020 21:46

CLAassistant commented Dec 9, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Dec 10, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bienvenido

algunos acentos,
las cuestiones de forma podes ignorarme, el articulo es muy claro

tuviste el criterio de traducir value pero no name o type...
aja...
es que siempre ando buscando reviewers, aunque el bot te ignore podes dejar las correcciones y comentarios

otra forma de ayudar,
cada tanto hacemos merge desde ingles,
cuando hay más de un par de lineas descarto los cambios y los paso a issues. "actualizar"
Por un lado es mas facil porque es menos cantidad,
por otro lado mas complejo porque hay que comparar con el repo ingles,
revisar el historial de commits, y corregir los nros de lineas (me ayudo con vscode +gitlens que hace diff con cualquier remoto)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Dec 10, 2020

javascript-translate-bot commented Dec 10, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Dec 10, 2020

Copy link

Copy Markdown

Member

Cambio titulo, agrego al issue a mano
confirmarlo al hacer merge

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio changed the title ~~Forms event and method submit~~ Forms: event and method submit

Dec 10, 2020

joaquinelio mentioned this pull request

Dec 10, 2020

Spanish Translation Progress #17

Open

puntope and others added 9 commits

December 10, 2020 20:34


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md

ed8bf56

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md

a3f2a94

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.v…

d5f8910

…iew/index.html

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

b7350f2

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

9164cba

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/article.md

9e2559a

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md

a1e0e94

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

8132ed7

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

f782995

Co-authored-by: joaquinelio <[email protected]>

puntope commented Dec 10, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

puntope closed this

Dec 10, 2020

javascript-translate-bot added review needed and removed changes requested labels

Dec 10, 2020

javascript-translate-bot requested a review from a team

December 10, 2020 19:36

puntope reopened this

Dec 10, 2020

puntope commented Dec 10, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Dec 10, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

hola, @puntope
casi ok
eeehhh... quedaron dos sin resolver,
de los que no negocio, "a veces" y un typo

edit
ah, ok: pereza de github "2 hidden...show more"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

puntope and others added 2 commits

December 10, 2020 22:54


          Update 2-ui/4-forms-controls/4-forms-submit/article.md

91715b7

Co-authored-by: joaquinelio <[email protected]>


          Update 2-ui/4-forms-controls/4-forms-submit/article.md

7cbe071

Co-authored-by: joaquinelio <[email protected]>

puntope commented Dec 10, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio approved these changes

Dec 10, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that s was fast
...

yes!
👍

waiting for the second reviewer now...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Dec 10, 2020

vplentinax approved these changes

Dec 13, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo bien...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vplentinax added ready to merge and removed needs +1 labels

Dec 13, 2020

joaquinelio merged commit 85b14d2 into javascript-tutorial:master

Dec 14, 2020

javascript-translate-bot commented Dec 14, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

puntope deleted the Forms-event-and-method-submit branch

December 14, 2020 09:43

Reviewers

joaquinelio

joaquinelio approved these changes

vplentinax

vplentinax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

puntope commented Dec 9, 2020

Uh oh!

CLAassistant commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Dec 10, 2020

Uh oh!

joaquinelio commented Dec 10, 2020

Uh oh!

puntope commented Dec 10, 2020

Uh oh!

puntope commented Dec 10, 2020

Uh oh!

joaquinelio commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puntope commented Dec 10, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Dec 14, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Dec 9, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Dec 10, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.