GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drag'n'Drop with mouse events by kenliten · Pull Request #466 · javascript-tutorial/es.javascript.info

Conversation

@kenliten

@kenliten kenliten commented Dec 25, 2020

Copy link
Copy Markdown
Contributor

Hola @joaquinelio!
Lamento mucho la demora, tuve muchos problemas lidiando con una distro que no conocía e intenté traducir desde el celular y creé muchos problemas, así que al final, tuve que eliminar mi fork y con el el progreso, para crear un nuevo fork, un nuevo branch y bueno, aquí está el primer artículo.

PeAcE!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Otoniel Reyes Galay
Translated Drag n Drop
5c80514
@javascript-translate-bot javascript-translate-bot added the review needed label Dec 25, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team December 25, 2020 18:31
@javascript-translate-bot javascript-translate-bot mentioned this pull request Dec 25, 2020
Spanish Translation Progress #17
Open
@joaquinelio

joaquinelio commented Dec 26, 2020

Copy link
Copy Markdown
Member

hola!
no es una carrera...
y tus aportes ya sumaron al proyecto

disculpame ahora la crítica,
"importance: " de las task no se traducen, NO SE por qué, es metadata pero no se para que la usa
y la verdad que en ingles queda feo,
pero específicamente (en el readme) pidio que no tradujeramos


Metadata
Some files, usually tasks, have YAML metadata at the top, delimited by ---:

importance: 5

---
...
Please don't translate "importance" (and other top metadata).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kenliten

kenliten commented Dec 26, 2020

Copy link
Copy Markdown
Contributor Author

Oh ok!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio
joaquinelio requested changes Dec 26, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos y sugerencias

No traduzcas "importance" en task porque es metadata que no se para que corno es

sobre lo que puse de aclarar "mousedown", no hace falta, lo resolviste bien y queda claro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Dec 26, 2020
@javascript-translate-bot

javascript-translate-bot commented Dec 26, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Dec 26, 2020
Otoniel Reyes Galay and others added 11 commits December 26, 2020 17:52
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
2f49437
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
e953edf
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
719e391
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
464ce1c
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
2dff5f8
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
17741f6
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
91ed5d0
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
728dc95
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
b7ae1db
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
654e688
Co-authored-by: joaquinelio <[email protected]>
Otoniel Reyes Galay @joaquinelio
Update 2-ui/3-event-details/4-mouse-drag-and-drop/article.md
0f59b76
Co-authored-by: joaquinelio <[email protected]>
@kenliten

kenliten commented Dec 26, 2020

Copy link
Copy Markdown
Contributor Author

/done
Si eso era todo, estamos listos!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Dec 26, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team December 26, 2020 21:57
@joaquinelio

joaquinelio commented Jan 15, 2021

Copy link
Copy Markdown
Member

Hola capo

No, no era todo. Hay que deshacer los dos cambios
"importance: 5"
no puedo editarlo ni me deja sugerir cambios no se por qué

ya va un mes,
si no aparece segundo reviewer lo reviso de nuevo y -> merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Jan 15, 2021

Copy link
Copy Markdown
Member

@kenliten
ah, borraste tu branch
pero github aun lo recuerda en nosedonde,
asi que se puede hacer merge igual
y corregir lo de "importance" después

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kenliten

kenliten commented Jan 15, 2021

Copy link
Copy Markdown
Contributor Author

Si, lo borre, pense que ya habias hecho el merge, y ahora intento pero no me permite editarlos

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio

joaquinelio commented Jan 16, 2021

Copy link
Copy Markdown
Member

No te permite porque está trabajando con una versión congelada

Voy a hacer merge y un despues PR con más cambios para:

  • arreglar "importance:" (aunque nadie lo extrañe)
  • legibilidad de las lineas mas importantes del principio
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
joaquinelio merged commit 7861d07 into javascript-tutorial:master Jan 16, 2021
@javascript-translate-bot

javascript-translate-bot commented Jan 16, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kenliten @joaquinelio @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.