GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Alternation (OR) | by vplentinax · Pull Request #473 · javascript-tutorial/es.javascript.info

Conversation

vplentinax commented Jan 17, 2021

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          regexp or

b2f0302

javascript-translate-bot added the review needed label

Jan 17, 2021

javascript-translate-bot requested a review from a team

January 17, 2021 18:25

javascript-translate-bot mentioned this pull request

Jan 17, 2021

Spanish Translation Progress #17

Open


          Merge branch 'master' into or

df36170

vplentinax requested a review from joaquinelio

January 17, 2021 18:26

joaquinelio requested changes

Jan 17, 2021

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo del escape...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/13-regexp-alternation/03-match-quoted-string/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/03-match-quoted-string/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/03-match-quoted-string/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/03-match-quoted-string/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/03-match-quoted-string/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jan 17, 2021

javascript-translate-bot commented Jan 17, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 5 commits

January 19, 2021 17:05


          Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…

…ring/solution.md

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…

3bb53ad

…ring/task.md

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…

bef3bd5

…ring/task.md

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…

cdbcf15

…ring/task.md

Co-authored-by: joaquinelio <[email protected]>


          Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…

7911a22

…ring/task.md

Co-authored-by: joaquinelio <[email protected]>

joaquinelio requested changes

Jan 20, 2021

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comillas y espacios,
hay varios pero se me cruzan los ojos tengo que andar + y - zoom, sorry la review deficiente

sugiero una linea que creo que es una mejora conceptual,
no la mando al inglés porque ya estoy molestando demasiado y la ultima Ilya la aprobo de mala gana (y no era buena, en esp quedo mejor)
Claro que si cambia en algo el concepto no lo cambio en ESP si Ilya no lo acepta en ENG, no es el caso.

este es un art corto pero arduo, buen aporte al repo
Ya no tengo objeciones conceptuales, me gustaria que hicieras el merge aceptes o no los nuevos cambios

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/13-regexp-alternation/01-find-programming-language/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/01-find-programming-language/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/13-regexp-alternation/03-match-quoted-string/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jan 20, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 3 commits

February 3, 2021 08:41


          Update 9-regular-expressions/13-regexp-alternation/01-find-programmin…

ee74c4f

…g-language/solution.md


          Update 9-regular-expressions/13-regexp-alternation/03-match-quoted-st…

3d157e7

…ring/task.md


          Update 9-regular-expressions/13-regexp-alternation/01-find-programmin…

eeb7ba4

…g-language/solution.md

joaquinelio merged commit 7ea15bd into javascript-tutorial:master

Feb 3, 2021

javascript-translate-bot commented Feb 3, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.