GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Shadow DOM and events by joaquinelio · Pull Request #550 · javascript-tutorial/es.javascript.info

Conversation

joaquinelio commented Oct 2, 2021

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Shadow DOM and events

0c8ccfc

javascript-translate-bot added the review needed label

Oct 2, 2021

javascript-translate-bot requested a review from a team

October 2, 2021 12:39

javascript-translate-bot mentioned this pull request

Oct 2, 2021

Spanish Translation Progress #17

Open

joaquinelio added 2 commits

October 2, 2021 09:54


          Update article.md

10523a9


          Update article.md

4d9df72

dbritto-dev reviewed

Dec 14, 2021

View reviewed changes

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev suggested changes

Dec 14, 2021

View reviewed changes

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

8-web-components/7-shadow-dom-events/article.md

		Por otro lado, si el clic ocurre en un elemento originalmente del shadow DOM, ej. en `<b>Name</b>`, entonces, como se propaga hacia fuera del shadow DOM, su `event.target` se reestablece a `<user-card>`.

		## Bubbling, event.composedPath()
		## Propagación, event.composedPath()

joaquinelio Dec 16, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es correcto,
pero me suena feo...
¿cuanto insistis con esto? me dejo convencer facil

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

dbritto-dev Dec 16, 2021

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquinelio yo creo que lo dejamos como Propagación

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Dec 14, 2021

javascript-translate-bot commented Dec 14, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev commented Dec 14, 2021

Copy link

Copy Markdown

Contributor

@joaquinelio todo tuyo :D

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Dec 14, 2021

Copy link

Copy Markdown

Member Author

gracias!!! @dbritto-dev
gúilcombác

shadow-??????

Uf. Lo voy a poner como issue. Hay que cepillar el repo con esto.

AHORA estoy de acuerdo,
es usual que aparezca en codigo o como propiedad element.shadowRoot
pero no me vas a convencer de que "shadow and light" es una palabra compuesta.

setear

demasiado usual y se me escapo... pero acordate, los que usamos estas pocas aberraciones vamos a lograr que el drae las registre.

etc.
gracias, volveré luego

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev commented Dec 14, 2021

Copy link

Copy Markdown

Contributor

gracias!!! @dbritto-dev gúilcombác

shadow-??????

Uf. Lo voy a poner como issue. Hay que cepillar el repo con esto.

AHORA estoy de acuerdo, es usual que aparezca en codigo o como propiedad element.shadowRoot pero no me vas a convencer de que "shadow and light" es una palabra compuesta.

setear

demasiado usual y se me escapo... pero acordate, los que usamos estas pocas aberraciones vamos a lograr que el drae las registre.

etc. gracias, volveré luego

falto traducir el and en shadow and light, hahaha :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update 8-web-components/7-shadow-dom-events/article.md

0dc173a

Co-authored-by: Danilo Britto <[email protected]>

joaquinelio commented

Dec 16, 2021

View reviewed changes

Comment thread

8-web-components/7-shadow-dom-events/article.md

		Por otro lado, si el clic ocurre en un elemento originalmente del shadow DOM, ej. en `<b>Name</b>`, entonces, como se propaga hacia fuera del shadow DOM, su `event.target` se reestablece a `<user-card>`.

		## Bubbling, event.composedPath()
		## Propagación, event.composedPath()

joaquinelio Dec 16, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es correcto,
pero me suena feo...
¿cuanto insistis con esto? me dejo convencer facil

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Apply suggestions from code review

3ca282b

Co-authored-by: Danilo Britto <[email protected]>

joaquinelio commented Dec 16, 2021

Copy link

Copy Markdown

Member Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Dec 16, 2021

joaquinelio commented Dec 16, 2021

Copy link

Copy Markdown

Member Author

mentira /done, ¿si hago el ultimo commit puedo darle merge?

¡falta un solo articulo para terminar el repo!!
y estos 2 pr, si queres podes echarle un vistazo al otro...
especialmente si usaste regex

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dbritto-dev approved these changes

Dec 16, 2021

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Dec 16, 2021

joaquinelio commented Dec 16, 2021

Copy link

Copy Markdown

Member Author

biutiful

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio merged commit ea8f513 into javascript-tutorial:master

Dec 16, 2021

joaquinelio deleted the shave branch

December 16, 2021 12:11

javascript-translate-bot commented Dec 16, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

1 more reviewer

dbritto-dev

dbritto-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.