GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Shadow DOM slots, composition by MaxSierra16 · Pull Request #561 · javascript-tutorial/es.javascript.info

Conversation

MaxSierra16 commented Oct 13, 2021

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Traduccion Shadow DOM slots, composición

1d3ad57

javascript-translate-bot added the review needed label

Oct 13, 2021

javascript-translate-bot requested a review from a team

October 13, 2021 02:15

joaquinelio self-requested a review

October 13, 2021 06:21

joaquinelio requested changes

Oct 13, 2021

View reviewed changes

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hola

muy bueno

acepta las sug que quieras
cualquier cosa. se puede discutir

ah, cambie el nombre pra q Don Bot se entere.
pfffff no se enteró, edito el progress a mano #17

notas
podes editar online el PR,
tamb podes modif tu branch local y cuando lo subis con push se modifica el pr automaticamente

modificaste tu master, no es problema para mi
pero la idea es tener tu master SIEMPRE LIMPIO, sincronizado con master upstream
haces branch
ej max : branch1
lo modificas, lo subis, y con suerte te lo aceptan
1
si upstram:master se actualiza sin tu pr, el tuyo no quedaria desencajado
2
podes hacer otra modifcacion independiente en branch2 sin trrastear la primera

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Oct 13, 2021

javascript-translate-bot commented Oct 13, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio changed the title ~~Traduccion Shadow DOM slots, composición~~ Shadow DOM slots, composition

Oct 13, 2021

joaquinelio mentioned this pull request

Oct 13, 2021

Spanish Translation Progress #17

Open


          Update 8-web-components/5-slots-composition/article.md

d86e408

Co-authored-by: joaquinelio <[email protected]>

MaxSierra16 commented Oct 14, 2021

Copy link

Copy Markdown

Contributor Author

@joaquinelio Gracias por tus observaciones. De verdad fueron muy acertadas. Hoy mismo estare pushiando los cambios 🚀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MaxSierra16 and others added 10 commits

October 15, 2021 10:54


          Update 8-web-components/5-slots-composition/article.md

aae4aeb

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

82bf64c

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

f7b1b3e

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

81643df

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

fc5090d

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

19ee397

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

b6d1a6d

Co-authored-by: joaquinelio <[email protected]>


          Update 8-web-components/5-slots-composition/article.md

618d69c

Co-authored-by: joaquinelio <[email protected]>


          Cambios sugeridos localmente.

19ff453


          Update 8-web-components/5-slots-composition/article.md

a2d17a2

Co-authored-by: joaquinelio <[email protected]>

MaxSierra16 commented Oct 15, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Oct 15, 2021

javascript-translate-bot requested a review from a team

October 15, 2021 15:29

MaxSierra16 requested review from joaquinelio and removed request for a team

October 15, 2021 15:30

joaquinelio added 2 commits

October 15, 2021 16:21


          Update article.md

523bc96


          Update article.md

5b99a3a


          Update article.md

8d7b97c

joaquinelio reviewed

Oct 15, 2021

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo lei y me parecio muy bien,

pero 2 sugerencias que no incorporaste y me parece que deben resolverse

447 .... "los métodos: " o "estos métodos : "
...
...

451, pienso tmbién cómo es más facil leer
evito el potencial y el reflexivo "nos gustaría"

"Si queremos saber, podemos..."
o
"Si quisiéramos saber, podríamos "

Si no contestás lo agrego como está,
preferible online aunque tuviera errores

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update 18/10

7f87e6f

MaxSierra16 commented Oct 18, 2021

Copy link

Copy Markdown

Contributor Author

Si queremos saber, podemos

Cool 🚀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MaxSierra16 commented Oct 18, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot requested a review from a team

October 18, 2021 13:00

MaxSierra16 requested review from joaquinelio and removed request for a team

October 18, 2021 13:00

joaquinelio approved these changes

Oct 18, 2021

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no puedo verlo bien ahora
estaba bueno antes ,estara mejor ahora, cheqealo online,
problemas, nuevo pr y cuandopueda vuelvo
salud

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MaxSierra16 reacted with hooray emoji

All reactions

🎉 1 reaction

javascript-translate-bot added needs +1 and removed review needed labels

Oct 18, 2021

joaquinelio merged commit 5652645 into javascript-tutorial:master

Oct 18, 2021

javascript-translate-bot commented Oct 18, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented Oct 18, 2021

Copy link

Copy Markdown

Member

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

MaxSierra16 commented Oct 13, 2021

Uh oh!

joaquinelio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 13, 2021

Uh oh!

MaxSierra16 commented Oct 14, 2021

Uh oh!

MaxSierra16 commented Oct 15, 2021

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

MaxSierra16 commented Oct 18, 2021

Uh oh!

MaxSierra16 commented Oct 18, 2021

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Oct 18, 2021

Uh oh!

joaquinelio commented Oct 18, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.