GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Type Conversions by tikoflano · Pull Request #57 · javascript-tutorial/es.javascript.info

Conversation

tikoflano commented Jun 6, 2019

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tikoflano added 2 commits

May 28, 2019 01:42


          Update article.md

f976410

Primera edicion


          Corrección de errores menores

773a22a

javascript-translate-bot added the review needed label

Jun 6, 2019

javascript-translate-bot requested a review from a team

June 6, 2019 01:51

CLAassistant commented Jun 6, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lizzie136 reviewed

Jun 6, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Outdated

		Por ejemplo, `alert` convierte automáticamente cualquier valor a string para mostrarlo. Las operaciones matemáticas convierten los valores a números.

		There are also cases when we need to explicitly convert a value to the expected type.
		Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.

lizzie136 Jun 6, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

También

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tikoflano Jun 9, 2019

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you reviewed the wrong commit. That was fixed in the latest one.

I will update this PR with the translation of task and solution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

lizzie136 Jul 1, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tikoflano added 2 commits

June 8, 2019 21:47


          Task translation

9ff5db7


          Solutions translation

9ec05fa

lizzie136 self-requested a review

June 26, 2019 19:32

lizzie136 reviewed

Jul 1, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Outdated

		Por ejemplo, `alert` convierte automáticamente cualquier valor a string para mostrarlo. Las operaciones matemáticas convierten los valores a números.

		There are also cases when we need to explicitly convert a value to the expected type.
		Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.

lizzie136 Jul 1, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Typo fixes

8a6090c

tikoflano commented Jul 2, 2019

Copy link

Copy Markdown

Contributor Author

I fixed the typos. I'm curious about the "Tmabién" at line 7. I double checked that is ok in the "Files changed" of this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/06-type-conversions/article.md

		- `undefined` is `NaN` as a number, not `0`.
		- `"0"` and space-only strings like `" "` are true as a boolean.
		- `undefined` es `NaN` como número, no `0`.
		- `"0"` y textos que solo contienen espacios como `" "` son `true` como boolean.

tscandalitta Jul 14, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quedaría mejor cadenas en lugar de textos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tikoflano Jul 19, 2019

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En todo el resto del artículo se usa la palabra "texto". Creo que "cadena" o "cadena de caracteres" puede confundir al lector ya que no se ha explicado lo que es.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tikoflano added 3 commits

July 18, 2019 21:43


          Update article.md

844b8d7

Mejoras propuestas por @tscandalitta


          Update article.md

a2e6ebe

Mejoras propuestas por @tscandalitta


          Typo fix

6dcbeeb

javascript-translate-bot removed the review needed label

Aug 22, 2019

lizzie136 approved these changes

Aug 22, 2019

View reviewed changes

lizzie136 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @tikoflano por estos cambios 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the needs +1 label

Aug 22, 2019

lizzie136 merged commit 9577373 into javascript-tutorial:master

Aug 22, 2019

iliakan mentioned this pull request

Aug 22, 2019

Spanish Translation Progress #17

Open

javascript-translate-bot commented Aug 22, 2019

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

tscandalitta

tscandalitta left review comments

lizzie136

lizzie136 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tikoflano commented Jun 6, 2019

Uh oh!

CLAassistant commented Jun 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizzie136 Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

tikoflano Jun 9, 2019

Choose a reason for hiding this comment

Uh oh!

lizzie136 Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lizzie136 Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

tikoflano commented Jul 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tscandalitta Jul 14, 2019

Choose a reason for hiding this comment

Uh oh!

tikoflano Jul 19, 2019

Choose a reason for hiding this comment

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Aug 22, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Jun 6, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.