GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Variables by javier123454321 · Pull Request #93 · javascript-tutorial/es.javascript.info

Conversation

javier123454321 commented Sep 2, 2019

Copy link

Copy Markdown

Primera traducción y primera contribución.
Utilizé la segunda persona formal (usted) al referirme al lector del artículo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          translated variable article into spanish

javascript-translate-bot added the review needed label

Sep 2, 2019

javascript-translate-bot requested a review from a team

September 2, 2019 03:37

iliakan mentioned this pull request

Sep 2, 2019

Spanish Translation Progress #17

Open

CLAassistant commented Sep 2, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ EzequielCaste
✅ joaquinelio
❌ Javier Gonzalez

Javier Gonzalez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta added the changes requested label

Sep 8, 2019

tscandalitta commented Sep 8, 2019

Copy link

Copy Markdown

Collaborator

En el tutorial nos venimos refiriendo al usuario como "tú" y no como "usted". Podrías corregirlo?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tscandalitta removed the review needed label

Sep 8, 2019

Giorgiosaud commented Sep 11, 2019

Copy link

Copy Markdown

Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Cambiar el termino de segunda persona formal a informal (tú)

10173c4

javier123454321 commented Sep 23, 2019

Copy link

Copy Markdown

Author

Lamento la demora, aquí estan estas correcciones, espero poder dedicarle mas tiempo en el futuro cercano y poder progresar mas rápido

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Jun 3, 2020

View reviewed changes

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax o @ezzep66 Revisen, avisen y lo edito y hago merge
Cierto que faltan los ejercicios, pero
Está buena, no rompe estructura, es largo y tradujo hasta los link externos al sitio ES
Oops! ¿Qué tan importante es firmar eso? ¿Propiedad intelectual?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 3, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste added 2 commits

June 3, 2020 09:29


          Update 1-js/02-first-steps/04-variables/article.md

d9e1cf1


          Update 1-js/02-first-steps/04-variables/article.md

EzequielCaste commented Jun 3, 2020

Copy link

Copy Markdown

Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jun 5, 2020

Copy link

Copy Markdown

Contributor

Se puede hacer merge a esto o no¿? @ezzep66 @joaquinelio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Jun 8, 2020

View reviewed changes

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 8, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 2 commits

June 8, 2020 15:21


          Update 1-js/02-first-steps/04-variables/article.md

940457e


          Update 1-js/02-first-steps/04-variables/article.md

84230b9

joaquinelio merged commit f74c8ae into javascript-tutorial:master

Jun 8, 2020

javascript-translate-bot commented Jun 8, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

EzequielCaste

EzequielCaste left review comments

joaquinelio

joaquinelio requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

javier123454321 commented Sep 2, 2019

Uh oh!

CLAassistant commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tscandalitta commented Sep 8, 2019

Uh oh!

Giorgiosaud commented Sep 11, 2019

Uh oh!

javier123454321 commented Sep 23, 2019

Uh oh!

joaquinelio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 3, 2020

Uh oh!

EzequielCaste commented Jun 3, 2020

Uh oh!

vplentinax commented Jun 5, 2020

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 8, 2020

Uh oh!

javascript-translate-bot commented Jun 8, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CLAassistant commented Sep 2, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.