GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Logical operators by mahdiHash · Pull Request #100 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Mar 26, 2021

Copy link

Copy Markdown

Contributor

Please read the description of article.md and solution.md of task 8 "if question".
Please review and comment / commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 22 commits

March 22, 2021 19:46


          Translate task.md

c65f2c4

Please review and comment / commit if anything is wrong


          Translate solution.md

72b0f3d

Please review and comment / commit if anything is wrong


          Translate task.md

93a9323

Please review and comment / commit if anything is wrong


          Translate solution.md

334f30e

Please review and comment / commit if anything is wrong


          Translate task.md

2fdad10

Please review and comment / commit if anything is wrong


          Translate solution.md

1400d48

Please review and comment / commit if anything is wrong


          Translate task.md

ae6a43c

Please review and comment / commit if anything is wrong


          Translate solution.md

e063f71

Please review and comment / commit if anything is wrong


          Translate task.md

409b9b8

Please review and comment / commit if anything is wrong


          Translate solution.md

7ccd995

Please review and comment / commit if anything is wrong


          Translate task.md

Please review and comment / commit if anything is wrong


          Translate task.md

caaf46a

Please review and comment / commit if anything is wrong


          Translate solution.md

f80ac8a

Please review and comment / commit if anything is wrong


          Translate task.md

a695b87

Please review and comment / commit if anything is wrong


          Translate task.md (read description)

146cd06

I translated line 7 as it was but in my opinion to keep it readable it would be better this way:
نتیجه 0 || 1- برابر با 1- است، truthy
Please review and comment / commit if anything is wrong


          Translate task.md

Please review and comment / commit if anything is wrong


          Translate solution.md

8a7aac7

Please review and comment / commit if anything is wrong


          Translate solution.md (read description)

09d78fd

I translated line 7 as it was but in my opinion to keep it readable it would be better this way:
نتیجه 0 || 1- برابر با 1- است، truthy
Please review and comment / commit if anything is wrong


          Translate a part of article.md

4584ad0

Translation is not done yet


          Translate second part of article.md

e6681eb

I translated line 100 as it was but I think it would be better this way:
این باعث چند استفاده جالب نسبت به یک "OR خالص و کلاسیک که تنها boolean قبول می کند" می شود.
Please let me know what you think


          Translate third part

34efc15

Translation is not done yet


          Translate article.md (read description)

e4a4185

I translated line 100 as it was but I think it would be better this way:
این باعث چند استفاده جالب نسبت به یک "OR خالص و کلاسیک که تنها boolean قبول می کند" می شود.
Please let me know what you think and review and comment / commit if anything is wrong

javascript-translate-bot added the review needed label

Mar 26, 2021

javascript-translate-bot requested a review from a team

March 26, 2021 15:12

javascript-translate-bot mentioned this pull request

Mar 26, 2021

Persian (Farsi) Translation Progress #1

Open

mahdyar requested changes

Mar 26, 2021

View reviewed changes

Comment thread

1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/solution.md Outdated

		@@ -1,4 +1,4 @@
		The answer is `2`, that's the first truthy value.
		جواب 2 است، آن(2) اولین مقدار truthy است.

mahdyar Mar 26, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 should be between backquotes:
جواب `2` است
and there is no need to mention it again:
آن(2)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/11-logical-operators/article.md Outdated

		بیایید جزییات را ببینیم.

		## \|\| (OR)
		## \|\| (OR یا)

mahdyar Mar 26, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for Persian translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/11-logical-operators/article.md Outdated

Comment on lines +24 to +27

		alert( true \|\| true ); // true درست
		alert( false \|\| true ); // true درست
		alert( true \|\| false ); // true درست
		alert( false \|\| false ); // false اشتباه

mahdyar Mar 26, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use either true or درست, not both of them.
Use either false or اشتباه, not both of them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/11-logical-operators/article.md Outdated

		```

		The precedence of NOT `!` is the highest of all logical operators, so it always executes first, before `&&` or `\|\|`.
		اولویت NOT `!` بالاترین اولویت بین عملگر های منطقی دارد، بنابراین همیشه اول اجرا می شود، قبل از `&&` یا `\|\|`.

mahdyar Mar 26, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence readability could be better:
عملگر NOT `!` بالاترین اولویت را بین عملگرهای منطقی دارد،

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/11-logical-operators/article.md Outdated


		if (hour < 10 \|\| hour > 18 \|\| isWeekend) {
		alert( 'The office is closed.' ); // it is the weekend
		alert( 'The office is closed.' ); // آخر هفته است

mahdyar Mar 26, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The office is closed. should also be translated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Mar 26, 2021

javascript-translate-bot commented Mar 26, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Fix the mentioned problem

e63c0ef


          Fix the mentioned problems

a1c1d34

All the mentioned problems are fixed.

mahdiHash commented Mar 27, 2021

Copy link

Copy Markdown

Contributor Author

Thank you for your review, @mahdyar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented Mar 27, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 27, 2021

javascript-translate-bot requested a review from a team

March 27, 2021 10:33

mahdyar approved these changes

Mar 27, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Mar 27, 2021

mahdyar merged commit a408f10 into javascript-tutorial:master

Mar 27, 2021

javascript-translate-bot commented Mar 27, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.