GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Comparisons by emadpoursina · Pull Request #101 · javascript-tutorial/fa.javascript.info

Conversation

emadpoursina commented Mar 28, 2021

Copy link

Copy Markdown

Contributor

Translation is done. Please review and commit if anything is wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Translate aticle.md

5c7b168

Translation is done. Please review and commit if anything is wrong.

javascript-translate-bot added the review needed label

Mar 28, 2021

javascript-translate-bot requested a review from a team

March 28, 2021 06:37

mahdyar requested changes

Mar 28, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @emadpoursina,
First, you should claim the article in #1.
Also, read the For New Translators section there (#1):

The pull request title should be same as the article, e.g. An Introduction to JavaScript (just like comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Mar 28, 2021

javascript-translate-bot commented Mar 28, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

emadpoursina changed the title ~~Translate aticle.md~~ Comparisons

Mar 28, 2021

emadpoursina commented Mar 28, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdyar requested changes

Mar 28, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a folder which contains the tasks and solutions that should also be translated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		# مقایسه ها

		We know many comparison operators from maths.
		ما عملگرهای زیادی را از ریاضی می شناسیم.

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

عملگرهای مقایسه‌ای زیادی را از ریاضیات می‌شناسیم. would be a better translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		## برابری در رشته ها

		A regular equality check `==` has a problem. It cannot differentiate `0` from `false`:
		یک علامت مقایسه برابری `==` یک مشکل دارد. این عملگر بین `0` و `false` تفاوتی قائل نمی شود:

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

یک علامت مقایسه برابری معمولی

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		````

		## Strict equality
		## برابری در رشته ها

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strict, not strings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		```

		The same thing happens with an empty string:
		دقیقا همین اتفاق برای رشته خالی هم می افتد:

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

یک رشتهٔ خالی

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		- از علامت های مقایسه ای `>= > < <=` برای مقایسه مقادیری که ممکن از `undefined/null` شوند استفاده نکنید مگر اینکه واقعا متوجه عواقب کارهای خود هستید. اگر متغیری می تواند این مقادیر را داشته باشد، آن ها را به صورت جداگانه بررسی کنید.

		## Summary
		## جمع بندی

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

خلاصه is what we used in other articles, so it'd be better if you use the same.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		- در عبارت `(3)` عملگر `==`, `false` برمی گرداند زیرا `undefined` تنها برابر `null` بوده و نابرابر با هر مقدار دیگری.

		### Avoid problems
		### از مشکلات دوری کن.

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

اجتناب از مشکلات

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Outdated

		: `null/undefined` به عدد تبدیل می شوند: `null` تبدیل به `0` می شود در حالی که `undefined` به `NaN`.

		Now let's see some funny things that happen when we apply these rules. And, what's more important, how to not fall into a trap with them.
		حال بگذارید که چند اتفاق با مزه و جالب که زمانی که این قانون ها را اعمال می افتند را بررسی کنیم ; و مهم تر از همه ببینیم که چگونه داخل این تله ها نیافتیم.

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

نیفتیم

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; is not needed, use ..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

زمانی که این قانون‌ها را اعمال می‌کنیم را ببینیم

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of
چند اتفاق با مزه و جالب که زمانی که,
چند اتفاق با مزه و جالب زمانی که would be a better translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

emadpoursina Mar 28, 2021

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

چند اتفاق بامزه و جالب که با اعمال این قانون ها می افتند را ببینیم.‍

I think is better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot commented Mar 28, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

emadpoursina added 5 commits

March 28, 2021 18:00


          translate task and it's solve

fe08b35


          made some changes and fix some problems

86ec021


          made some changes and fix some problems

3b12300


          Merge branch 'master' of https://github.com/emadPoursina/fa.javascrip…

72baf5e

…t.info


          fix some problems

db48d40

emadpoursina commented Mar 28, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 28, 2021

javascript-translate-bot requested a review from a team

March 28, 2021 13:41

mahdyar requested changes

Mar 28, 2021

View reviewed changes

Comment thread

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md Outdated

		```

		Some of the reasons:
		دلیل پاسخ ها:

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

بعضی از دلایل: would be a better translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/1-comparison-questions/task.md Outdated

		@@ -1,10 +1,10 @@
		importance: 5
		اهمیت: 5

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata shouldn't be translated. [+]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md Outdated

Comment on lines +15 to +21

		1. true, نیاز به توضیح نداره
		2. false, بر اساس مقایسه لغت نامه ای که `"a"` کوچک تر از `"p"` است.
		3. دوباره مانند مثال قبل در مقایسه لغت نامه ای حرف اول `"2"` بزرگ تر از حرف اول عبارت دیگر `"1"` است.
		4. ارزش های `null` و `undefined` تنها برابر یکدیگرند.
		5. برابری سختگیرانه, سختگیرانه است. به دلیل تفاوت در نوع داده پاسخ false است.
		6. مانند مثال شماره `(4)`، `null` تنها برابر `undefined` است.
		7. برابری سختگیرانه برای دو داده از دو نوع متفاوت

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove dots from the end of sentences. e.g:
برابری سختگیرانه برای دو داده از دو نوع متفاوت <- برابری سختگیرانه برای دو داده از دو نوع متفاوت.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdyar Mar 28, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in Persian, we don't have ,, using ، would be a better idea.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Mar 28, 2021

javascript-translate-bot commented Mar 28, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          fix some mistakes

da4b339

emadpoursina commented Mar 30, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 30, 2021

javascript-translate-bot requested a review from a team

March 30, 2021 03:19

mahdyar approved these changes

Mar 30, 2021

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Mar 30, 2021

mahdyar merged commit 457ca0b into javascript-tutorial:master

Mar 30, 2021

javascript-translate-bot mentioned this pull request

Mar 30, 2021

Persian (Farsi) Translation Progress #1

Open

javascript-translate-bot commented Mar 30, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

emadpoursina commented Mar 28, 2021

Uh oh!

mahdyar left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Mar 28, 2021

Uh oh!

emadpoursina commented Mar 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahdyar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Mar 28, 2021

Uh oh!

emadpoursina commented Mar 28, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Mar 28, 2021

Uh oh!

emadpoursina commented Mar 30, 2021

Uh oh!

javascript-translate-bot commented Mar 30, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

emadpoursina commented Mar 28, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.