GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Function expressions by mahdiHash · Pull Request #105 · javascript-tutorial/fa.javascript.info

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

Please review and comment / commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mahdiHash added 5 commits April 1, 2021 14:48
@mahdiHash
Translate first part of article.md
7997e98
@mahdiHash
Translate 2nd part of article.md and 2 more things
74b5d0b 
Translated second part 
Removed some unnecessary whitespaces
Changed some lines for better readability
@mahdiHash
Remove unnecessary whitespace
7f948eb
@mahdiHash
Translate third part of article.md
059703c
@mahdiHash
Translate article.md
a86fc19 
Please review and comment / commit if anything is wrong
@javascript-translate-bot javascript-translate-bot added the review needed label Apr 3, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team April 3, 2021 19:12
@javascript-translate-bot javascript-translate-bot mentioned this pull request Apr 3, 2021
Persian (Farsi) Translation Progress #1
Open
mahdyar
mahdyar requested changes Apr 4, 2021
View reviewed changes
Comment thread 1-js/02-first-steps/16-function-expressions/article.md Outdated
@@ -1,84 +1,84 @@
# Function expressions

@mahdyar mahdyar Apr 4, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of the fact that there is no suitable equivalent in Persian for Function expressions, but titles should always be translated because they'll be in RTL and they won't look good this way.
For example you can use اعلان تابع Expression.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Apr 4, 2021
@javascript-translate-bot

javascript-translate-bot commented Apr 4, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash
Fix mentioned problems
cfeff22
@mahdiHash

mahdiHash commented Apr 4, 2021

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Apr 4, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team April 4, 2021 13:09
mahdyar
mahdyar approved these changes Apr 4, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Apr 4, 2021
@mahdyar
mahdyar merged commit 043f2e7 into javascript-tutorial:master Apr 4, 2021
@javascript-translate-bot

javascript-translate-bot commented Apr 4, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.