GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — BigInt by amirhshahbazi · Pull Request #120 · javascript-tutorial/fa.javascript.info

Conversation

amirhshahbazi commented May 4, 2021

Copy link

Copy Markdown

Contributor

Translated the BigInt page.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          correct true and false

0bf0fe2

javascript-translate-bot added the review needed label

May 4, 2021

javascript-translate-bot requested a review from a team

May 4, 2021 17:19

javascript-translate-bot commented May 4, 2021

Copy link

Copy Markdown

Error: the article already has PR number in the Progress Issue #1, it's 117 ⁉️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdyar requested changes

May 4, 2021

View reviewed changes

mahdyar left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to make a new pull request for any changes you make. you can add more commits by pushing to the BigInt branch on your fork.
In addition to that, please read the Translation Tips:

Please keep line breaks and paragraphs "as is": don't add new lines and don't remove existing ones. Makes it easy to merge future changes from the English version into the translation.

You've removed the newline on line 8, please add it back.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

amirhshahbazi reacted with thumbs up emoji

All reactions

👍 1 reaction

javascript-translate-bot added changes requested and removed review needed labels

May 4, 2021

javascript-translate-bot commented May 4, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          add missed new line

7254d00

amirhshahbazi commented May 4, 2021

Copy link

Copy Markdown

Contributor Author

Thanks for the review, @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

May 4, 2021

javascript-translate-bot requested a review from a team

May 4, 2021 19:18

mahdyar requested changes

May 4, 2021

View reviewed changes

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		```

		## Math operators
		## عملیات ریاضی

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Math operators means عملگرهای ریاضی, not عملیات ریاضی.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		```

		Please note: the division `5/2` returns the result rounded towards zero, without the decimal part. All operations on bigints return bigints.
		در نظر داشته باشید: عملیات تقسیم 5/2 نتیجه را بدون قسمت اعشار و رند شده به سمت صفر، باز می گرداند. همه ی عملیات بر روی bigint ها، مقداری را از نوع bigint باز می گردانند.

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put 5/2 between backticks as it was.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated


		```js run
		alert(1n + 2); // Error: Cannot mix BigInt and other types
		alert(1n + 2); // خطا: Cannot mix BigInt and other types

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to translate Error here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		```

		We should explicitly convert them if needed: using either `BigInt()` or `Number()`, like this:
		می بایست آن ها ابتدا به صورت زیر، توسط `BigInt()` یا `Number()` تبدیل کرد:

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed if needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		````

		## Comparisons
		## عملگرهای مقایسه

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مقایسه‌ای would be a better translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		alert( +bigint ); // خطا
		```
		So we should use `Number()` to convert a bigint to a number.
		باید ابتدا از `Number()` برای تبدیل یک bigint به نوع عددی استفاده کرد.

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ابتدا in the text, don't add your own words. Also, you missed so.
پس باید از...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/99-js-misc/05-bigint/article.md Outdated

		alert( 1n \|\| 2 ); // 1 (1n برابر با true است)

		alert( 0n \|\| 2 ); // 2 (0n is considered falsy)
		alert( 0n \|\| 2 ); // 2 (0n برابر با false است)

mahdyar May 4, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering means در نظر گرفتن.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the review needed label

May 4, 2021

javascript-translate-bot commented May 4, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

May 4, 2021


          replace incorrect translations

amirhshahbazi commented May 5, 2021

Copy link

Copy Markdown

Contributor Author

Thanks,
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

May 5, 2021

javascript-translate-bot requested a review from a team

May 5, 2021 21:09

mahdyar approved these changes

May 6, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @amirhshahbazi!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

amirhshahbazi reacted with thumbs up emoji

All reactions

👍 1 reaction

javascript-translate-bot added needs +1 and removed review needed labels

May 6, 2021

mahdyar merged commit 1f21ed1 into javascript-tutorial:master

May 6, 2021

mahdyar mentioned this pull request

May 6, 2021

Persian (Farsi) Translation Progress #1

Open

javascript-tutorial deleted a comment from javascript-translate-bot

May 6, 2021

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

amirhshahbazi commented May 4, 2021

Uh oh!

javascript-translate-bot commented May 4, 2021

Uh oh!

mahdyar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented May 4, 2021

Uh oh!

amirhshahbazi commented May 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented May 4, 2021

Uh oh!

amirhshahbazi commented May 5, 2021

Uh oh!

mahdyar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mahdyar left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.