GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Arrays by mahdiHash · Pull Request #131 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Jun 25, 2021

Copy link

Copy Markdown

Contributor

Please review and comment / commit if anything is wrong
And title of "call array this" task needs a little more attention

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 21 commits

June 16, 2021 13:32


          Translate a part of article

110fe72


          Translate a part of article

1f6396d


          Translate a part of article


          Translate a part of article

1817cec


          Merge branch 'javascript-tutorial:master' into master

6cdb74c


          Translate a part of article

4c87ad3


          Merge branch 'javascript-tutorial:master' into master

38274ac


          Translate a part of article

69af26c


          Translate a part of article

0265f25


          Change a word for better understanding

27d6901


          Translate a part of article

4f22530


          Translate article

e72bf3d


          Translate task of "item value"

162adc3


          Translate solution of "item value"

bc9aa53


          Translate task of "maximal subarray"

8a175c9


          Translate solution of maximal subarray

933abb9


          Translate task of "create array"

c5da3d8


          Translate task of "call array this"

2970e72


          Translate solution of "call array this"

a349e71


          Translate task of "array input sum"

83a2e9c


          Translate solution of "array input sum"

dfbac64

javascript-translate-bot added the review needed label

Jun 25, 2021

javascript-translate-bot requested a review from a team

June 25, 2021 20:35

javascript-translate-bot mentioned this pull request

Jun 25, 2021

Persian (Farsi) Translation Progress #1

Open


          Remove a line

5a039e4

mahdyar requested changes

Jun 26, 2021

View reviewed changes

Comment thread

1-js/05-data-types/04-array/10-maximal-subarray/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/3-call-array-this/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/3-call-array-this/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/04-array/5-array-input-sum/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 26, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jun 26, 2021


          Apply suggestions from code review

e68ea17

Co-authored-by: Mahdyar Hasanpour <[email protected]>

mahdiHash commented Jun 26, 2021

Copy link

Copy Markdown

Contributor Author

Thanks for your review, @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jun 26, 2021

javascript-translate-bot requested a review from a team

June 26, 2021 09:54

mahdyar approved these changes

Jun 26, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Jun 26, 2021

mahdyar merged commit c022449 into javascript-tutorial:master

Jun 26, 2021

javascript-translate-bot commented Jun 26, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.