GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WeakMap and WeakSet by mahdiHash · Pull Request #136 · javascript-tutorial/fa.javascript.info

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

Please review and comment / commit if anything is wrong

Summary of article needs a little more attention

I didn't know how to translate "flags" in the title of "recipients read" task, best to take a look

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mahdiHash added 10 commits July 31, 2021 22:45
@mahdiHash
Translate a part of article
dec8009
@mahdiHash
Translate a part of article
8c8319e
@mahdiHash
Translate a part of article
cb51b14
@mahdiHash
Translate a part of article
94fbd76
@mahdiHash
Translate article
63fecec 
Summary needs a little more attention
@mahdiHash
Change a line for better readability
983d0a5
@mahdiHash
Translate task of "recipients read"
76b0d36
@mahdiHash
Translate solution of "recipients read"
ed1166a
@mahdiHash
Translate task of "recipients when read"
52ee347
@mahdiHash
Translate solution of "recipients when read"
83be9a2
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 4, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 4, 2021 14:31
@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 4, 2021
Persian (Farsi) Translation Progress #1
Open
@mahdyar mahdyar self-assigned this Aug 5, 2021
mahdyar
mahdyar requested changes Aug 5, 2021
View reviewed changes
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Aug 5, 2021
@javascript-translate-bot

javascript-translate-bot commented Aug 5, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mahdiHash and others added 2 commits August 5, 2021 15:34
@mahdiHash @mahdyar
Apply suggestions from code review
300911a 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md
5638d19 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash

mahdiHash commented Aug 5, 2021

Copy link
Copy Markdown
Contributor Author

Thank you, @mahdyar
/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 5, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 5, 2021 11:06
mahdyar
mahdyar approved these changes Aug 5, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Aug 5, 2021
@mahdyar
mahdyar merged commit 3a9187b into javascript-tutorial:master Aug 5, 2021
@javascript-translate-bot

javascript-translate-bot commented Aug 5, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mahdyar mahdyar

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.